You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/09/03 09:22:19 UTC

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #16078: [Dataset] Add take, filter API to dataset

leezu commented on a change in pull request #16078: [Dataset] Add take, filter API to dataset
URL: https://github.com/apache/incubator-mxnet/pull/16078#discussion_r320172026
 
 

 ##########
 File path: python/mxnet/gluon/data/dataset.py
 ##########
 @@ -40,6 +40,41 @@ def __getitem__(self, idx):
     def __len__(self):
         raise NotImplementedError
 
+    def filter(self, fn):
 
 Review comment:
   This will eagerly retrieve all values from a `lazy=True` transformed dataset. That should be documented?
   (The transformation function will also be applied again in `__getitem__`)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services