You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "JeetKunDoug (via GitHub)" <gi...@apache.org> on 2023/05/11 21:15:27 UTC
[GitHub] [cassandra] JeetKunDoug opened a new pull request, #2326: CASSANDRA-18511 Add support for JMX in the in-jvm dtest framework (4.0)
JeetKunDoug opened a new pull request, #2326:
URL: https://github.com/apache/cassandra/pull/2326
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #2326: CASSANDRA-18511 Add support for JMX in the in-jvm dtest framework (4.0)
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic closed pull request #2326: CASSANDRA-18511 Add support for JMX in the in-jvm dtest framework (4.0)
URL: https://github.com/apache/cassandra/pull/2326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] JeetKunDoug commented on a diff in pull request #2326: CASSANDRA-18511 Add support for JMX in the in-jvm dtest framework (4.0)
Posted by "JeetKunDoug (via GitHub)" <gi...@apache.org>.
JeetKunDoug commented on code in PR #2326:
URL: https://github.com/apache/cassandra/pull/2326#discussion_r1199642215
##########
test/distributed/org/apache/cassandra/distributed/impl/InstanceConfig.java:
##########
@@ -35,7 +35,7 @@
import org.apache.cassandra.distributed.api.Feature;
import org.apache.cassandra.distributed.api.IInstanceConfig;
import org.apache.cassandra.distributed.shared.NetworkTopology;
-import org.apache.cassandra.distributed.shared.Shared;
+import org.apache.cassandra.utils.Shared;
import org.apache.cassandra.distributed.upgrade.UpgradeTestBase;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] JeetKunDoug commented on pull request #2326: CASSANDRA-18511 Add support for JMX in the in-jvm dtest framework (4.0)
Posted by "JeetKunDoug (via GitHub)" <gi...@apache.org>.
JeetKunDoug commented on PR #2326:
URL: https://github.com/apache/cassandra/pull/2326#issuecomment-1555963728
Thanks for the review(s) @jonmeredith - greatly appreciated. Should be all set now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] jonmeredith commented on a diff in pull request #2326: CASSANDRA-18511 Add support for JMX in the in-jvm dtest framework (4.0)
Posted by "jonmeredith (via GitHub)" <gi...@apache.org>.
jonmeredith commented on code in PR #2326:
URL: https://github.com/apache/cassandra/pull/2326#discussion_r1199486163
##########
relocate-dependencies.pom:
##########
@@ -67,7 +67,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
- <version>3.2.1</version>
+ <version>3.4.1</version>
Review Comment:
is this bump required to make things work?
##########
test/distributed/org/apache/cassandra/distributed/impl/InstanceConfig.java:
##########
@@ -35,7 +35,7 @@
import org.apache.cassandra.distributed.api.Feature;
import org.apache.cassandra.distributed.api.IInstanceConfig;
import org.apache.cassandra.distributed.shared.NetworkTopology;
-import org.apache.cassandra.distributed.shared.Shared;
+import org.apache.cassandra.utils.Shared;
import org.apache.cassandra.distributed.upgrade.UpgradeTestBase;
Review Comment:
fix import ordering
##########
test/distributed/org/apache/cassandra/distributed/impl/Instance.java:
##########
@@ -815,6 +1012,9 @@ public Future<Void> shutdown(boolean graceful)
// ScheduledExecutors shuts down after MessagingService, as MessagingService may issue tasks to it.
error = parallelRun(error, executor, () -> ScheduledExecutors.shutdownAndWait(1L, MINUTES));
+
+ error = parallelRun(error, executor,
+ this::stopJmx);
Review Comment:
single line like 3.11?
##########
test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java:
##########
@@ -70,11 +70,11 @@
import org.apache.cassandra.distributed.api.NodeToolResult;
import org.apache.cassandra.distributed.api.TokenSupplier;
import org.apache.cassandra.distributed.shared.InstanceClassLoader;
-import org.apache.cassandra.distributed.shared.Isolated;
+import org.apache.cassandra.utils.Isolated;
import org.apache.cassandra.distributed.shared.MessageFilters;
import org.apache.cassandra.distributed.shared.Metrics;
import org.apache.cassandra.distributed.shared.NetworkTopology;
-import org.apache.cassandra.distributed.shared.Shared;
+import org.apache.cassandra.utils.Shared;
Review Comment:
should re-order position in import list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] JeetKunDoug commented on a diff in pull request #2326: CASSANDRA-18511 Add support for JMX in the in-jvm dtest framework (4.0)
Posted by "JeetKunDoug (via GitHub)" <gi...@apache.org>.
JeetKunDoug commented on code in PR #2326:
URL: https://github.com/apache/cassandra/pull/2326#discussion_r1199642188
##########
test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java:
##########
@@ -70,11 +70,11 @@
import org.apache.cassandra.distributed.api.NodeToolResult;
import org.apache.cassandra.distributed.api.TokenSupplier;
import org.apache.cassandra.distributed.shared.InstanceClassLoader;
-import org.apache.cassandra.distributed.shared.Isolated;
+import org.apache.cassandra.utils.Isolated;
import org.apache.cassandra.distributed.shared.MessageFilters;
import org.apache.cassandra.distributed.shared.Metrics;
import org.apache.cassandra.distributed.shared.NetworkTopology;
-import org.apache.cassandra.distributed.shared.Shared;
+import org.apache.cassandra.utils.Shared;
Review Comment:
Done
##########
test/distributed/org/apache/cassandra/distributed/impl/Instance.java:
##########
@@ -815,6 +1012,9 @@ public Future<Void> shutdown(boolean graceful)
// ScheduledExecutors shuts down after MessagingService, as MessagingService may issue tasks to it.
error = parallelRun(error, executor, () -> ScheduledExecutors.shutdownAndWait(1L, MINUTES));
+
+ error = parallelRun(error, executor,
+ this::stopJmx);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] JeetKunDoug commented on a diff in pull request #2326: CASSANDRA-18511 Add support for JMX in the in-jvm dtest framework (4.0)
Posted by "JeetKunDoug (via GitHub)" <gi...@apache.org>.
JeetKunDoug commented on code in PR #2326:
URL: https://github.com/apache/cassandra/pull/2326#discussion_r1199641439
##########
relocate-dependencies.pom:
##########
@@ -67,7 +67,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
- <version>3.2.1</version>
+ <version>3.4.1</version>
Review Comment:
Yup - it's a back port from 4.1 to make the shaded dtest jar build correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] jonmeredith commented on a diff in pull request #2326: CASSANDRA-18511 Add support for JMX in the in-jvm dtest framework (4.0)
Posted by "jonmeredith (via GitHub)" <gi...@apache.org>.
jonmeredith commented on code in PR #2326:
URL: https://github.com/apache/cassandra/pull/2326#discussion_r1200965532
##########
test/distributed/org/apache/cassandra/distributed/impl/AbstractCluster.java:
##########
@@ -70,13 +70,13 @@
import org.apache.cassandra.distributed.api.NodeToolResult;
import org.apache.cassandra.distributed.api.TokenSupplier;
import org.apache.cassandra.distributed.shared.InstanceClassLoader;
-import org.apache.cassandra.distributed.shared.Isolated;
import org.apache.cassandra.distributed.shared.MessageFilters;
import org.apache.cassandra.distributed.shared.Metrics;
import org.apache.cassandra.distributed.shared.NetworkTopology;
-import org.apache.cassandra.distributed.shared.Shared;
import org.apache.cassandra.distributed.shared.ShutdownException;
import org.apache.cassandra.distributed.shared.Versions;
+import org.apache.cassandra.utils.Isolated;
+import org.apache.cassandra.utils.Shared;
Review Comment:
not sure if the UI isn't updating right, but theses two should be after `org.apache.cassandra.utils.FBUtilities`
##########
test/distributed/org/apache/cassandra/distributed/impl/Instance.java:
##########
@@ -88,6 +101,7 @@
import org.apache.cassandra.distributed.mock.nodetool.InternalNodeProbeFactory;
import org.apache.cassandra.distributed.shared.Metrics;
import org.apache.cassandra.gms.ApplicationState;
+import org.apache.cassandra.utils.ReflectionUtils;
Review Comment:
import should be later in file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org