[GitHub] [arrow] kou commented on a diff in pull request #36647: GH-36643: [C++][Parquet] Use nested namespace in parquet

["kou (via GitHub)" <gi...@apache.org>]

kou commented on code in PR #36647:
URL: https://github.com/apache/arrow/pull/36647#discussion_r1262008058


##########
cpp/src/parquet/level_conversion_inc.h:
##########
@@ -30,8 +30,7 @@
 #include "parquet/exception.h"
 #include "parquet/level_comparison.h"
 
-namespace parquet {
-namespace internal {
+namespace parquet::internal {
 #ifndef PARQUET_IMPL_NAMESPACE
 #error "PARQUET_IMPL_NAMESPACE must be defined"
 #endif

Review Comment:
   We may want to use `namespace parquet::internal::PARQUET_IMPL_NAMESPACE`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org