You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by arunmahadevan <gi...@git.apache.org> on 2015/09/02 19:37:30 UTC
[GitHub] storm pull request: [STORM-1024] Pass -Dstorm.log.dir arg to LogWr...
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/714
[STORM-1024] Pass -Dstorm.log.dir arg to LogWriter
The log4j variable `${sys:storm.log.dir}` is used in `worker.xml` to set the fileName however the system property was not being set while launching worker (via LogWriter) causing a directory by the name ${sys:storm.log.dir} to be created under `STORM_HOME` dir.
This fix is to pass the system property while launching LogWriter
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunmahadevan/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/714.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #714
----
commit 6c2b754a7a0c69852850c4dd39af31ba98ef847d
Author: Arun Mahadevan <ai...@hortonworks.com>
Date: 2015-09-02T17:31:13Z
Pass -Dstorm.log.dir arg to LogWriter
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1024] Pass -Dstorm.log.dir arg to LogWr...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/714#issuecomment-137571459
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1024] Pass -Dstorm.log.dir arg to LogWr...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/714#issuecomment-137184747
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1024] Pass -Dstorm.log.dir arg to LogWr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/714
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1024] Pass -Dstorm.log.dir arg to LogWr...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/714#issuecomment-137960650
While merging to master, I found it breaks some tests of supervisor_test.clj.
Since it's minor, I fixed things before merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---