You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by bowenli86 <gi...@git.apache.org> on 2017/09/27 23:09:24 UTC

[GitHub] flink pull request #4739: [FLINK-7724][REST][Tests][Metrics] add extra metri...

GitHub user bowenli86 opened a pull request:

    https://github.com/apache/flink/pull/4739

    [FLINK-7724][REST][Tests][Metrics] add extra metrics to MetricStoreTest.setupStore

    ## What is the purpose of the change
    
    This is a pre-requisite for FLINK-7694
    
    I'm porting `JobMetricsHandler` to new REST endpoint. Part of the migration is to make sure the json generated before and after stay the same for UI to consume, and `JobMetricsHandler` is using `MetricStoreTest.setupStore()` to get a mocked `MetricStore`. 
    
    Here comes the problem. Currently, `MetricStoreTest.setupStore()` mocks all jobs with only one metric. We need to have at least one or two jobs with multiple metrics to make the mocked `MetricStore` can cover most use cases, and ensure the Json blob generated in `JobMetricsHandler` stay the same before and after migration.
    
    ## Brief change log
    
    - make two jobs in `MetricStoreTest.setupStore()` contain multiple metrics
    
    ## Verifying this change
    
    This change is already covered by existing tests
    
    ## Does this pull request potentially affect one of the following parts:
    
    none
    
    ## Documentation
    
    none


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bowenli86/flink FLINK-7724

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4739.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4739
    
----
commit bc4aa8c3d9b057a6d35b620eb8e00048137e9361
Author: Bowen Li <bo...@gmail.com>
Date:   2017-09-27T22:30:02Z

    [FLINK-7724] add extra metrics to MetricStoreTest.setupStore

commit d223444eba17c620e8c45c372a7b2e6fafdfd169
Author: Bowen Li <bo...@gmail.com>
Date:   2017-09-27T22:39:17Z

    delete unrelated files

----


---

[GitHub] flink issue #4739: [FLINK-7724][REST][Tests][Metrics] add extra metrics to M...

Posted by bowenli86 <gi...@git.apache.org>.

Github user bowenli86 commented on the issue:

    https://github.com/apache/flink/pull/4739
  
    cc @tillrohrmann  @zentol 


---

[GitHub] flink issue #4739: [FLINK-7724][REST][Tests][Metrics] add extra metrics to M...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4739
  
    merging.


---

[GitHub] flink pull request #4739: [FLINK-7724][REST][Tests][Metrics] add extra metri...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4739


---