You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2014/09/13 00:03:58 UTC
Review Request 25596: Views : Delete view instance causes auto sign
out
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25596/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Sid Wagle.
Bugs: AMBARI-7289
https://issues.apache.org/jira/browse/AMBARI-7289
Repository: ambari
Description
-------
Steps :
1 Login as admin
2 Create new view instance for any view
3 Delete the new view instance
This will redirect to the login page and you will no longer be logged in.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java 6a831f8
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariHandlerListTest.java 7171e88
Diff: https://reviews.apache.org/r/25596/diff/
Testing
-------
Manual tests.
All existing tests pass.
Results :
Tests run: 1986, Failures: 0, Errors: 0, Skipped: 16
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34:53.921s
[INFO] Finished at: Fri Sep 12 17:14:22 EDT 2014
[INFO] Final Memory: 45M/330M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
Re: Review Request 25596: Views : Delete view instance causes auto
sign out
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25596/#review53357
-----------------------------------------------------------
Ship it!
- Alejandro Fernandez
On Sept. 15, 2014, 3:11 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25596/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2014, 3:11 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-7289
> https://issues.apache.org/jira/browse/AMBARI-7289
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Steps :
>
> 1 Login as admin
> 2 Create new view instance for any view
> 3 Delete the new view instance
>
> This will redirect to the login page and you will no longer be logged in.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java 6a831f8
>
> Diff: https://reviews.apache.org/r/25596/diff/
>
>
> Testing
> -------
>
> Manual tests.
>
> All existing tests pass.
>
> Results :
>
> Tests run: 1986, Failures: 0, Errors: 0, Skipped: 16
>
> ...
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:53.921s
> [INFO] Finished at: Fri Sep 12 17:14:22 EDT 2014
> [INFO] Final Memory: 45M/330M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 25596: Views : Delete view instance causes auto
sign out
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25596/
-----------------------------------------------------------
(Updated Sept. 15, 2014, 3:11 p.m.)
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sid Wagle.
Bugs: AMBARI-7289
https://issues.apache.org/jira/browse/AMBARI-7289
Repository: ambari
Description
-------
Steps :
1 Login as admin
2 Create new view instance for any view
3 Delete the new view instance
This will redirect to the login page and you will no longer be logged in.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java 6a831f8
Diff: https://reviews.apache.org/r/25596/diff/
Testing
-------
Manual tests.
All existing tests pass.
Results :
Tests run: 1986, Failures: 0, Errors: 0, Skipped: 16
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34:53.921s
[INFO] Finished at: Fri Sep 12 17:14:22 EDT 2014
[INFO] Final Memory: 45M/330M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
Re: Review Request 25596: Views : Delete view instance causes auto
sign out
Posted by Tom Beerbower <tb...@hortonworks.com>.
> On Sept. 15, 2014, 3:04 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java, line 139
> > <https://reviews.apache.org/r/25596/diff/1/?file=688042#file688042line139>
> >
> > What happens when the following happens,
> > add view foo, remove it, repeat?
> > A second handler is added, but what happens to the first handler?
Thanks for reviewing. I've updated the diff. I think that you are looking at revision 1 which was mostly undone with revision 2. Your question did make me realize that I wasn't removing the handler from the member handlerMap in removeViewInstance(). Is that what you were pointing out? I just updated with revision 3 that fixes it. When you remove a handler (WebAppContext), it should be removed from the underlying Jetty HandlerCollection as well as the member handlerMap. This should stop the WebAppContext without stopping the shared SessionManager. The WebAppContext should no longer be referenced and will ultimately be GC'd.
- Tom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25596/#review53341
-----------------------------------------------------------
On Sept. 15, 2014, 3:11 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25596/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2014, 3:11 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-7289
> https://issues.apache.org/jira/browse/AMBARI-7289
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Steps :
>
> 1 Login as admin
> 2 Create new view instance for any view
> 3 Delete the new view instance
>
> This will redirect to the login page and you will no longer be logged in.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java 6a831f8
>
> Diff: https://reviews.apache.org/r/25596/diff/
>
>
> Testing
> -------
>
> Manual tests.
>
> All existing tests pass.
>
> Results :
>
> Tests run: 1986, Failures: 0, Errors: 0, Skipped: 16
>
> ...
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:53.921s
> [INFO] Finished at: Fri Sep 12 17:14:22 EDT 2014
> [INFO] Final Memory: 45M/330M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 25596: Views : Delete view instance causes auto
sign out
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25596/#review53341
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java
<https://reviews.apache.org/r/25596/#comment92975>
What happens when the following happens,
add view foo, remove it, repeat?
A second handler is added, but what happens to the first handler?
- Alejandro Fernandez
On Sept. 15, 2014, 2:47 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25596/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2014, 2:47 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-7289
> https://issues.apache.org/jira/browse/AMBARI-7289
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Steps :
>
> 1 Login as admin
> 2 Create new view instance for any view
> 3 Delete the new view instance
>
> This will redirect to the login page and you will no longer be logged in.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java 6a831f8
>
> Diff: https://reviews.apache.org/r/25596/diff/
>
>
> Testing
> -------
>
> Manual tests.
>
> All existing tests pass.
>
> Results :
>
> Tests run: 1986, Failures: 0, Errors: 0, Skipped: 16
>
> ...
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:53.921s
> [INFO] Finished at: Fri Sep 12 17:14:22 EDT 2014
> [INFO] Final Memory: 45M/330M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 25596: Views : Delete view instance causes auto
sign out
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25596/#review53340
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Sept. 15, 2014, 10:47 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25596/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2014, 10:47 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sid Wagle.
>
>
> Bugs: AMBARI-7289
> https://issues.apache.org/jira/browse/AMBARI-7289
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Steps :
>
> 1 Login as admin
> 2 Create new view instance for any view
> 3 Delete the new view instance
>
> This will redirect to the login page and you will no longer be logged in.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java 6a831f8
>
> Diff: https://reviews.apache.org/r/25596/diff/
>
>
> Testing
> -------
>
> Manual tests.
>
> All existing tests pass.
>
> Results :
>
> Tests run: 1986, Failures: 0, Errors: 0, Skipped: 16
>
> ...
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 34:53.921s
> [INFO] Finished at: Fri Sep 12 17:14:22 EDT 2014
> [INFO] Final Memory: 45M/330M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 25596: Views : Delete view instance causes auto
sign out
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25596/
-----------------------------------------------------------
(Updated Sept. 15, 2014, 2:47 p.m.)
Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sid Wagle.
Bugs: AMBARI-7289
https://issues.apache.org/jira/browse/AMBARI-7289
Repository: ambari
Description
-------
Steps :
1 Login as admin
2 Create new view instance for any view
3 Delete the new view instance
This will redirect to the login page and you will no longer be logged in.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java 6a831f8
Diff: https://reviews.apache.org/r/25596/diff/
Testing
-------
Manual tests.
All existing tests pass.
Results :
Tests run: 1986, Failures: 0, Errors: 0, Skipped: 16
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34:53.921s
[INFO] Finished at: Fri Sep 12 17:14:22 EDT 2014
[INFO] Final Memory: 45M/330M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
Re: Review Request 25596: Views : Delete view instance causes auto
sign out
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25596/
-----------------------------------------------------------
(Updated Sept. 15, 2014, 2:46 p.m.)
Review request for Ambari, Alejandro Fernandez and Sid Wagle.
Bugs: AMBARI-7289
https://issues.apache.org/jira/browse/AMBARI-7289
Repository: ambari
Description
-------
Steps :
1 Login as admin
2 Create new view instance for any view
3 Delete the new view instance
This will redirect to the login page and you will no longer be logged in.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java 6a831f8
Diff: https://reviews.apache.org/r/25596/diff/
Testing
-------
Manual tests.
All existing tests pass.
Results :
Tests run: 1986, Failures: 0, Errors: 0, Skipped: 16
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34:53.921s
[INFO] Finished at: Fri Sep 12 17:14:22 EDT 2014
[INFO] Final Memory: 45M/330M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower