You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by "chrisdutz (via GitHub)" <gi...@apache.org> on 2023/02/04 15:22:25 UTC
[PR] Various Changes (plc4x)
chrisdutz opened a new pull request, #784:
URL: https://github.com/apache/plc4x/pull/784
This is a Pull Request containing various changes from the repo https://github.com/spnettec/plc4x
It seems they deal with:
- String handling in S7
- Support for S7 200
- Changes in the Timeout-Handling of our driver base
- Extensions to the OPC-UA driver
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Various Changes (plc4x)
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #784:
URL: https://github.com/apache/plc4x/pull/784#issuecomment-1417281459
I had a look at what he did. He downloaded the files, added them and added data points that we didn't have. Thought worth investigating what they are?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Various Changes (plc4x)
Posted by "hutcheb (via GitHub)" <gi...@apache.org>.
hutcheb commented on PR #784:
URL: https://github.com/apache/plc4x/pull/784#issuecomment-1416920196
With the OPCUA protocol package, it seems to include MIT licensed files we use to generate the mspec. While it is a good idea to include them so we don't pull new updates automatically from their Github repo. I don't know if it is compatible with the ASF's rules?
The changes to the OPCUA driver and opcuaserver packages seem to be minimal, but should be good additions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Various Changes (plc4x)
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #784:
URL: https://github.com/apache/plc4x/pull/784#issuecomment-1416781289
Admittedly I would not like to merge this PR ... but I think we should have a look at it and possibly pick individual fixes, if we think they are good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Various Changes (plc4x)
Posted by "sruehl (via GitHub)" <gi...@apache.org>.
sruehl commented on PR #784:
URL: https://github.com/apache/plc4x/pull/784#issuecomment-1438812021
I'm a little bit confused about the commits in this PR. Is this some rebase commit manipulating issue? E.g. why does it contain dependabot commits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Various Changes (plc4x)
Posted by "heyoulin (via GitHub)" <gi...@apache.org>.
heyoulin commented on PR #784:
URL: https://github.com/apache/plc4x/pull/784#issuecomment-1428274437
@chrisdutz Thank you for this pull request. I have no time to merge my changes. Since I've been so busy recently. I don't have time to do this. Thank you so much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Various Changes (plc4x)
Posted by "heyoulin (via GitHub)" <gi...@apache.org>.
heyoulin commented on PR #784:
URL: https://github.com/apache/plc4x/pull/784#issuecomment-1428293696
You shoud take look plc4x driver and server. I modify the tag and can use fit for general read and write tag format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Various Changes (plc4x)
Posted by "sruehl (via GitHub)" <gi...@apache.org>.
sruehl commented on PR #784:
URL: https://github.com/apache/plc4x/pull/784#issuecomment-1419324203
> Admittedly I would not like to merge this PR ... but I think we should have a look at it and possibly pick individual fixes, if we think they are good.
I set it to draft so we don't do by accident
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Various Changes (plc4x)
Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on PR #784:
URL: https://github.com/apache/plc4x/pull/784#issuecomment-1439547955
I created it by checking out our version at the last version that was merged into the other repo and the other two in its latest version. Then I had intellij compare the two directories and manually went through that huge diff, ignoring generated code and I pulled what I think we should discuss adopting (didn't pull everything)... Hope that explains it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org