You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Andrea Del Bene <an...@gmail.com> on 2018/02/11 16:34:08 UTC

[VOTE] Release Apache Wicket 8.0.0-M9

This is a vote to release Apache Wicket 8.0.0-M9

Please download the source distributions found in our staging area
linked below.

I have included the signatures for both the source archives. This vote
lasts for 72 hours minimum.

[ ] Yes, release Apache Wicket 8.0.0-M9
[ ] No, don't release Apache Wicket 8.0.0-M9, because ...

Distributions, changelog, keys and signatures can be found at:

     https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9

Staging repository:

https://repository.apache.org/content/repositories/orgapachewicket-1105/

The binaries are available in the above link, as are a staging
repository for Maven. Typically the vote is on the source, but should
you find a problem with one of the binaries, please let me know, I can
re-roll them some way or the other.

Staging git repository data:

     Repository:  git@github.com:bitstorm/wicket.git
     Branch:      build/wicket-8.0.0-M9
     Release tag: rel/wicket-8.0.0-M9


========================================================================

     The signatures for the source release artefacts:


Signature for apache-wicket-8.0.0-M9.zip:

     -----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
jIvOQJKU+bwlubLLneTg
=MOtP
-----END PGP SIGNATURE-----

Signature for apache-wicket-8.0.0-M9.tar.gz:

     -----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
CCJOHO3iofZ0wlGnB5J7
=/qPh
-----END PGP SIGNATURE-----

========================================================================

     CHANGELOG for 8.0.0-M9:

** Bug

     * [WICKET-6332] - NullPointerException in PageParameters#equals()
     * [WICKET-6441] - MockHttpSession and MockSessionStore don't call 
onInvalidate() on invalidate()
     * [WICKET-6448] - Provide behavior that disables a button after click
     * [WICKET-6477] - Component.getDefaultModelObject() wraps in 
RuntimeException instead of WicketRuntimeException
     * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
     * [WICKET-6489] - Exception when "identifier|code" javascript is 
not start on PrependJavaScript
     * [WICKET-6491] - AjaxDownload is not working in blob mode for 
Microsoft browsers
     * [WICKET-6492] - javascript files are not minified in deployment 
mode and not united
     * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession one 
used instead of Websocket one) + NPE if no HttpSession is found during 
Handshake Request
     * [WICKET-6496] - Duplicate definition of interface JSONString
     * [WICKET-6501] - DefaultPageManagerProvider does not honour 
StoreSettings.setAsynchronous(false)
     * [WICKET-6506] - Performance issue when large component isn't visible
     * [WICKET-6512] - pageId is being reset during 
Session::replaceSession() call
     * [WICKET-6513] - NullPointerException at 
PageStoreManager$SessionEntry after login
     * [WICKET-6518] - Memory leaks on quickstart restart in tomcat
     * [WICKET-6522] - ThreadLocal leak in PageStoreManager
     * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same component 
timeId conflict
     * [WICKET-6524] - Do not require bean validation 2.0.0
     * [WICKET-6529] - Feedback from onSubmit not rendered on stateless 
pages
     * [WICKET-6530] - Race-condition in session invalidation

** New Feature

     * [WICKET-6497] - unify javascript files
     * [WICKET-6498] - wicket 8 - js to asnyc and or defer

** Improvement

     * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking 
lazy load
     * [WICKET-6284] - Introduce lambda-enhanced factory method in 
ResourceReference
     * [WICKET-6499] - Support for Bean Validation 2.0
     * [WICKET-6503] - Ajax refresh and feedback panel
     * [WICKET-6504] - Use a serializable model for FileSystemResource's 
path
     * [WICKET-6509] - Import junit packages as optional
     * [WICKET-6514] - FeedbackCollector(Component) should not collect 
session-scoped feedback messages
     * [WICKET-6517] - use Ajax for multipart instead of iframe

** Task

     * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent() before 
Wicket 8.0.0


Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Maxim Solodovnik <so...@gmail.com>.
Hello Andrea

The description is here
https://issues.apache.org/jira/browse/WICKET-6498?focusedCommentId=16349021&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16349021
Am not observing any "races" in our main app, so I can't describe it myself
:(


On Thu, Feb 15, 2018 at 10:48 PM, Andrea Del Bene <an...@gmail.com>
wrote:

> Hi,
>
> I need your help. what's exactly the caveat about  WICKET-6498? It uses
> javascript events that might not be supported buy browser?
>
> On Sun, Feb 11, 2018 at 6:16 PM, Korbinian Bachl <
> korbinian.bachl@whiskyworld.de> wrote:
>
> > +1 to release for M9
> >
> > IMHO a warning should be added with regards to WICKET-6498 as it is not
> > yet working in a reliable way but may break depending on client
> specifics;
> >
> > ----- Ursprüngliche Mail -----
> > > Von: "Andrea Del Bene" <an...@gmail.com>
> > > An: dev@wicket.apache.org
> > > Gesendet: Sonntag, 11. Februar 2018 17:34:08
> > > Betreff: [VOTE] Release Apache Wicket 8.0.0-M9
> >
> > > This is a vote to release Apache Wicket 8.0.0-M9
> > >
> > > Please download the source distributions found in our staging area
> > > linked below.
> > >
> > > I have included the signatures for both the source archives. This vote
> > > lasts for 72 hours minimum.
> > >
> > > [ ] Yes, release Apache Wicket 8.0.0-M9
> > > [ ] No, don't release Apache Wicket 8.0.0-M9, because ...
> > >
> > > Distributions, changelog, keys and signatures can be found at:
> > >
> > >     https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9
> > >
> > > Staging repository:
> > >
> > > https://repository.apache.org/content/repositories/
> orgapachewicket-1105/
> > >
> > > The binaries are available in the above link, as are a staging
> > > repository for Maven. Typically the vote is on the source, but should
> > > you find a problem with one of the binaries, please let me know, I can
> > > re-roll them some way or the other.
> > >
> > > Staging git repository data:
> > >
> > >     Repository:  git@github.com:bitstorm/wicket.git
> > >     Branch:      build/wicket-8.0.0-M9
> > >     Release tag: rel/wicket-8.0.0-M9
> > >
> > >
> > > ============================================================
> ============
> > >
> > >     The signatures for the source release artefacts:
> > >
> > >
> > > Signature for apache-wicket-8.0.0-M9.zip:
> > >
> > >     -----BEGIN PGP SIGNATURE-----
> > > Version: GnuPG v1
> > >
> > > iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
> > > Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
> > > rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
> > > YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
> > > Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
> > > EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
> > > Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
> > > E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
> > > TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
> > > Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
> > > K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
> > > jIvOQJKU+bwlubLLneTg
> > > =MOtP
> > > -----END PGP SIGNATURE-----
> > >
> > > Signature for apache-wicket-8.0.0-M9.tar.gz:
> > >
> > >     -----BEGIN PGP SIGNATURE-----
> > > Version: GnuPG v1
> > >
> > > iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
> > > b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
> > > oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
> > > nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
> > > B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
> > > hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
> > > aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
> > > sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
> > > YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
> > > GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
> > > 3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
> > > CCJOHO3iofZ0wlGnB5J7
> > > =/qPh
> > > -----END PGP SIGNATURE-----
> > >
> > > ============================================================
> ============
> > >
> > >     CHANGELOG for 8.0.0-M9:
> > >
> > > ** Bug
> > >
> > >     * [WICKET-6332] - NullPointerException in PageParameters#equals()
> > >     * [WICKET-6441] - MockHttpSession and MockSessionStore don't call
> > > onInvalidate() on invalidate()
> > >     * [WICKET-6448] - Provide behavior that disables a button after
> click
> > >     * [WICKET-6477] - Component.getDefaultModelObject() wraps in
> > > RuntimeException instead of WicketRuntimeException
> > >     * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
> > >     * [WICKET-6489] - Exception when "identifier|code" javascript is
> > > not start on PrependJavaScript
> > >     * [WICKET-6491] - AjaxDownload is not working in blob mode for
> > > Microsoft browsers
> > >     * [WICKET-6492] - javascript files are not minified in deployment
> > > mode and not united
> > >     * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession one
> > > used instead of Websocket one) + NPE if no HttpSession is found during
> > > Handshake Request
> > >     * [WICKET-6496] - Duplicate definition of interface JSONString
> > >     * [WICKET-6501] - DefaultPageManagerProvider does not honour
> > > StoreSettings.setAsynchronous(false)
> > >     * [WICKET-6506] - Performance issue when large component isn't
> > visible
> > >     * [WICKET-6512] - pageId is being reset during
> > > Session::replaceSession() call
> > >     * [WICKET-6513] - NullPointerException at
> > > PageStoreManager$SessionEntry after login
> > >     * [WICKET-6518] - Memory leaks on quickstart restart in tomcat
> > >     * [WICKET-6522] - ThreadLocal leak in PageStoreManager
> > >     * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same component
> > > timeId conflict
> > >     * [WICKET-6524] - Do not require bean validation 2.0.0
> > >     * [WICKET-6529] - Feedback from onSubmit not rendered on stateless
> > > pages
> > >     * [WICKET-6530] - Race-condition in session invalidation
> > >
> > > ** New Feature
> > >
> > >     * [WICKET-6497] - unify javascript files
> > >     * [WICKET-6498] - wicket 8 - js to asnyc and or defer
> > >
> > > ** Improvement
> > >
> > >     * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking
> > > lazy load
> > >     * [WICKET-6284] - Introduce lambda-enhanced factory method in
> > > ResourceReference
> > >     * [WICKET-6499] - Support for Bean Validation 2.0
> > >     * [WICKET-6503] - Ajax refresh and feedback panel
> > >     * [WICKET-6504] - Use a serializable model for FileSystemResource's
> > > path
> > >     * [WICKET-6509] - Import junit packages as optional
> > >     * [WICKET-6514] - FeedbackCollector(Component) should not collect
> > > session-scoped feedback messages
> > >     * [WICKET-6517] - use Ajax for multipart instead of iframe
> > >
> > > ** Task
> > >
> > >     * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent() before
> > > Wicket 8.0.0
> >
>



-- 
WBR
Maxim aka solomax

Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Andrea Del Bene <an...@gmail.com>.
This vote passes. Thank you all!


On 16/02/2018 14:45, Andrea Del Bene wrote:
> Thank you Sven. I confirm my positive vote.
>
> On Fri, Feb 16, 2018 at 2:25 PM, Sven Meier <sven@meiers.net 
> <ma...@meiers.net>> wrote:
>
>     Hi all,
>
>     there's no need to make a fuss about this feature.
>
>     When Korbinian and I started working on deferred JavaScript, I was
>     under the impression:
>
>     a) that the JavaScript part is sorted out already
>     b) every framework supports it (to be kind of cool)
>     b) we have to rework major parts to bake this into Wicket
>
>     Now I understand that
>
>     x) deferred loading of JavaSript is fucked up in browsers
>     y) other frameworks are struggling with this too
>     z) only a tiny change was required in Wicket to allow people to
>     experiment with deferred JavaScript
>
>     We *need* a note in the release notes for z), as the handling of
>     IHeaderResponseDecorator has slightly. I don't consider this a big
>     deal, because users will have to change a *single* place only *if*
>     they use JavaScriptFilteredIntoFooterHeaderResponse at all.
>     Compare that with introducing Optional for the return of
>     RequestTarget#find(): that might *silently* break applications and
>     requires to rework possibly *hundreds* of code places.
>
>     Furthermore WICKET- 6498 added a single class
>     JavaScriptDeferHeaderResponse only - yes, it's experimental but
>     with no API surface to break in the future. Nobody has to use it
>     so I don't see the need to praise/warn about it in the release notes.
>     I don't consider it broken, browsers are broken. However I have no
>     problem to remove that class: we can just put it into confluence
>     or wicketstuff.
>
>     Once again: It is a *single* class with *no* API - that's nothing
>     compared to component queueing :P
>
>     Have fun
>     Sven
>
>
>
>
>     Am 16.02.2018 um 13:32 schrieb Andrea Del Bene:
>
>         On Feb 16, 2018 10:50 AM, "Martin Grigorov"
>         <mgrigorov@apache.org <ma...@apache.org>> wrote:
>
>         On Fri, Feb 16, 2018 at 10:41 AM, Andrea Del Bene
>         <an.delbene@gmail.com <ma...@gmail.com>>
>         wrote:
>
>             That's what I'd write in the release note:
>
>             Caveats
>             ------------------
>             WICKET-6498 might not work as expected due to a known
>             issues with all
>
>         major
>
>             browsers (Chrome, Firefox, IE > 10) which allows deferred
>             scripts to be
>             executed before DOMContentLoaded is fired. For this reason
>             WICKET-6498
>             should be avoided for production applications and used
>             carefully.
>
>             WDYT?
>
>         Why do we ship it if it is known to be broken ?
>         AFAIR we don't have such precedent before.
>
>
>         Have you forgotten about components queueing :-D :-D?
>
>
>
>             On Thu, Feb 15, 2018 at 9:15 PM, Korbinian Bachl <
>             korbinian.bachl@whiskyworld.de
>             <ma...@whiskyworld.de>> wrote:
>
>                 in short: since IE 11 and chrome as well as FF the
>                 browsers dont fire
>
>         the
>
>                 DOMContentLoaded of scripts the way one would expect.
>                 This happens as
>
>         the
>
>                 browsers branch multiple threads that each thread put
>                 together execution
>                 groups of orders leading to inline-JS getting executed
>                 and events on
>
>             these
>
>                 fired without the knowledge of other JS resources as
>                 long as these are
>                 defered and / or / asnyc'd
>
>                 Even worse, an app that may work well in local mode
>                 may break in
>                 production as network timing as well as client CPU
>                 count (influences
>                 thread) and speed of CPU and or GPU (yep... ) may
>                 change the timings the
>                 event DOMContentLoaded  gets fired;
>
>                 even JQuery guys are plagued by this and have no real
>                 solution to it now
>                 IMHO https://github.com/jquery/jquery/issues/3271
>                 <https://github.com/jquery/jquery/issues/3271>
>
>                 I think we can get a real working one for wicket but
>                 had no time yet to
>                 try it out; Idea is to create the wicket object in the
>                 head at first
>
>             inline
>
>                 script before any JS resources (defered or not) so
>                 that the page itself
>                 cant break because of this
>
>
>                 ----- Ursprüngliche Mail -----
>
>                     Von: "Andrea Del Bene" <an.delbene@gmail.com
>                     <ma...@gmail.com>>
>                     An: dev@wicket.apache.org
>                     <ma...@wicket.apache.org>
>                     Gesendet: Donnerstag, 15. Februar 2018 16:48:18
>                     Betreff: Re: [VOTE] Release Apache Wicket 8.0.0-M9
>                     Hi,
>
>                     I need your help. what's exactly the caveat about 
>                     WICKET-6498? It
>
>         uses
>
>                     javascript events that might not be supported buy
>                     browser?
>
>                     On Sun, Feb 11, 2018 at 6:16 PM, Korbinian Bachl <
>                     korbinian.bachl@whiskyworld.de
>                     <ma...@whiskyworld.de>> wrote:
>
>                         +1 to release for M9
>
>                         IMHO a warning should be added with regards to
>                         WICKET-6498 as it is
>
>             not
>
>                         yet working in a reliable way but may break
>                         depending on client
>
>                 specifics;
>
>                         ----- Ursprüngliche Mail -----
>
>                             Von: "Andrea Del Bene"
>                             <an.delbene@gmail.com
>                             <ma...@gmail.com>>
>                             An: dev@wicket.apache.org
>                             <ma...@wicket.apache.org>
>                             Gesendet: Sonntag, 11. Februar 2018 17:34:08
>                             Betreff: [VOTE] Release Apache Wicket 8.0.0-M9
>                             This is a vote to release Apache Wicket
>                             8.0.0-M9
>
>                             Please download the source distributions
>                             found in our staging area
>                             linked below.
>
>                             I have included the signatures for both
>                             the source archives. This
>
>             vote
>
>                             lasts for 72 hours minimum.
>
>                             [ ] Yes, release Apache Wicket 8.0.0-M9
>                             [ ] No, don't release Apache Wicket
>                             8.0.0-M9, because ...
>
>                             Distributions, changelog, keys and
>                             signatures can be found at:
>
>                             https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9
>                             <https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9>
>
>                             Staging repository:
>
>                             https://repository.apache.org/content/repositories/
>                             <https://repository.apache.org/content/repositories/>
>
>                 orgapachewicket-1105/
>
>                             The binaries are available in the above
>                             link, as are a staging
>                             repository for Maven. Typically the vote
>                             is on the source, but
>
>             should
>
>                             you find a problem with one of the
>                             binaries, please let me know, I
>
>             can
>
>                             re-roll them some way or the other.
>
>                             Staging git repository data:
>
>                                  Repository:
>                             git@github.com:bitstorm/wicket.git
>                                  Branch:      build/wicket-8.0.0-M9
>                                  Release tag: rel/wicket-8.0.0-M9
>
>
>                             ============================================================
>
>                 ============
>
>                                  The signatures for the source release
>                             artefacts:
>
>
>                             Signature for apache-wicket-8.0.0-M9.zip:
>
>                                  -----BEGIN PGP SIGNATURE-----
>                             Version: GnuPG v1
>
>                             iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
>                             Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
>                             rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
>                             YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
>                             Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
>                             EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
>                             Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
>                             E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
>                             TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
>                             Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
>                             K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
>                             jIvOQJKU+bwlubLLneTg
>                             =MOtP
>                             -----END PGP SIGNATURE-----
>
>                             Signature for apache-wicket-8.0.0-M9.tar.gz:
>
>                                  -----BEGIN PGP SIGNATURE-----
>                             Version: GnuPG v1
>
>                             iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
>                             b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
>                             oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
>                             nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
>                             B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
>                             hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
>                             aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
>                             sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
>                             YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
>                             GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
>                             3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
>                             CCJOHO3iofZ0wlGnB5J7
>                             =/qPh
>                             -----END PGP SIGNATURE-----
>
>                             ============================================================
>
>                 ============
>
>                                  CHANGELOG for 8.0.0-M9:
>
>                             ** Bug
>
>                                  * [WICKET-6332] - NullPointerException in
>
>             PageParameters#equals()
>
>                                  * [WICKET-6441] - MockHttpSession and
>                             MockSessionStore don't
>
>             call
>
>                             onInvalidate() on invalidate()
>                                  * [WICKET-6448] - Provide behavior
>                             that disables a button after
>
>                 click
>
>                                  * [WICKET-6477] -
>                             Component.getDefaultModelObject() wraps in
>                             RuntimeException instead of
>                             WicketRuntimeException
>                                  * [WICKET-6484] - Wicket.Cookie.set
>                             does not set 'secure' flag
>                                  * [WICKET-6489] - Exception when
>                             "identifier|code" javascript
>
>         is
>
>                             not start on PrependJavaScript
>                                  * [WICKET-6491] - AjaxDownload is not
>                             working in blob mode for
>                             Microsoft browsers
>                                  * [WICKET-6492] - javascript files
>                             are not minified in
>
>             deployment
>
>                             mode and not united
>                                  * [WICKET-6493] - WebSocket
>                             SessionIds are wrong (HttpSession
>
>             one
>
>                             used instead of Websocket one) + NPE if no
>                             HttpSession is found
>
>             during
>
>                             Handshake Request
>                                  * [WICKET-6496] - Duplicate
>                             definition of interface JSONString
>                                  * [WICKET-6501] -
>                             DefaultPageManagerProvider does not honour
>                             StoreSettings.setAsynchronous(false)
>                                  * [WICKET-6506] - Performance issue
>                             when large component isn't
>
>                         visible
>
>                                  * [WICKET-6512] - pageId is being
>                             reset during
>                             Session::replaceSession() call
>                                  * [WICKET-6513] - NullPointerException at
>                             PageStoreManager$SessionEntry after login
>                                  * [WICKET-6518] - Memory leaks on
>                             quickstart restart in tomcat
>                                  * [WICKET-6522] - ThreadLocal leak in
>                             PageStoreManager
>                                  * [WICKET-6523] - Two
>                             AbstractAjaxTimerBehaviors on same
>
>             component
>
>                             timeId conflict
>                                  * [WICKET-6524] - Do not require bean
>                             validation 2.0.0
>                                  * [WICKET-6529] - Feedback from
>                             onSubmit not rendered on
>
>             stateless
>
>                             pages
>                                  * [WICKET-6530] - Race-condition in
>                             session invalidation
>
>                             ** New Feature
>
>                                  * [WICKET-6497] - unify javascript files
>                                  * [WICKET-6498] - wicket 8 - js to
>                             asnyc and or defer
>
>                             ** Improvement
>
>                                  * [WICKET-6055] - AjaxLazyLoadPanel
>                             should provide non-blocking
>                             lazy load
>                                  * [WICKET-6284] - Introduce
>                             lambda-enhanced factory method in
>                             ResourceReference
>                                  * [WICKET-6499] - Support for Bean
>                             Validation 2.0
>                                  * [WICKET-6503] - Ajax refresh and
>                             feedback panel
>                                  * [WICKET-6504] - Use a serializable
>                             model for
>
>                 FileSystemResource's
>
>                             path
>                                  * [WICKET-6509] - Import junit
>                             packages as optional
>                                  * [WICKET-6514] -
>                             FeedbackCollector(Component) should not
>
>             collect
>
>                             session-scoped feedback messages
>                                  * [WICKET-6517] - use Ajax for
>                             multipart instead of iframe
>
>                             ** Task
>
>                                  * [WICKET-6148] - Remove
>                             AjaxEventBehavior#onCheckEvent()
>
>             before
>
>                             Wicket 8.0.0
>
>
>


Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Andrea Del Bene <an...@gmail.com>.
Thank you Sven. I confirm my positive vote.

On Fri, Feb 16, 2018 at 2:25 PM, Sven Meier <sv...@meiers.net> wrote:

> Hi all,
>
> there's no need to make a fuss about this feature.
>
> When Korbinian and I started working on deferred JavaScript, I was under
> the impression:
>
> a) that the JavaScript part is sorted out already
> b) every framework supports it (to be kind of cool)
> b) we have to rework major parts to bake this into Wicket
>
> Now I understand that
>
> x) deferred loading of JavaSript is fucked up in browsers
> y) other frameworks are struggling with this too
> z) only a tiny change was required in Wicket to allow people to experiment
> with deferred JavaScript
>
> We *need* a note in the release notes for z), as the handling of
> IHeaderResponseDecorator has slightly. I don't consider this a big deal,
> because users will have to change a *single* place only *if* they use
> JavaScriptFilteredIntoFooterHeaderResponse at all.
> Compare that with introducing Optional for the return of
> RequestTarget#find(): that might *silently* break applications and requires
> to rework possibly *hundreds* of code places.
>
> Furthermore WICKET- 6498 added a single class
> JavaScriptDeferHeaderResponse only - yes, it's experimental but with no API
> surface to break in the future. Nobody has to use it so I don't see the
> need to praise/warn about it in the release notes.
> I don't consider it broken, browsers are broken. However I have no problem
> to remove that class: we can just put it into confluence or wicketstuff.
>
> Once again: It is a *single* class with *no* API - that's nothing compared
> to component queueing :P
>
> Have fun
> Sven
>
>
>
>
> Am 16.02.2018 um 13:32 schrieb Andrea Del Bene:
>
>> On Feb 16, 2018 10:50 AM, "Martin Grigorov" <mg...@apache.org> wrote:
>>
>> On Fri, Feb 16, 2018 at 10:41 AM, Andrea Del Bene <an...@gmail.com>
>> wrote:
>>
>> That's what I'd write in the release note:
>>>
>>> Caveats
>>> ------------------
>>> WICKET-6498 might not work as expected due to a known issues with all
>>>
>> major
>>
>>> browsers (Chrome, Firefox, IE > 10) which allows deferred scripts to be
>>> executed before DOMContentLoaded is fired. For this reason WICKET-6498
>>> should be avoided for production applications and used carefully.
>>>
>>> WDYT?
>>>
>>> Why do we ship it if it is known to be broken ?
>> AFAIR we don't have such precedent before.
>>
>>
>> Have you forgotten about components queueing :-D :-D?
>>
>>
>>
>> On Thu, Feb 15, 2018 at 9:15 PM, Korbinian Bachl <
>>> korbinian.bachl@whiskyworld.de> wrote:
>>>
>>> in short: since IE 11 and chrome as well as FF the browsers dont fire
>>>>
>>> the
>>
>>> DOMContentLoaded of scripts the way one would expect. This happens as
>>>>
>>> the
>>
>>> browsers branch multiple threads that each thread put together execution
>>>> groups of orders leading to inline-JS getting executed and events on
>>>>
>>> these
>>>
>>>> fired without the knowledge of other JS resources as long as these are
>>>> defered and / or / asnyc'd
>>>>
>>>> Even worse, an app that may work well in local mode may break in
>>>> production as network timing as well as client CPU count (influences
>>>> thread) and speed of CPU and or GPU (yep... ) may change the timings the
>>>> event DOMContentLoaded  gets fired;
>>>>
>>>> even JQuery guys are plagued by this and have no real solution to it now
>>>> IMHO https://github.com/jquery/jquery/issues/3271
>>>>
>>>> I think we can get a real working one for wicket but had no time yet to
>>>> try it out; Idea is to create the wicket object in the head at first
>>>>
>>> inline
>>>
>>>> script before any JS resources (defered or not) so that the page itself
>>>> cant break because of this
>>>>
>>>>
>>>> ----- Ursprüngliche Mail -----
>>>>
>>>>> Von: "Andrea Del Bene" <an...@gmail.com>
>>>>> An: dev@wicket.apache.org
>>>>> Gesendet: Donnerstag, 15. Februar 2018 16:48:18
>>>>> Betreff: Re: [VOTE] Release Apache Wicket 8.0.0-M9
>>>>> Hi,
>>>>>
>>>>> I need your help. what's exactly the caveat about  WICKET-6498? It
>>>>>
>>>> uses
>>
>>> javascript events that might not be supported buy browser?
>>>>>
>>>>> On Sun, Feb 11, 2018 at 6:16 PM, Korbinian Bachl <
>>>>> korbinian.bachl@whiskyworld.de> wrote:
>>>>>
>>>>> +1 to release for M9
>>>>>>
>>>>>> IMHO a warning should be added with regards to WICKET-6498 as it is
>>>>>>
>>>>> not
>>>
>>>> yet working in a reliable way but may break depending on client
>>>>>>
>>>>> specifics;
>>>>
>>>>> ----- Ursprüngliche Mail -----
>>>>>>
>>>>>>> Von: "Andrea Del Bene" <an...@gmail.com>
>>>>>>> An: dev@wicket.apache.org
>>>>>>> Gesendet: Sonntag, 11. Februar 2018 17:34:08
>>>>>>> Betreff: [VOTE] Release Apache Wicket 8.0.0-M9
>>>>>>> This is a vote to release Apache Wicket 8.0.0-M9
>>>>>>>
>>>>>>> Please download the source distributions found in our staging area
>>>>>>> linked below.
>>>>>>>
>>>>>>> I have included the signatures for both the source archives. This
>>>>>>>
>>>>>> vote
>>>
>>>> lasts for 72 hours minimum.
>>>>>>>
>>>>>>> [ ] Yes, release Apache Wicket 8.0.0-M9
>>>>>>> [ ] No, don't release Apache Wicket 8.0.0-M9, because ...
>>>>>>>
>>>>>>> Distributions, changelog, keys and signatures can be found at:
>>>>>>>
>>>>>>>      https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9
>>>>>>>
>>>>>>> Staging repository:
>>>>>>>
>>>>>>> https://repository.apache.org/content/repositories/
>>>>>>>
>>>>>> orgapachewicket-1105/
>>>>
>>>>> The binaries are available in the above link, as are a staging
>>>>>>> repository for Maven. Typically the vote is on the source, but
>>>>>>>
>>>>>> should
>>>
>>>> you find a problem with one of the binaries, please let me know, I
>>>>>>>
>>>>>> can
>>>
>>>> re-roll them some way or the other.
>>>>>>>
>>>>>>> Staging git repository data:
>>>>>>>
>>>>>>>      Repository:  git@github.com:bitstorm/wicket.git
>>>>>>>      Branch:      build/wicket-8.0.0-M9
>>>>>>>      Release tag: rel/wicket-8.0.0-M9
>>>>>>>
>>>>>>>
>>>>>>> ============================================================
>>>>>>>
>>>>>> ============
>>>>
>>>>>      The signatures for the source release artefacts:
>>>>>>>
>>>>>>>
>>>>>>> Signature for apache-wicket-8.0.0-M9.zip:
>>>>>>>
>>>>>>>      -----BEGIN PGP SIGNATURE-----
>>>>>>> Version: GnuPG v1
>>>>>>>
>>>>>>> iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
>>>>>>> Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
>>>>>>> rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
>>>>>>> YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
>>>>>>> Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
>>>>>>> EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
>>>>>>> Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
>>>>>>> E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
>>>>>>> TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
>>>>>>> Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
>>>>>>> K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
>>>>>>> jIvOQJKU+bwlubLLneTg
>>>>>>> =MOtP
>>>>>>> -----END PGP SIGNATURE-----
>>>>>>>
>>>>>>> Signature for apache-wicket-8.0.0-M9.tar.gz:
>>>>>>>
>>>>>>>      -----BEGIN PGP SIGNATURE-----
>>>>>>> Version: GnuPG v1
>>>>>>>
>>>>>>> iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
>>>>>>> b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
>>>>>>> oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
>>>>>>> nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
>>>>>>> B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
>>>>>>> hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
>>>>>>> aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
>>>>>>> sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
>>>>>>> YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
>>>>>>> GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
>>>>>>> 3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
>>>>>>> CCJOHO3iofZ0wlGnB5J7
>>>>>>> =/qPh
>>>>>>> -----END PGP SIGNATURE-----
>>>>>>>
>>>>>>> ============================================================
>>>>>>>
>>>>>> ============
>>>>
>>>>>      CHANGELOG for 8.0.0-M9:
>>>>>>>
>>>>>>> ** Bug
>>>>>>>
>>>>>>>      * [WICKET-6332] - NullPointerException in
>>>>>>>
>>>>>> PageParameters#equals()
>>>
>>>>      * [WICKET-6441] - MockHttpSession and MockSessionStore don't
>>>>>>>
>>>>>> call
>>>
>>>> onInvalidate() on invalidate()
>>>>>>>      * [WICKET-6448] - Provide behavior that disables a button after
>>>>>>>
>>>>>> click
>>>>
>>>>>      * [WICKET-6477] - Component.getDefaultModelObject() wraps in
>>>>>>> RuntimeException instead of WicketRuntimeException
>>>>>>>      * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
>>>>>>>      * [WICKET-6489] - Exception when "identifier|code" javascript
>>>>>>>
>>>>>> is
>>
>>> not start on PrependJavaScript
>>>>>>>      * [WICKET-6491] - AjaxDownload is not working in blob mode for
>>>>>>> Microsoft browsers
>>>>>>>      * [WICKET-6492] - javascript files are not minified in
>>>>>>>
>>>>>> deployment
>>>
>>>> mode and not united
>>>>>>>      * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession
>>>>>>>
>>>>>> one
>>>
>>>> used instead of Websocket one) + NPE if no HttpSession is found
>>>>>>>
>>>>>> during
>>>
>>>> Handshake Request
>>>>>>>      * [WICKET-6496] - Duplicate definition of interface JSONString
>>>>>>>      * [WICKET-6501] - DefaultPageManagerProvider does not honour
>>>>>>> StoreSettings.setAsynchronous(false)
>>>>>>>      * [WICKET-6506] - Performance issue when large component isn't
>>>>>>>
>>>>>> visible
>>>>>>
>>>>>>>      * [WICKET-6512] - pageId is being reset during
>>>>>>> Session::replaceSession() call
>>>>>>>      * [WICKET-6513] - NullPointerException at
>>>>>>> PageStoreManager$SessionEntry after login
>>>>>>>      * [WICKET-6518] - Memory leaks on quickstart restart in tomcat
>>>>>>>      * [WICKET-6522] - ThreadLocal leak in PageStoreManager
>>>>>>>      * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same
>>>>>>>
>>>>>> component
>>>
>>>> timeId conflict
>>>>>>>      * [WICKET-6524] - Do not require bean validation 2.0.0
>>>>>>>      * [WICKET-6529] - Feedback from onSubmit not rendered on
>>>>>>>
>>>>>> stateless
>>>
>>>> pages
>>>>>>>      * [WICKET-6530] - Race-condition in session invalidation
>>>>>>>
>>>>>>> ** New Feature
>>>>>>>
>>>>>>>      * [WICKET-6497] - unify javascript files
>>>>>>>      * [WICKET-6498] - wicket 8 - js to asnyc and or defer
>>>>>>>
>>>>>>> ** Improvement
>>>>>>>
>>>>>>>      * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking
>>>>>>> lazy load
>>>>>>>      * [WICKET-6284] - Introduce lambda-enhanced factory method in
>>>>>>> ResourceReference
>>>>>>>      * [WICKET-6499] - Support for Bean Validation 2.0
>>>>>>>      * [WICKET-6503] - Ajax refresh and feedback panel
>>>>>>>      * [WICKET-6504] - Use a serializable model for
>>>>>>>
>>>>>> FileSystemResource's
>>>>
>>>>> path
>>>>>>>      * [WICKET-6509] - Import junit packages as optional
>>>>>>>      * [WICKET-6514] - FeedbackCollector(Component) should not
>>>>>>>
>>>>>> collect
>>>
>>>> session-scoped feedback messages
>>>>>>>      * [WICKET-6517] - use Ajax for multipart instead of iframe
>>>>>>>
>>>>>>> ** Task
>>>>>>>
>>>>>>>      * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent()
>>>>>>>
>>>>>> before
>>>
>>>> Wicket 8.0.0
>>>>>>>
>>>>>>
>

Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Sven Meier <sv...@meiers.net>.
Hi all,

there's no need to make a fuss about this feature.

When Korbinian and I started working on deferred JavaScript, I was under 
the impression:

a) that the JavaScript part is sorted out already
b) every framework supports it (to be kind of cool)
b) we have to rework major parts to bake this into Wicket

Now I understand that

x) deferred loading of JavaSript is fucked up in browsers
y) other frameworks are struggling with this too
z) only a tiny change was required in Wicket to allow people to 
experiment with deferred JavaScript

We *need* a note in the release notes for z), as the handling of 
IHeaderResponseDecorator has slightly. I don't consider this a big deal, 
because users will have to change a *single* place only *if* they use 
JavaScriptFilteredIntoFooterHeaderResponse at all.
Compare that with introducing Optional for the return of 
RequestTarget#find(): that might *silently* break applications and 
requires to rework possibly *hundreds* of code places.

Furthermore WICKET- 6498 added a single class 
JavaScriptDeferHeaderResponse only - yes, it's experimental but with no 
API surface to break in the future. Nobody has to use it so I don't see 
the need to praise/warn about it in the release notes.
I don't consider it broken, browsers are broken. However I have no 
problem to remove that class: we can just put it into confluence or 
wicketstuff.

Once again: It is a *single* class with *no* API - that's nothing 
compared to component queueing :P

Have fun
Sven



Am 16.02.2018 um 13:32 schrieb Andrea Del Bene:
> On Feb 16, 2018 10:50 AM, "Martin Grigorov" <mg...@apache.org> wrote:
>
> On Fri, Feb 16, 2018 at 10:41 AM, Andrea Del Bene <an...@gmail.com>
> wrote:
>
>> That's what I'd write in the release note:
>>
>> Caveats
>> ------------------
>> WICKET-6498 might not work as expected due to a known issues with all
> major
>> browsers (Chrome, Firefox, IE > 10) which allows deferred scripts to be
>> executed before DOMContentLoaded is fired. For this reason WICKET-6498
>> should be avoided for production applications and used carefully.
>>
>> WDYT?
>>
> Why do we ship it if it is known to be broken ?
> AFAIR we don't have such precedent before.
>
>
> Have you forgotten about components queueing :-D :-D?
>
>
>
>> On Thu, Feb 15, 2018 at 9:15 PM, Korbinian Bachl <
>> korbinian.bachl@whiskyworld.de> wrote:
>>
>>> in short: since IE 11 and chrome as well as FF the browsers dont fire
> the
>>> DOMContentLoaded of scripts the way one would expect. This happens as
> the
>>> browsers branch multiple threads that each thread put together execution
>>> groups of orders leading to inline-JS getting executed and events on
>> these
>>> fired without the knowledge of other JS resources as long as these are
>>> defered and / or / asnyc'd
>>>
>>> Even worse, an app that may work well in local mode may break in
>>> production as network timing as well as client CPU count (influences
>>> thread) and speed of CPU and or GPU (yep... ) may change the timings the
>>> event DOMContentLoaded  gets fired;
>>>
>>> even JQuery guys are plagued by this and have no real solution to it now
>>> IMHO https://github.com/jquery/jquery/issues/3271
>>>
>>> I think we can get a real working one for wicket but had no time yet to
>>> try it out; Idea is to create the wicket object in the head at first
>> inline
>>> script before any JS resources (defered or not) so that the page itself
>>> cant break because of this
>>>
>>>
>>> ----- Ursprüngliche Mail -----
>>>> Von: "Andrea Del Bene" <an...@gmail.com>
>>>> An: dev@wicket.apache.org
>>>> Gesendet: Donnerstag, 15. Februar 2018 16:48:18
>>>> Betreff: Re: [VOTE] Release Apache Wicket 8.0.0-M9
>>>> Hi,
>>>>
>>>> I need your help. what's exactly the caveat about  WICKET-6498? It
> uses
>>>> javascript events that might not be supported buy browser?
>>>>
>>>> On Sun, Feb 11, 2018 at 6:16 PM, Korbinian Bachl <
>>>> korbinian.bachl@whiskyworld.de> wrote:
>>>>
>>>>> +1 to release for M9
>>>>>
>>>>> IMHO a warning should be added with regards to WICKET-6498 as it is
>> not
>>>>> yet working in a reliable way but may break depending on client
>>> specifics;
>>>>> ----- Ursprüngliche Mail -----
>>>>>> Von: "Andrea Del Bene" <an...@gmail.com>
>>>>>> An: dev@wicket.apache.org
>>>>>> Gesendet: Sonntag, 11. Februar 2018 17:34:08
>>>>>> Betreff: [VOTE] Release Apache Wicket 8.0.0-M9
>>>>>> This is a vote to release Apache Wicket 8.0.0-M9
>>>>>>
>>>>>> Please download the source distributions found in our staging area
>>>>>> linked below.
>>>>>>
>>>>>> I have included the signatures for both the source archives. This
>> vote
>>>>>> lasts for 72 hours minimum.
>>>>>>
>>>>>> [ ] Yes, release Apache Wicket 8.0.0-M9
>>>>>> [ ] No, don't release Apache Wicket 8.0.0-M9, because ...
>>>>>>
>>>>>> Distributions, changelog, keys and signatures can be found at:
>>>>>>
>>>>>>      https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9
>>>>>>
>>>>>> Staging repository:
>>>>>>
>>>>>> https://repository.apache.org/content/repositories/
>>> orgapachewicket-1105/
>>>>>> The binaries are available in the above link, as are a staging
>>>>>> repository for Maven. Typically the vote is on the source, but
>> should
>>>>>> you find a problem with one of the binaries, please let me know, I
>> can
>>>>>> re-roll them some way or the other.
>>>>>>
>>>>>> Staging git repository data:
>>>>>>
>>>>>>      Repository:  git@github.com:bitstorm/wicket.git
>>>>>>      Branch:      build/wicket-8.0.0-M9
>>>>>>      Release tag: rel/wicket-8.0.0-M9
>>>>>>
>>>>>>
>>>>>> ============================================================
>>> ============
>>>>>>      The signatures for the source release artefacts:
>>>>>>
>>>>>>
>>>>>> Signature for apache-wicket-8.0.0-M9.zip:
>>>>>>
>>>>>>      -----BEGIN PGP SIGNATURE-----
>>>>>> Version: GnuPG v1
>>>>>>
>>>>>> iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
>>>>>> Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
>>>>>> rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
>>>>>> YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
>>>>>> Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
>>>>>> EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
>>>>>> Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
>>>>>> E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
>>>>>> TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
>>>>>> Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
>>>>>> K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
>>>>>> jIvOQJKU+bwlubLLneTg
>>>>>> =MOtP
>>>>>> -----END PGP SIGNATURE-----
>>>>>>
>>>>>> Signature for apache-wicket-8.0.0-M9.tar.gz:
>>>>>>
>>>>>>      -----BEGIN PGP SIGNATURE-----
>>>>>> Version: GnuPG v1
>>>>>>
>>>>>> iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
>>>>>> b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
>>>>>> oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
>>>>>> nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
>>>>>> B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
>>>>>> hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
>>>>>> aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
>>>>>> sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
>>>>>> YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
>>>>>> GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
>>>>>> 3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
>>>>>> CCJOHO3iofZ0wlGnB5J7
>>>>>> =/qPh
>>>>>> -----END PGP SIGNATURE-----
>>>>>>
>>>>>> ============================================================
>>> ============
>>>>>>      CHANGELOG for 8.0.0-M9:
>>>>>>
>>>>>> ** Bug
>>>>>>
>>>>>>      * [WICKET-6332] - NullPointerException in
>> PageParameters#equals()
>>>>>>      * [WICKET-6441] - MockHttpSession and MockSessionStore don't
>> call
>>>>>> onInvalidate() on invalidate()
>>>>>>      * [WICKET-6448] - Provide behavior that disables a button after
>>> click
>>>>>>      * [WICKET-6477] - Component.getDefaultModelObject() wraps in
>>>>>> RuntimeException instead of WicketRuntimeException
>>>>>>      * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
>>>>>>      * [WICKET-6489] - Exception when "identifier|code" javascript
> is
>>>>>> not start on PrependJavaScript
>>>>>>      * [WICKET-6491] - AjaxDownload is not working in blob mode for
>>>>>> Microsoft browsers
>>>>>>      * [WICKET-6492] - javascript files are not minified in
>> deployment
>>>>>> mode and not united
>>>>>>      * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession
>> one
>>>>>> used instead of Websocket one) + NPE if no HttpSession is found
>> during
>>>>>> Handshake Request
>>>>>>      * [WICKET-6496] - Duplicate definition of interface JSONString
>>>>>>      * [WICKET-6501] - DefaultPageManagerProvider does not honour
>>>>>> StoreSettings.setAsynchronous(false)
>>>>>>      * [WICKET-6506] - Performance issue when large component isn't
>>>>> visible
>>>>>>      * [WICKET-6512] - pageId is being reset during
>>>>>> Session::replaceSession() call
>>>>>>      * [WICKET-6513] - NullPointerException at
>>>>>> PageStoreManager$SessionEntry after login
>>>>>>      * [WICKET-6518] - Memory leaks on quickstart restart in tomcat
>>>>>>      * [WICKET-6522] - ThreadLocal leak in PageStoreManager
>>>>>>      * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same
>> component
>>>>>> timeId conflict
>>>>>>      * [WICKET-6524] - Do not require bean validation 2.0.0
>>>>>>      * [WICKET-6529] - Feedback from onSubmit not rendered on
>> stateless
>>>>>> pages
>>>>>>      * [WICKET-6530] - Race-condition in session invalidation
>>>>>>
>>>>>> ** New Feature
>>>>>>
>>>>>>      * [WICKET-6497] - unify javascript files
>>>>>>      * [WICKET-6498] - wicket 8 - js to asnyc and or defer
>>>>>>
>>>>>> ** Improvement
>>>>>>
>>>>>>      * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking
>>>>>> lazy load
>>>>>>      * [WICKET-6284] - Introduce lambda-enhanced factory method in
>>>>>> ResourceReference
>>>>>>      * [WICKET-6499] - Support for Bean Validation 2.0
>>>>>>      * [WICKET-6503] - Ajax refresh and feedback panel
>>>>>>      * [WICKET-6504] - Use a serializable model for
>>> FileSystemResource's
>>>>>> path
>>>>>>      * [WICKET-6509] - Import junit packages as optional
>>>>>>      * [WICKET-6514] - FeedbackCollector(Component) should not
>> collect
>>>>>> session-scoped feedback messages
>>>>>>      * [WICKET-6517] - use Ajax for multipart instead of iframe
>>>>>>
>>>>>> ** Task
>>>>>>
>>>>>>      * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent()
>> before
>>>>>> Wicket 8.0.0


Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Andrea Del Bene <an...@gmail.com>.
On Feb 16, 2018 10:50 AM, "Martin Grigorov" <mg...@apache.org> wrote:

On Fri, Feb 16, 2018 at 10:41 AM, Andrea Del Bene <an...@gmail.com>
wrote:

> That's what I'd write in the release note:
>
> Caveats
> ------------------
> WICKET-6498 might not work as expected due to a known issues with all
major
> browsers (Chrome, Firefox, IE > 10) which allows deferred scripts to be
> executed before DOMContentLoaded is fired. For this reason WICKET-6498
> should be avoided for production applications and used carefully.
>
> WDYT?
>

Why do we ship it if it is known to be broken ?
AFAIR we don't have such precedent before.


Have you forgotten about components queueing :-D :-D?



>
> On Thu, Feb 15, 2018 at 9:15 PM, Korbinian Bachl <
> korbinian.bachl@whiskyworld.de> wrote:
>
> > in short: since IE 11 and chrome as well as FF the browsers dont fire
the
> > DOMContentLoaded of scripts the way one would expect. This happens as
the
> > browsers branch multiple threads that each thread put together execution
> > groups of orders leading to inline-JS getting executed and events on
> these
> > fired without the knowledge of other JS resources as long as these are
> > defered and / or / asnyc'd
> >
> > Even worse, an app that may work well in local mode may break in
> > production as network timing as well as client CPU count (influences
> > thread) and speed of CPU and or GPU (yep... ) may change the timings the
> > event DOMContentLoaded  gets fired;
> >
> > even JQuery guys are plagued by this and have no real solution to it now
> > IMHO https://github.com/jquery/jquery/issues/3271
> >
> > I think we can get a real working one for wicket but had no time yet to
> > try it out; Idea is to create the wicket object in the head at first
> inline
> > script before any JS resources (defered or not) so that the page itself
> > cant break because of this
> >
> >
> > ----- Ursprüngliche Mail -----
> > > Von: "Andrea Del Bene" <an...@gmail.com>
> > > An: dev@wicket.apache.org
> > > Gesendet: Donnerstag, 15. Februar 2018 16:48:18
> > > Betreff: Re: [VOTE] Release Apache Wicket 8.0.0-M9
> >
> > > Hi,
> > >
> > > I need your help. what's exactly the caveat about  WICKET-6498? It
uses
> > > javascript events that might not be supported buy browser?
> > >
> > > On Sun, Feb 11, 2018 at 6:16 PM, Korbinian Bachl <
> > > korbinian.bachl@whiskyworld.de> wrote:
> > >
> > >> +1 to release for M9
> > >>
> > >> IMHO a warning should be added with regards to WICKET-6498 as it is
> not
> > >> yet working in a reliable way but may break depending on client
> > specifics;
> > >>
> > >> ----- Ursprüngliche Mail -----
> > >> > Von: "Andrea Del Bene" <an...@gmail.com>
> > >> > An: dev@wicket.apache.org
> > >> > Gesendet: Sonntag, 11. Februar 2018 17:34:08
> > >> > Betreff: [VOTE] Release Apache Wicket 8.0.0-M9
> > >>
> > >> > This is a vote to release Apache Wicket 8.0.0-M9
> > >> >
> > >> > Please download the source distributions found in our staging area
> > >> > linked below.
> > >> >
> > >> > I have included the signatures for both the source archives. This
> vote
> > >> > lasts for 72 hours minimum.
> > >> >
> > >> > [ ] Yes, release Apache Wicket 8.0.0-M9
> > >> > [ ] No, don't release Apache Wicket 8.0.0-M9, because ...
> > >> >
> > >> > Distributions, changelog, keys and signatures can be found at:
> > >> >
> > >> >     https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9
> > >> >
> > >> > Staging repository:
> > >> >
> > >> > https://repository.apache.org/content/repositories/
> > orgapachewicket-1105/
> > >> >
> > >> > The binaries are available in the above link, as are a staging
> > >> > repository for Maven. Typically the vote is on the source, but
> should
> > >> > you find a problem with one of the binaries, please let me know, I
> can
> > >> > re-roll them some way or the other.
> > >> >
> > >> > Staging git repository data:
> > >> >
> > >> >     Repository:  git@github.com:bitstorm/wicket.git
> > >> >     Branch:      build/wicket-8.0.0-M9
> > >> >     Release tag: rel/wicket-8.0.0-M9
> > >> >
> > >> >
> > >> > ============================================================
> > ============
> > >> >
> > >> >     The signatures for the source release artefacts:
> > >> >
> > >> >
> > >> > Signature for apache-wicket-8.0.0-M9.zip:
> > >> >
> > >> >     -----BEGIN PGP SIGNATURE-----
> > >> > Version: GnuPG v1
> > >> >
> > >> > iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
> > >> > Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
> > >> > rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
> > >> > YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
> > >> > Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
> > >> > EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
> > >> > Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
> > >> > E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
> > >> > TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
> > >> > Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
> > >> > K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
> > >> > jIvOQJKU+bwlubLLneTg
> > >> > =MOtP
> > >> > -----END PGP SIGNATURE-----
> > >> >
> > >> > Signature for apache-wicket-8.0.0-M9.tar.gz:
> > >> >
> > >> >     -----BEGIN PGP SIGNATURE-----
> > >> > Version: GnuPG v1
> > >> >
> > >> > iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
> > >> > b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
> > >> > oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
> > >> > nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
> > >> > B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
> > >> > hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
> > >> > aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
> > >> > sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
> > >> > YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
> > >> > GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
> > >> > 3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
> > >> > CCJOHO3iofZ0wlGnB5J7
> > >> > =/qPh
> > >> > -----END PGP SIGNATURE-----
> > >> >
> > >> > ============================================================
> > ============
> > >> >
> > >> >     CHANGELOG for 8.0.0-M9:
> > >> >
> > >> > ** Bug
> > >> >
> > >> >     * [WICKET-6332] - NullPointerException in
> PageParameters#equals()
> > >> >     * [WICKET-6441] - MockHttpSession and MockSessionStore don't
> call
> > >> > onInvalidate() on invalidate()
> > >> >     * [WICKET-6448] - Provide behavior that disables a button after
> > click
> > >> >     * [WICKET-6477] - Component.getDefaultModelObject() wraps in
> > >> > RuntimeException instead of WicketRuntimeException
> > >> >     * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
> > >> >     * [WICKET-6489] - Exception when "identifier|code" javascript
is
> > >> > not start on PrependJavaScript
> > >> >     * [WICKET-6491] - AjaxDownload is not working in blob mode for
> > >> > Microsoft browsers
> > >> >     * [WICKET-6492] - javascript files are not minified in
> deployment
> > >> > mode and not united
> > >> >     * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession
> one
> > >> > used instead of Websocket one) + NPE if no HttpSession is found
> during
> > >> > Handshake Request
> > >> >     * [WICKET-6496] - Duplicate definition of interface JSONString
> > >> >     * [WICKET-6501] - DefaultPageManagerProvider does not honour
> > >> > StoreSettings.setAsynchronous(false)
> > >> >     * [WICKET-6506] - Performance issue when large component isn't
> > >> visible
> > >> >     * [WICKET-6512] - pageId is being reset during
> > >> > Session::replaceSession() call
> > >> >     * [WICKET-6513] - NullPointerException at
> > >> > PageStoreManager$SessionEntry after login
> > >> >     * [WICKET-6518] - Memory leaks on quickstart restart in tomcat
> > >> >     * [WICKET-6522] - ThreadLocal leak in PageStoreManager
> > >> >     * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same
> component
> > >> > timeId conflict
> > >> >     * [WICKET-6524] - Do not require bean validation 2.0.0
> > >> >     * [WICKET-6529] - Feedback from onSubmit not rendered on
> stateless
> > >> > pages
> > >> >     * [WICKET-6530] - Race-condition in session invalidation
> > >> >
> > >> > ** New Feature
> > >> >
> > >> >     * [WICKET-6497] - unify javascript files
> > >> >     * [WICKET-6498] - wicket 8 - js to asnyc and or defer
> > >> >
> > >> > ** Improvement
> > >> >
> > >> >     * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking
> > >> > lazy load
> > >> >     * [WICKET-6284] - Introduce lambda-enhanced factory method in
> > >> > ResourceReference
> > >> >     * [WICKET-6499] - Support for Bean Validation 2.0
> > >> >     * [WICKET-6503] - Ajax refresh and feedback panel
> > >> >     * [WICKET-6504] - Use a serializable model for
> > FileSystemResource's
> > >> > path
> > >> >     * [WICKET-6509] - Import junit packages as optional
> > >> >     * [WICKET-6514] - FeedbackCollector(Component) should not
> collect
> > >> > session-scoped feedback messages
> > >> >     * [WICKET-6517] - use Ajax for multipart instead of iframe
> > >> >
> > >> > ** Task
> > >> >
> > >> >     * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent()
> before
> > >> > Wicket 8.0.0
> >
>

Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Andrea Del Bene <an...@gmail.com>.
I think Martin might have a point. A solution could be moving this feature
(or part of it) into experimental module.


On Fri, Feb 16, 2018 at 11:06 AM, Tobias Soloschenko <
tobiassoloschenko@googlemail.com> wrote:

> Hi,
>
> as far as I understood this feature is optional and if you want to render
> the js defered you are able to do so, but also should be aware that this
> might cause issues under some circumstances.
>
> „... due to a known issues“ - either remove „a“ or the „s“ after issues.
>

Thank you!

>
> kind regards
>
> Tobias
>
> > Am 16.02.2018 um 10:49 schrieb Martin Grigorov <mg...@apache.org>:
> >
> > On Fri, Feb 16, 2018 at 10:41 AM, Andrea Del Bene <an...@gmail.com>
> > wrote:
> >
> >> That's what I'd write in the release note:
> >>
> >> Caveats
> >> ------------------
> >> WICKET-6498 might not work as expected due to a known issues with all
> major
> >> browsers (Chrome, Firefox, IE > 10) which allows deferred scripts to be
> >> executed before DOMContentLoaded is fired. For this reason WICKET-6498
> >> should be avoided for production applications and used carefully.
> >>
> >> WDYT?
> >>
> >
> > Why do we ship it if it is known to be broken ?
> > AFAIR we don't have such precedent before.
> >
> >
> >>
> >> On Thu, Feb 15, 2018 at 9:15 PM, Korbinian Bachl <
> >> korbinian.bachl@whiskyworld.de> wrote:
> >>
> >>> in short: since IE 11 and chrome as well as FF the browsers dont fire
> the
> >>> DOMContentLoaded of scripts the way one would expect. This happens as
> the
> >>> browsers branch multiple threads that each thread put together
> execution
> >>> groups of orders leading to inline-JS getting executed and events on
> >> these
> >>> fired without the knowledge of other JS resources as long as these are
> >>> defered and / or / asnyc'd
> >>>
> >>> Even worse, an app that may work well in local mode may break in
> >>> production as network timing as well as client CPU count (influences
> >>> thread) and speed of CPU and or GPU (yep... ) may change the timings
> the
> >>> event DOMContentLoaded  gets fired;
> >>>
> >>> even JQuery guys are plagued by this and have no real solution to it
> now
> >>> IMHO https://github.com/jquery/jquery/issues/3271
> >>>
> >>> I think we can get a real working one for wicket but had no time yet to
> >>> try it out; Idea is to create the wicket object in the head at first
> >> inline
> >>> script before any JS resources (defered or not) so that the page itself
> >>> cant break because of this
> >>>
> >>>
> >>> ----- Ursprüngliche Mail -----
> >>>> Von: "Andrea Del Bene" <an...@gmail.com>
> >>>> An: dev@wicket.apache.org
> >>>> Gesendet: Donnerstag, 15. Februar 2018 16:48:18
> >>>> Betreff: Re: [VOTE] Release Apache Wicket 8.0.0-M9
> >>>
> >>>> Hi,
> >>>>
> >>>> I need your help. what's exactly the caveat about  WICKET-6498? It
> uses
> >>>> javascript events that might not be supported buy browser?
> >>>>
> >>>> On Sun, Feb 11, 2018 at 6:16 PM, Korbinian Bachl <
> >>>> korbinian.bachl@whiskyworld.de> wrote:
> >>>>
> >>>>> +1 to release for M9
> >>>>>
> >>>>> IMHO a warning should be added with regards to WICKET-6498 as it is
> >> not
> >>>>> yet working in a reliable way but may break depending on client
> >>> specifics;
> >>>>>
> >>>>> ----- Ursprüngliche Mail -----
> >>>>>> Von: "Andrea Del Bene" <an...@gmail.com>
> >>>>>> An: dev@wicket.apache.org
> >>>>>> Gesendet: Sonntag, 11. Februar 2018 17:34:08
> >>>>>> Betreff: [VOTE] Release Apache Wicket 8.0.0-M9
> >>>>>
> >>>>>> This is a vote to release Apache Wicket 8.0.0-M9
> >>>>>>
> >>>>>> Please download the source distributions found in our staging area
> >>>>>> linked below.
> >>>>>>
> >>>>>> I have included the signatures for both the source archives. This
> >> vote
> >>>>>> lasts for 72 hours minimum.
> >>>>>>
> >>>>>> [ ] Yes, release Apache Wicket 8.0.0-M9
> >>>>>> [ ] No, don't release Apache Wicket 8.0.0-M9, because ...
> >>>>>>
> >>>>>> Distributions, changelog, keys and signatures can be found at:
> >>>>>>
> >>>>>>    https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9
> >>>>>>
> >>>>>> Staging repository:
> >>>>>>
> >>>>>> https://repository.apache.org/content/repositories/
> >>> orgapachewicket-1105/
> >>>>>>
> >>>>>> The binaries are available in the above link, as are a staging
> >>>>>> repository for Maven. Typically the vote is on the source, but
> >> should
> >>>>>> you find a problem with one of the binaries, please let me know, I
> >> can
> >>>>>> re-roll them some way or the other.
> >>>>>>
> >>>>>> Staging git repository data:
> >>>>>>
> >>>>>>    Repository:  git@github.com:bitstorm/wicket.git
> >>>>>>    Branch:      build/wicket-8.0.0-M9
> >>>>>>    Release tag: rel/wicket-8.0.0-M9
> >>>>>>
> >>>>>>
> >>>>>> ============================================================
> >>> ============
> >>>>>>
> >>>>>>    The signatures for the source release artefacts:
> >>>>>>
> >>>>>>
> >>>>>> Signature for apache-wicket-8.0.0-M9.zip:
> >>>>>>
> >>>>>>    -----BEGIN PGP SIGNATURE-----
> >>>>>> Version: GnuPG v1
> >>>>>>
> >>>>>> iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
> >>>>>> Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
> >>>>>> rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
> >>>>>> YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
> >>>>>> Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
> >>>>>> EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
> >>>>>> Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
> >>>>>> E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
> >>>>>> TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
> >>>>>> Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
> >>>>>> K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
> >>>>>> jIvOQJKU+bwlubLLneTg
> >>>>>> =MOtP
> >>>>>> -----END PGP SIGNATURE-----
> >>>>>>
> >>>>>> Signature for apache-wicket-8.0.0-M9.tar.gz:
> >>>>>>
> >>>>>>    -----BEGIN PGP SIGNATURE-----
> >>>>>> Version: GnuPG v1
> >>>>>>
> >>>>>> iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
> >>>>>> b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
> >>>>>> oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
> >>>>>> nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
> >>>>>> B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
> >>>>>> hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
> >>>>>> aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
> >>>>>> sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
> >>>>>> YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
> >>>>>> GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
> >>>>>> 3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
> >>>>>> CCJOHO3iofZ0wlGnB5J7
> >>>>>> =/qPh
> >>>>>> -----END PGP SIGNATURE-----
> >>>>>>
> >>>>>> ============================================================
> >>> ============
> >>>>>>
> >>>>>>    CHANGELOG for 8.0.0-M9:
> >>>>>>
> >>>>>> ** Bug
> >>>>>>
> >>>>>>    * [WICKET-6332] - NullPointerException in
> >> PageParameters#equals()
> >>>>>>    * [WICKET-6441] - MockHttpSession and MockSessionStore don't
> >> call
> >>>>>> onInvalidate() on invalidate()
> >>>>>>    * [WICKET-6448] - Provide behavior that disables a button after
> >>> click
> >>>>>>    * [WICKET-6477] - Component.getDefaultModelObject() wraps in
> >>>>>> RuntimeException instead of WicketRuntimeException
> >>>>>>    * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
> >>>>>>    * [WICKET-6489] - Exception when "identifier|code" javascript is
> >>>>>> not start on PrependJavaScript
> >>>>>>    * [WICKET-6491] - AjaxDownload is not working in blob mode for
> >>>>>> Microsoft browsers
> >>>>>>    * [WICKET-6492] - javascript files are not minified in
> >> deployment
> >>>>>> mode and not united
> >>>>>>    * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession
> >> one
> >>>>>> used instead of Websocket one) + NPE if no HttpSession is found
> >> during
> >>>>>> Handshake Request
> >>>>>>    * [WICKET-6496] - Duplicate definition of interface JSONString
> >>>>>>    * [WICKET-6501] - DefaultPageManagerProvider does not honour
> >>>>>> StoreSettings.setAsynchronous(false)
> >>>>>>    * [WICKET-6506] - Performance issue when large component isn't
> >>>>> visible
> >>>>>>    * [WICKET-6512] - pageId is being reset during
> >>>>>> Session::replaceSession() call
> >>>>>>    * [WICKET-6513] - NullPointerException at
> >>>>>> PageStoreManager$SessionEntry after login
> >>>>>>    * [WICKET-6518] - Memory leaks on quickstart restart in tomcat
> >>>>>>    * [WICKET-6522] - ThreadLocal leak in PageStoreManager
> >>>>>>    * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same
> >> component
> >>>>>> timeId conflict
> >>>>>>    * [WICKET-6524] - Do not require bean validation 2.0.0
> >>>>>>    * [WICKET-6529] - Feedback from onSubmit not rendered on
> >> stateless
> >>>>>> pages
> >>>>>>    * [WICKET-6530] - Race-condition in session invalidation
> >>>>>>
> >>>>>> ** New Feature
> >>>>>>
> >>>>>>    * [WICKET-6497] - unify javascript files
> >>>>>>    * [WICKET-6498] - wicket 8 - js to asnyc and or defer
> >>>>>>
> >>>>>> ** Improvement
> >>>>>>
> >>>>>>    * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking
> >>>>>> lazy load
> >>>>>>    * [WICKET-6284] - Introduce lambda-enhanced factory method in
> >>>>>> ResourceReference
> >>>>>>    * [WICKET-6499] - Support for Bean Validation 2.0
> >>>>>>    * [WICKET-6503] - Ajax refresh and feedback panel
> >>>>>>    * [WICKET-6504] - Use a serializable model for
> >>> FileSystemResource's
> >>>>>> path
> >>>>>>    * [WICKET-6509] - Import junit packages as optional
> >>>>>>    * [WICKET-6514] - FeedbackCollector(Component) should not
> >> collect
> >>>>>> session-scoped feedback messages
> >>>>>>    * [WICKET-6517] - use Ajax for multipart instead of iframe
> >>>>>>
> >>>>>> ** Task
> >>>>>>
> >>>>>>    * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent()
> >> before
> >>>>>> Wicket 8.0.0
> >>>
> >>
>

Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Tobias Soloschenko <to...@googlemail.com>.
Hi,

as far as I understood this feature is optional and if you want to render the js defered you are able to do so, but also should be aware that this might cause issues under some circumstances.

„... due to a known issues“ - either remove „a“ or the „s“ after issues.

kind regards

Tobias

> Am 16.02.2018 um 10:49 schrieb Martin Grigorov <mg...@apache.org>:
> 
> On Fri, Feb 16, 2018 at 10:41 AM, Andrea Del Bene <an...@gmail.com>
> wrote:
> 
>> That's what I'd write in the release note:
>> 
>> Caveats
>> ------------------
>> WICKET-6498 might not work as expected due to a known issues with all major
>> browsers (Chrome, Firefox, IE > 10) which allows deferred scripts to be
>> executed before DOMContentLoaded is fired. For this reason WICKET-6498
>> should be avoided for production applications and used carefully.
>> 
>> WDYT?
>> 
> 
> Why do we ship it if it is known to be broken ?
> AFAIR we don't have such precedent before.
> 
> 
>> 
>> On Thu, Feb 15, 2018 at 9:15 PM, Korbinian Bachl <
>> korbinian.bachl@whiskyworld.de> wrote:
>> 
>>> in short: since IE 11 and chrome as well as FF the browsers dont fire the
>>> DOMContentLoaded of scripts the way one would expect. This happens as the
>>> browsers branch multiple threads that each thread put together execution
>>> groups of orders leading to inline-JS getting executed and events on
>> these
>>> fired without the knowledge of other JS resources as long as these are
>>> defered and / or / asnyc'd
>>> 
>>> Even worse, an app that may work well in local mode may break in
>>> production as network timing as well as client CPU count (influences
>>> thread) and speed of CPU and or GPU (yep... ) may change the timings the
>>> event DOMContentLoaded  gets fired;
>>> 
>>> even JQuery guys are plagued by this and have no real solution to it now
>>> IMHO https://github.com/jquery/jquery/issues/3271
>>> 
>>> I think we can get a real working one for wicket but had no time yet to
>>> try it out; Idea is to create the wicket object in the head at first
>> inline
>>> script before any JS resources (defered or not) so that the page itself
>>> cant break because of this
>>> 
>>> 
>>> ----- Ursprüngliche Mail -----
>>>> Von: "Andrea Del Bene" <an...@gmail.com>
>>>> An: dev@wicket.apache.org
>>>> Gesendet: Donnerstag, 15. Februar 2018 16:48:18
>>>> Betreff: Re: [VOTE] Release Apache Wicket 8.0.0-M9
>>> 
>>>> Hi,
>>>> 
>>>> I need your help. what's exactly the caveat about  WICKET-6498? It uses
>>>> javascript events that might not be supported buy browser?
>>>> 
>>>> On Sun, Feb 11, 2018 at 6:16 PM, Korbinian Bachl <
>>>> korbinian.bachl@whiskyworld.de> wrote:
>>>> 
>>>>> +1 to release for M9
>>>>> 
>>>>> IMHO a warning should be added with regards to WICKET-6498 as it is
>> not
>>>>> yet working in a reliable way but may break depending on client
>>> specifics;
>>>>> 
>>>>> ----- Ursprüngliche Mail -----
>>>>>> Von: "Andrea Del Bene" <an...@gmail.com>
>>>>>> An: dev@wicket.apache.org
>>>>>> Gesendet: Sonntag, 11. Februar 2018 17:34:08
>>>>>> Betreff: [VOTE] Release Apache Wicket 8.0.0-M9
>>>>> 
>>>>>> This is a vote to release Apache Wicket 8.0.0-M9
>>>>>> 
>>>>>> Please download the source distributions found in our staging area
>>>>>> linked below.
>>>>>> 
>>>>>> I have included the signatures for both the source archives. This
>> vote
>>>>>> lasts for 72 hours minimum.
>>>>>> 
>>>>>> [ ] Yes, release Apache Wicket 8.0.0-M9
>>>>>> [ ] No, don't release Apache Wicket 8.0.0-M9, because ...
>>>>>> 
>>>>>> Distributions, changelog, keys and signatures can be found at:
>>>>>> 
>>>>>>    https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9
>>>>>> 
>>>>>> Staging repository:
>>>>>> 
>>>>>> https://repository.apache.org/content/repositories/
>>> orgapachewicket-1105/
>>>>>> 
>>>>>> The binaries are available in the above link, as are a staging
>>>>>> repository for Maven. Typically the vote is on the source, but
>> should
>>>>>> you find a problem with one of the binaries, please let me know, I
>> can
>>>>>> re-roll them some way or the other.
>>>>>> 
>>>>>> Staging git repository data:
>>>>>> 
>>>>>>    Repository:  git@github.com:bitstorm/wicket.git
>>>>>>    Branch:      build/wicket-8.0.0-M9
>>>>>>    Release tag: rel/wicket-8.0.0-M9
>>>>>> 
>>>>>> 
>>>>>> ============================================================
>>> ============
>>>>>> 
>>>>>>    The signatures for the source release artefacts:
>>>>>> 
>>>>>> 
>>>>>> Signature for apache-wicket-8.0.0-M9.zip:
>>>>>> 
>>>>>>    -----BEGIN PGP SIGNATURE-----
>>>>>> Version: GnuPG v1
>>>>>> 
>>>>>> iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
>>>>>> Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
>>>>>> rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
>>>>>> YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
>>>>>> Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
>>>>>> EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
>>>>>> Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
>>>>>> E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
>>>>>> TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
>>>>>> Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
>>>>>> K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
>>>>>> jIvOQJKU+bwlubLLneTg
>>>>>> =MOtP
>>>>>> -----END PGP SIGNATURE-----
>>>>>> 
>>>>>> Signature for apache-wicket-8.0.0-M9.tar.gz:
>>>>>> 
>>>>>>    -----BEGIN PGP SIGNATURE-----
>>>>>> Version: GnuPG v1
>>>>>> 
>>>>>> iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
>>>>>> b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
>>>>>> oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
>>>>>> nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
>>>>>> B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
>>>>>> hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
>>>>>> aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
>>>>>> sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
>>>>>> YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
>>>>>> GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
>>>>>> 3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
>>>>>> CCJOHO3iofZ0wlGnB5J7
>>>>>> =/qPh
>>>>>> -----END PGP SIGNATURE-----
>>>>>> 
>>>>>> ============================================================
>>> ============
>>>>>> 
>>>>>>    CHANGELOG for 8.0.0-M9:
>>>>>> 
>>>>>> ** Bug
>>>>>> 
>>>>>>    * [WICKET-6332] - NullPointerException in
>> PageParameters#equals()
>>>>>>    * [WICKET-6441] - MockHttpSession and MockSessionStore don't
>> call
>>>>>> onInvalidate() on invalidate()
>>>>>>    * [WICKET-6448] - Provide behavior that disables a button after
>>> click
>>>>>>    * [WICKET-6477] - Component.getDefaultModelObject() wraps in
>>>>>> RuntimeException instead of WicketRuntimeException
>>>>>>    * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
>>>>>>    * [WICKET-6489] - Exception when "identifier|code" javascript is
>>>>>> not start on PrependJavaScript
>>>>>>    * [WICKET-6491] - AjaxDownload is not working in blob mode for
>>>>>> Microsoft browsers
>>>>>>    * [WICKET-6492] - javascript files are not minified in
>> deployment
>>>>>> mode and not united
>>>>>>    * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession
>> one
>>>>>> used instead of Websocket one) + NPE if no HttpSession is found
>> during
>>>>>> Handshake Request
>>>>>>    * [WICKET-6496] - Duplicate definition of interface JSONString
>>>>>>    * [WICKET-6501] - DefaultPageManagerProvider does not honour
>>>>>> StoreSettings.setAsynchronous(false)
>>>>>>    * [WICKET-6506] - Performance issue when large component isn't
>>>>> visible
>>>>>>    * [WICKET-6512] - pageId is being reset during
>>>>>> Session::replaceSession() call
>>>>>>    * [WICKET-6513] - NullPointerException at
>>>>>> PageStoreManager$SessionEntry after login
>>>>>>    * [WICKET-6518] - Memory leaks on quickstart restart in tomcat
>>>>>>    * [WICKET-6522] - ThreadLocal leak in PageStoreManager
>>>>>>    * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same
>> component
>>>>>> timeId conflict
>>>>>>    * [WICKET-6524] - Do not require bean validation 2.0.0
>>>>>>    * [WICKET-6529] - Feedback from onSubmit not rendered on
>> stateless
>>>>>> pages
>>>>>>    * [WICKET-6530] - Race-condition in session invalidation
>>>>>> 
>>>>>> ** New Feature
>>>>>> 
>>>>>>    * [WICKET-6497] - unify javascript files
>>>>>>    * [WICKET-6498] - wicket 8 - js to asnyc and or defer
>>>>>> 
>>>>>> ** Improvement
>>>>>> 
>>>>>>    * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking
>>>>>> lazy load
>>>>>>    * [WICKET-6284] - Introduce lambda-enhanced factory method in
>>>>>> ResourceReference
>>>>>>    * [WICKET-6499] - Support for Bean Validation 2.0
>>>>>>    * [WICKET-6503] - Ajax refresh and feedback panel
>>>>>>    * [WICKET-6504] - Use a serializable model for
>>> FileSystemResource's
>>>>>> path
>>>>>>    * [WICKET-6509] - Import junit packages as optional
>>>>>>    * [WICKET-6514] - FeedbackCollector(Component) should not
>> collect
>>>>>> session-scoped feedback messages
>>>>>>    * [WICKET-6517] - use Ajax for multipart instead of iframe
>>>>>> 
>>>>>> ** Task
>>>>>> 
>>>>>>    * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent()
>> before
>>>>>> Wicket 8.0.0
>>> 
>> 

Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Martin Grigorov <mg...@apache.org>.
On Fri, Feb 16, 2018 at 10:41 AM, Andrea Del Bene <an...@gmail.com>
wrote:

> That's what I'd write in the release note:
>
> Caveats
> ------------------
> WICKET-6498 might not work as expected due to a known issues with all major
> browsers (Chrome, Firefox, IE > 10) which allows deferred scripts to be
> executed before DOMContentLoaded is fired. For this reason WICKET-6498
> should be avoided for production applications and used carefully.
>
> WDYT?
>

Why do we ship it if it is known to be broken ?
AFAIR we don't have such precedent before.


>
> On Thu, Feb 15, 2018 at 9:15 PM, Korbinian Bachl <
> korbinian.bachl@whiskyworld.de> wrote:
>
> > in short: since IE 11 and chrome as well as FF the browsers dont fire the
> > DOMContentLoaded of scripts the way one would expect. This happens as the
> > browsers branch multiple threads that each thread put together execution
> > groups of orders leading to inline-JS getting executed and events on
> these
> > fired without the knowledge of other JS resources as long as these are
> > defered and / or / asnyc'd
> >
> > Even worse, an app that may work well in local mode may break in
> > production as network timing as well as client CPU count (influences
> > thread) and speed of CPU and or GPU (yep... ) may change the timings the
> > event DOMContentLoaded  gets fired;
> >
> > even JQuery guys are plagued by this and have no real solution to it now
> > IMHO https://github.com/jquery/jquery/issues/3271
> >
> > I think we can get a real working one for wicket but had no time yet to
> > try it out; Idea is to create the wicket object in the head at first
> inline
> > script before any JS resources (defered or not) so that the page itself
> > cant break because of this
> >
> >
> > ----- Ursprüngliche Mail -----
> > > Von: "Andrea Del Bene" <an...@gmail.com>
> > > An: dev@wicket.apache.org
> > > Gesendet: Donnerstag, 15. Februar 2018 16:48:18
> > > Betreff: Re: [VOTE] Release Apache Wicket 8.0.0-M9
> >
> > > Hi,
> > >
> > > I need your help. what's exactly the caveat about  WICKET-6498? It uses
> > > javascript events that might not be supported buy browser?
> > >
> > > On Sun, Feb 11, 2018 at 6:16 PM, Korbinian Bachl <
> > > korbinian.bachl@whiskyworld.de> wrote:
> > >
> > >> +1 to release for M9
> > >>
> > >> IMHO a warning should be added with regards to WICKET-6498 as it is
> not
> > >> yet working in a reliable way but may break depending on client
> > specifics;
> > >>
> > >> ----- Ursprüngliche Mail -----
> > >> > Von: "Andrea Del Bene" <an...@gmail.com>
> > >> > An: dev@wicket.apache.org
> > >> > Gesendet: Sonntag, 11. Februar 2018 17:34:08
> > >> > Betreff: [VOTE] Release Apache Wicket 8.0.0-M9
> > >>
> > >> > This is a vote to release Apache Wicket 8.0.0-M9
> > >> >
> > >> > Please download the source distributions found in our staging area
> > >> > linked below.
> > >> >
> > >> > I have included the signatures for both the source archives. This
> vote
> > >> > lasts for 72 hours minimum.
> > >> >
> > >> > [ ] Yes, release Apache Wicket 8.0.0-M9
> > >> > [ ] No, don't release Apache Wicket 8.0.0-M9, because ...
> > >> >
> > >> > Distributions, changelog, keys and signatures can be found at:
> > >> >
> > >> >     https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9
> > >> >
> > >> > Staging repository:
> > >> >
> > >> > https://repository.apache.org/content/repositories/
> > orgapachewicket-1105/
> > >> >
> > >> > The binaries are available in the above link, as are a staging
> > >> > repository for Maven. Typically the vote is on the source, but
> should
> > >> > you find a problem with one of the binaries, please let me know, I
> can
> > >> > re-roll them some way or the other.
> > >> >
> > >> > Staging git repository data:
> > >> >
> > >> >     Repository:  git@github.com:bitstorm/wicket.git
> > >> >     Branch:      build/wicket-8.0.0-M9
> > >> >     Release tag: rel/wicket-8.0.0-M9
> > >> >
> > >> >
> > >> > ============================================================
> > ============
> > >> >
> > >> >     The signatures for the source release artefacts:
> > >> >
> > >> >
> > >> > Signature for apache-wicket-8.0.0-M9.zip:
> > >> >
> > >> >     -----BEGIN PGP SIGNATURE-----
> > >> > Version: GnuPG v1
> > >> >
> > >> > iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
> > >> > Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
> > >> > rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
> > >> > YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
> > >> > Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
> > >> > EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
> > >> > Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
> > >> > E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
> > >> > TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
> > >> > Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
> > >> > K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
> > >> > jIvOQJKU+bwlubLLneTg
> > >> > =MOtP
> > >> > -----END PGP SIGNATURE-----
> > >> >
> > >> > Signature for apache-wicket-8.0.0-M9.tar.gz:
> > >> >
> > >> >     -----BEGIN PGP SIGNATURE-----
> > >> > Version: GnuPG v1
> > >> >
> > >> > iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
> > >> > b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
> > >> > oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
> > >> > nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
> > >> > B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
> > >> > hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
> > >> > aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
> > >> > sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
> > >> > YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
> > >> > GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
> > >> > 3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
> > >> > CCJOHO3iofZ0wlGnB5J7
> > >> > =/qPh
> > >> > -----END PGP SIGNATURE-----
> > >> >
> > >> > ============================================================
> > ============
> > >> >
> > >> >     CHANGELOG for 8.0.0-M9:
> > >> >
> > >> > ** Bug
> > >> >
> > >> >     * [WICKET-6332] - NullPointerException in
> PageParameters#equals()
> > >> >     * [WICKET-6441] - MockHttpSession and MockSessionStore don't
> call
> > >> > onInvalidate() on invalidate()
> > >> >     * [WICKET-6448] - Provide behavior that disables a button after
> > click
> > >> >     * [WICKET-6477] - Component.getDefaultModelObject() wraps in
> > >> > RuntimeException instead of WicketRuntimeException
> > >> >     * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
> > >> >     * [WICKET-6489] - Exception when "identifier|code" javascript is
> > >> > not start on PrependJavaScript
> > >> >     * [WICKET-6491] - AjaxDownload is not working in blob mode for
> > >> > Microsoft browsers
> > >> >     * [WICKET-6492] - javascript files are not minified in
> deployment
> > >> > mode and not united
> > >> >     * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession
> one
> > >> > used instead of Websocket one) + NPE if no HttpSession is found
> during
> > >> > Handshake Request
> > >> >     * [WICKET-6496] - Duplicate definition of interface JSONString
> > >> >     * [WICKET-6501] - DefaultPageManagerProvider does not honour
> > >> > StoreSettings.setAsynchronous(false)
> > >> >     * [WICKET-6506] - Performance issue when large component isn't
> > >> visible
> > >> >     * [WICKET-6512] - pageId is being reset during
> > >> > Session::replaceSession() call
> > >> >     * [WICKET-6513] - NullPointerException at
> > >> > PageStoreManager$SessionEntry after login
> > >> >     * [WICKET-6518] - Memory leaks on quickstart restart in tomcat
> > >> >     * [WICKET-6522] - ThreadLocal leak in PageStoreManager
> > >> >     * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same
> component
> > >> > timeId conflict
> > >> >     * [WICKET-6524] - Do not require bean validation 2.0.0
> > >> >     * [WICKET-6529] - Feedback from onSubmit not rendered on
> stateless
> > >> > pages
> > >> >     * [WICKET-6530] - Race-condition in session invalidation
> > >> >
> > >> > ** New Feature
> > >> >
> > >> >     * [WICKET-6497] - unify javascript files
> > >> >     * [WICKET-6498] - wicket 8 - js to asnyc and or defer
> > >> >
> > >> > ** Improvement
> > >> >
> > >> >     * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking
> > >> > lazy load
> > >> >     * [WICKET-6284] - Introduce lambda-enhanced factory method in
> > >> > ResourceReference
> > >> >     * [WICKET-6499] - Support for Bean Validation 2.0
> > >> >     * [WICKET-6503] - Ajax refresh and feedback panel
> > >> >     * [WICKET-6504] - Use a serializable model for
> > FileSystemResource's
> > >> > path
> > >> >     * [WICKET-6509] - Import junit packages as optional
> > >> >     * [WICKET-6514] - FeedbackCollector(Component) should not
> collect
> > >> > session-scoped feedback messages
> > >> >     * [WICKET-6517] - use Ajax for multipart instead of iframe
> > >> >
> > >> > ** Task
> > >> >
> > >> >     * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent()
> before
> > >> > Wicket 8.0.0
> >
>

Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Andrea Del Bene <an...@gmail.com>.
That's what I'd write in the release note:

Caveats
------------------
WICKET-6498 might not work as expected due to a known issues with all major
browsers (Chrome, Firefox, IE > 10) which allows deferred scripts to be
executed before DOMContentLoaded is fired. For this reason WICKET-6498
should be avoided for production applications and used carefully.

WDYT?

On Thu, Feb 15, 2018 at 9:15 PM, Korbinian Bachl <
korbinian.bachl@whiskyworld.de> wrote:

> in short: since IE 11 and chrome as well as FF the browsers dont fire the
> DOMContentLoaded of scripts the way one would expect. This happens as the
> browsers branch multiple threads that each thread put together execution
> groups of orders leading to inline-JS getting executed and events on these
> fired without the knowledge of other JS resources as long as these are
> defered and / or / asnyc'd
>
> Even worse, an app that may work well in local mode may break in
> production as network timing as well as client CPU count (influences
> thread) and speed of CPU and or GPU (yep... ) may change the timings the
> event DOMContentLoaded  gets fired;
>
> even JQuery guys are plagued by this and have no real solution to it now
> IMHO https://github.com/jquery/jquery/issues/3271
>
> I think we can get a real working one for wicket but had no time yet to
> try it out; Idea is to create the wicket object in the head at first inline
> script before any JS resources (defered or not) so that the page itself
> cant break because of this
>
>
> ----- Ursprüngliche Mail -----
> > Von: "Andrea Del Bene" <an...@gmail.com>
> > An: dev@wicket.apache.org
> > Gesendet: Donnerstag, 15. Februar 2018 16:48:18
> > Betreff: Re: [VOTE] Release Apache Wicket 8.0.0-M9
>
> > Hi,
> >
> > I need your help. what's exactly the caveat about  WICKET-6498? It uses
> > javascript events that might not be supported buy browser?
> >
> > On Sun, Feb 11, 2018 at 6:16 PM, Korbinian Bachl <
> > korbinian.bachl@whiskyworld.de> wrote:
> >
> >> +1 to release for M9
> >>
> >> IMHO a warning should be added with regards to WICKET-6498 as it is not
> >> yet working in a reliable way but may break depending on client
> specifics;
> >>
> >> ----- Ursprüngliche Mail -----
> >> > Von: "Andrea Del Bene" <an...@gmail.com>
> >> > An: dev@wicket.apache.org
> >> > Gesendet: Sonntag, 11. Februar 2018 17:34:08
> >> > Betreff: [VOTE] Release Apache Wicket 8.0.0-M9
> >>
> >> > This is a vote to release Apache Wicket 8.0.0-M9
> >> >
> >> > Please download the source distributions found in our staging area
> >> > linked below.
> >> >
> >> > I have included the signatures for both the source archives. This vote
> >> > lasts for 72 hours minimum.
> >> >
> >> > [ ] Yes, release Apache Wicket 8.0.0-M9
> >> > [ ] No, don't release Apache Wicket 8.0.0-M9, because ...
> >> >
> >> > Distributions, changelog, keys and signatures can be found at:
> >> >
> >> >     https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9
> >> >
> >> > Staging repository:
> >> >
> >> > https://repository.apache.org/content/repositories/
> orgapachewicket-1105/
> >> >
> >> > The binaries are available in the above link, as are a staging
> >> > repository for Maven. Typically the vote is on the source, but should
> >> > you find a problem with one of the binaries, please let me know, I can
> >> > re-roll them some way or the other.
> >> >
> >> > Staging git repository data:
> >> >
> >> >     Repository:  git@github.com:bitstorm/wicket.git
> >> >     Branch:      build/wicket-8.0.0-M9
> >> >     Release tag: rel/wicket-8.0.0-M9
> >> >
> >> >
> >> > ============================================================
> ============
> >> >
> >> >     The signatures for the source release artefacts:
> >> >
> >> >
> >> > Signature for apache-wicket-8.0.0-M9.zip:
> >> >
> >> >     -----BEGIN PGP SIGNATURE-----
> >> > Version: GnuPG v1
> >> >
> >> > iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
> >> > Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
> >> > rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
> >> > YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
> >> > Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
> >> > EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
> >> > Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
> >> > E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
> >> > TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
> >> > Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
> >> > K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
> >> > jIvOQJKU+bwlubLLneTg
> >> > =MOtP
> >> > -----END PGP SIGNATURE-----
> >> >
> >> > Signature for apache-wicket-8.0.0-M9.tar.gz:
> >> >
> >> >     -----BEGIN PGP SIGNATURE-----
> >> > Version: GnuPG v1
> >> >
> >> > iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
> >> > b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
> >> > oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
> >> > nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
> >> > B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
> >> > hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
> >> > aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
> >> > sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
> >> > YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
> >> > GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
> >> > 3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
> >> > CCJOHO3iofZ0wlGnB5J7
> >> > =/qPh
> >> > -----END PGP SIGNATURE-----
> >> >
> >> > ============================================================
> ============
> >> >
> >> >     CHANGELOG for 8.0.0-M9:
> >> >
> >> > ** Bug
> >> >
> >> >     * [WICKET-6332] - NullPointerException in PageParameters#equals()
> >> >     * [WICKET-6441] - MockHttpSession and MockSessionStore don't call
> >> > onInvalidate() on invalidate()
> >> >     * [WICKET-6448] - Provide behavior that disables a button after
> click
> >> >     * [WICKET-6477] - Component.getDefaultModelObject() wraps in
> >> > RuntimeException instead of WicketRuntimeException
> >> >     * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
> >> >     * [WICKET-6489] - Exception when "identifier|code" javascript is
> >> > not start on PrependJavaScript
> >> >     * [WICKET-6491] - AjaxDownload is not working in blob mode for
> >> > Microsoft browsers
> >> >     * [WICKET-6492] - javascript files are not minified in deployment
> >> > mode and not united
> >> >     * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession one
> >> > used instead of Websocket one) + NPE if no HttpSession is found during
> >> > Handshake Request
> >> >     * [WICKET-6496] - Duplicate definition of interface JSONString
> >> >     * [WICKET-6501] - DefaultPageManagerProvider does not honour
> >> > StoreSettings.setAsynchronous(false)
> >> >     * [WICKET-6506] - Performance issue when large component isn't
> >> visible
> >> >     * [WICKET-6512] - pageId is being reset during
> >> > Session::replaceSession() call
> >> >     * [WICKET-6513] - NullPointerException at
> >> > PageStoreManager$SessionEntry after login
> >> >     * [WICKET-6518] - Memory leaks on quickstart restart in tomcat
> >> >     * [WICKET-6522] - ThreadLocal leak in PageStoreManager
> >> >     * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same component
> >> > timeId conflict
> >> >     * [WICKET-6524] - Do not require bean validation 2.0.0
> >> >     * [WICKET-6529] - Feedback from onSubmit not rendered on stateless
> >> > pages
> >> >     * [WICKET-6530] - Race-condition in session invalidation
> >> >
> >> > ** New Feature
> >> >
> >> >     * [WICKET-6497] - unify javascript files
> >> >     * [WICKET-6498] - wicket 8 - js to asnyc and or defer
> >> >
> >> > ** Improvement
> >> >
> >> >     * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking
> >> > lazy load
> >> >     * [WICKET-6284] - Introduce lambda-enhanced factory method in
> >> > ResourceReference
> >> >     * [WICKET-6499] - Support for Bean Validation 2.0
> >> >     * [WICKET-6503] - Ajax refresh and feedback panel
> >> >     * [WICKET-6504] - Use a serializable model for
> FileSystemResource's
> >> > path
> >> >     * [WICKET-6509] - Import junit packages as optional
> >> >     * [WICKET-6514] - FeedbackCollector(Component) should not collect
> >> > session-scoped feedback messages
> >> >     * [WICKET-6517] - use Ajax for multipart instead of iframe
> >> >
> >> > ** Task
> >> >
> >> >     * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent() before
> >> > Wicket 8.0.0
>

Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Korbinian Bachl <ko...@whiskyworld.de>.
in short: since IE 11 and chrome as well as FF the browsers dont fire the DOMContentLoaded of scripts the way one would expect. This happens as the browsers branch multiple threads that each thread put together execution groups of orders leading to inline-JS getting executed and events on these fired without the knowledge of other JS resources as long as these are defered and / or / asnyc'd

Even worse, an app that may work well in local mode may break in production as network timing as well as client CPU count (influences thread) and speed of CPU and or GPU (yep... ) may change the timings the event DOMContentLoaded  gets fired;

even JQuery guys are plagued by this and have no real solution to it now IMHO https://github.com/jquery/jquery/issues/3271

I think we can get a real working one for wicket but had no time yet to try it out; Idea is to create the wicket object in the head at first inline script before any JS resources (defered or not) so that the page itself cant break because of this


----- Ursprüngliche Mail -----
> Von: "Andrea Del Bene" <an...@gmail.com>
> An: dev@wicket.apache.org
> Gesendet: Donnerstag, 15. Februar 2018 16:48:18
> Betreff: Re: [VOTE] Release Apache Wicket 8.0.0-M9

> Hi,
> 
> I need your help. what's exactly the caveat about  WICKET-6498? It uses
> javascript events that might not be supported buy browser?
> 
> On Sun, Feb 11, 2018 at 6:16 PM, Korbinian Bachl <
> korbinian.bachl@whiskyworld.de> wrote:
> 
>> +1 to release for M9
>>
>> IMHO a warning should be added with regards to WICKET-6498 as it is not
>> yet working in a reliable way but may break depending on client specifics;
>>
>> ----- Ursprüngliche Mail -----
>> > Von: "Andrea Del Bene" <an...@gmail.com>
>> > An: dev@wicket.apache.org
>> > Gesendet: Sonntag, 11. Februar 2018 17:34:08
>> > Betreff: [VOTE] Release Apache Wicket 8.0.0-M9
>>
>> > This is a vote to release Apache Wicket 8.0.0-M9
>> >
>> > Please download the source distributions found in our staging area
>> > linked below.
>> >
>> > I have included the signatures for both the source archives. This vote
>> > lasts for 72 hours minimum.
>> >
>> > [ ] Yes, release Apache Wicket 8.0.0-M9
>> > [ ] No, don't release Apache Wicket 8.0.0-M9, because ...
>> >
>> > Distributions, changelog, keys and signatures can be found at:
>> >
>> >     https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9
>> >
>> > Staging repository:
>> >
>> > https://repository.apache.org/content/repositories/orgapachewicket-1105/
>> >
>> > The binaries are available in the above link, as are a staging
>> > repository for Maven. Typically the vote is on the source, but should
>> > you find a problem with one of the binaries, please let me know, I can
>> > re-roll them some way or the other.
>> >
>> > Staging git repository data:
>> >
>> >     Repository:  git@github.com:bitstorm/wicket.git
>> >     Branch:      build/wicket-8.0.0-M9
>> >     Release tag: rel/wicket-8.0.0-M9
>> >
>> >
>> > ========================================================================
>> >
>> >     The signatures for the source release artefacts:
>> >
>> >
>> > Signature for apache-wicket-8.0.0-M9.zip:
>> >
>> >     -----BEGIN PGP SIGNATURE-----
>> > Version: GnuPG v1
>> >
>> > iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
>> > Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
>> > rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
>> > YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
>> > Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
>> > EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
>> > Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
>> > E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
>> > TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
>> > Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
>> > K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
>> > jIvOQJKU+bwlubLLneTg
>> > =MOtP
>> > -----END PGP SIGNATURE-----
>> >
>> > Signature for apache-wicket-8.0.0-M9.tar.gz:
>> >
>> >     -----BEGIN PGP SIGNATURE-----
>> > Version: GnuPG v1
>> >
>> > iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
>> > b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
>> > oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
>> > nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
>> > B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
>> > hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
>> > aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
>> > sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
>> > YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
>> > GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
>> > 3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
>> > CCJOHO3iofZ0wlGnB5J7
>> > =/qPh
>> > -----END PGP SIGNATURE-----
>> >
>> > ========================================================================
>> >
>> >     CHANGELOG for 8.0.0-M9:
>> >
>> > ** Bug
>> >
>> >     * [WICKET-6332] - NullPointerException in PageParameters#equals()
>> >     * [WICKET-6441] - MockHttpSession and MockSessionStore don't call
>> > onInvalidate() on invalidate()
>> >     * [WICKET-6448] - Provide behavior that disables a button after click
>> >     * [WICKET-6477] - Component.getDefaultModelObject() wraps in
>> > RuntimeException instead of WicketRuntimeException
>> >     * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
>> >     * [WICKET-6489] - Exception when "identifier|code" javascript is
>> > not start on PrependJavaScript
>> >     * [WICKET-6491] - AjaxDownload is not working in blob mode for
>> > Microsoft browsers
>> >     * [WICKET-6492] - javascript files are not minified in deployment
>> > mode and not united
>> >     * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession one
>> > used instead of Websocket one) + NPE if no HttpSession is found during
>> > Handshake Request
>> >     * [WICKET-6496] - Duplicate definition of interface JSONString
>> >     * [WICKET-6501] - DefaultPageManagerProvider does not honour
>> > StoreSettings.setAsynchronous(false)
>> >     * [WICKET-6506] - Performance issue when large component isn't
>> visible
>> >     * [WICKET-6512] - pageId is being reset during
>> > Session::replaceSession() call
>> >     * [WICKET-6513] - NullPointerException at
>> > PageStoreManager$SessionEntry after login
>> >     * [WICKET-6518] - Memory leaks on quickstart restart in tomcat
>> >     * [WICKET-6522] - ThreadLocal leak in PageStoreManager
>> >     * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same component
>> > timeId conflict
>> >     * [WICKET-6524] - Do not require bean validation 2.0.0
>> >     * [WICKET-6529] - Feedback from onSubmit not rendered on stateless
>> > pages
>> >     * [WICKET-6530] - Race-condition in session invalidation
>> >
>> > ** New Feature
>> >
>> >     * [WICKET-6497] - unify javascript files
>> >     * [WICKET-6498] - wicket 8 - js to asnyc and or defer
>> >
>> > ** Improvement
>> >
>> >     * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking
>> > lazy load
>> >     * [WICKET-6284] - Introduce lambda-enhanced factory method in
>> > ResourceReference
>> >     * [WICKET-6499] - Support for Bean Validation 2.0
>> >     * [WICKET-6503] - Ajax refresh and feedback panel
>> >     * [WICKET-6504] - Use a serializable model for FileSystemResource's
>> > path
>> >     * [WICKET-6509] - Import junit packages as optional
>> >     * [WICKET-6514] - FeedbackCollector(Component) should not collect
>> > session-scoped feedback messages
>> >     * [WICKET-6517] - use Ajax for multipart instead of iframe
>> >
>> > ** Task
>> >
>> >     * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent() before
>> > Wicket 8.0.0

Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Andrea Del Bene <an...@gmail.com>.
Hi,

I need your help. what's exactly the caveat about  WICKET-6498? It uses
javascript events that might not be supported buy browser?

On Sun, Feb 11, 2018 at 6:16 PM, Korbinian Bachl <
korbinian.bachl@whiskyworld.de> wrote:

> +1 to release for M9
>
> IMHO a warning should be added with regards to WICKET-6498 as it is not
> yet working in a reliable way but may break depending on client specifics;
>
> ----- Ursprüngliche Mail -----
> > Von: "Andrea Del Bene" <an...@gmail.com>
> > An: dev@wicket.apache.org
> > Gesendet: Sonntag, 11. Februar 2018 17:34:08
> > Betreff: [VOTE] Release Apache Wicket 8.0.0-M9
>
> > This is a vote to release Apache Wicket 8.0.0-M9
> >
> > Please download the source distributions found in our staging area
> > linked below.
> >
> > I have included the signatures for both the source archives. This vote
> > lasts for 72 hours minimum.
> >
> > [ ] Yes, release Apache Wicket 8.0.0-M9
> > [ ] No, don't release Apache Wicket 8.0.0-M9, because ...
> >
> > Distributions, changelog, keys and signatures can be found at:
> >
> >     https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9
> >
> > Staging repository:
> >
> > https://repository.apache.org/content/repositories/orgapachewicket-1105/
> >
> > The binaries are available in the above link, as are a staging
> > repository for Maven. Typically the vote is on the source, but should
> > you find a problem with one of the binaries, please let me know, I can
> > re-roll them some way or the other.
> >
> > Staging git repository data:
> >
> >     Repository:  git@github.com:bitstorm/wicket.git
> >     Branch:      build/wicket-8.0.0-M9
> >     Release tag: rel/wicket-8.0.0-M9
> >
> >
> > ========================================================================
> >
> >     The signatures for the source release artefacts:
> >
> >
> > Signature for apache-wicket-8.0.0-M9.zip:
> >
> >     -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1
> >
> > iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
> > Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
> > rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
> > YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
> > Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
> > EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
> > Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
> > E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
> > TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
> > Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
> > K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
> > jIvOQJKU+bwlubLLneTg
> > =MOtP
> > -----END PGP SIGNATURE-----
> >
> > Signature for apache-wicket-8.0.0-M9.tar.gz:
> >
> >     -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1
> >
> > iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
> > b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
> > oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
> > nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
> > B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
> > hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
> > aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
> > sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
> > YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
> > GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
> > 3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
> > CCJOHO3iofZ0wlGnB5J7
> > =/qPh
> > -----END PGP SIGNATURE-----
> >
> > ========================================================================
> >
> >     CHANGELOG for 8.0.0-M9:
> >
> > ** Bug
> >
> >     * [WICKET-6332] - NullPointerException in PageParameters#equals()
> >     * [WICKET-6441] - MockHttpSession and MockSessionStore don't call
> > onInvalidate() on invalidate()
> >     * [WICKET-6448] - Provide behavior that disables a button after click
> >     * [WICKET-6477] - Component.getDefaultModelObject() wraps in
> > RuntimeException instead of WicketRuntimeException
> >     * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
> >     * [WICKET-6489] - Exception when "identifier|code" javascript is
> > not start on PrependJavaScript
> >     * [WICKET-6491] - AjaxDownload is not working in blob mode for
> > Microsoft browsers
> >     * [WICKET-6492] - javascript files are not minified in deployment
> > mode and not united
> >     * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession one
> > used instead of Websocket one) + NPE if no HttpSession is found during
> > Handshake Request
> >     * [WICKET-6496] - Duplicate definition of interface JSONString
> >     * [WICKET-6501] - DefaultPageManagerProvider does not honour
> > StoreSettings.setAsynchronous(false)
> >     * [WICKET-6506] - Performance issue when large component isn't
> visible
> >     * [WICKET-6512] - pageId is being reset during
> > Session::replaceSession() call
> >     * [WICKET-6513] - NullPointerException at
> > PageStoreManager$SessionEntry after login
> >     * [WICKET-6518] - Memory leaks on quickstart restart in tomcat
> >     * [WICKET-6522] - ThreadLocal leak in PageStoreManager
> >     * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same component
> > timeId conflict
> >     * [WICKET-6524] - Do not require bean validation 2.0.0
> >     * [WICKET-6529] - Feedback from onSubmit not rendered on stateless
> > pages
> >     * [WICKET-6530] - Race-condition in session invalidation
> >
> > ** New Feature
> >
> >     * [WICKET-6497] - unify javascript files
> >     * [WICKET-6498] - wicket 8 - js to asnyc and or defer
> >
> > ** Improvement
> >
> >     * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking
> > lazy load
> >     * [WICKET-6284] - Introduce lambda-enhanced factory method in
> > ResourceReference
> >     * [WICKET-6499] - Support for Bean Validation 2.0
> >     * [WICKET-6503] - Ajax refresh and feedback panel
> >     * [WICKET-6504] - Use a serializable model for FileSystemResource's
> > path
> >     * [WICKET-6509] - Import junit packages as optional
> >     * [WICKET-6514] - FeedbackCollector(Component) should not collect
> > session-scoped feedback messages
> >     * [WICKET-6517] - use Ajax for multipart instead of iframe
> >
> > ** Task
> >
> >     * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent() before
> > Wicket 8.0.0
>

Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Andrea Del Bene <an...@gmail.com>.
+1

Tested:
1) signatures
2) my main app

On Mon, Feb 12, 2018 at 3:17 PM, Maxim Solodovnik <so...@gmail.com>
wrote:

> +1
>
> Tested:
> 1) signatures
> 2) build from sources
> 3) our main app
>
>
> I would slightly modify build script
> Right now I'm getting
>
> sha256sum -c apache-wicket-8.0.0-M9.tar.gz.sha256
> sha256sum: target/dist/apache-wicket-8.0.0-M9.tar.gz: No such file or
> directory
> target/dist/apache-wicket-8.0.0-M9.tar.gz: FAILED open or read
> sha256sum: WARNING: 1 listed file could not be read
>
>
>
I will add a 'pushd target/dist' to avoid the relative path inside digest.

Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Maxim Solodovnik <so...@gmail.com>.
+1

Tested:
1) signatures
2) build from sources
3) our main app


I would slightly modify build script
Right now I'm getting

sha256sum -c apache-wicket-8.0.0-M9.tar.gz.sha256
sha256sum: target/dist/apache-wicket-8.0.0-M9.tar.gz: No such file or
directory
target/dist/apache-wicket-8.0.0-M9.tar.gz: FAILED open or read
sha256sum: WARNING: 1 listed file could not be read




On Mon, Feb 12, 2018 at 3:47 PM, Korbinian Bachl <
korbinian.bachl@whiskyworld.de> wrote:

> thanks a lot Sven!
>
> ----- Ursprüngliche Mail -----
> > Von: "Sven Meier" <sv...@meiers.net>
> > An: dev@wicket.apache.org
> > Gesendet: Sonntag, 11. Februar 2018 21:24:53
> > Betreff: Re: [VOTE] Release Apache Wicket 8.0.0-M9
>
> > Hi,
> >
> > JavaScriptDeferHeaderResponse is an *alternative* to
> > JavaScriptFilteredIntoFooterHeaderResponse, it doesn't break anything -
> > but even if you wanted to, you could use both simultaneously.
> >
> > Regarding WICKET-6498's experimental status - I've added the following
> > to the JavaDoc:
> >
> >  * Note: This solution depends on the execution order of JavaScript in
> > the browser:
> >  * The 'DOMContentLoaded' event has to be fired <me>after</em> all
> > deferred JavaScript
> >  * resources have been loaded. This doesn't seem to be the case in all
> > browsers, thus
> >  * this class should be considered experimental.
> >
> > IMHO this is warning enough.
> >
> > Sven
> >
> >
> > Am 11.02.2018 um 20:03 schrieb Andrea Del Bene:
> >> Good point. We should also underline that WICKET-6498 breaks custom
> >> response decoration that might be used to place JavaScript inside body
> >> tag.
> >>
> >>
> >> On 11/02/2018 18:16, Korbinian Bachl wrote:
> >>> +1 to release for M9
> >>>
> >>> IMHO a warning should be added with regards to WICKET-6498 as it is
> >>> not yet working in a reliable way but may break depending on client
> >>> specifics;
> >>>
> >>> ----- Ursprüngliche Mail -----
> >>>> Von: "Andrea Del Bene" <an...@gmail.com>
> >>>> An: dev@wicket.apache.org
> >>>> Gesendet: Sonntag, 11. Februar 2018 17:34:08
> >>>> Betreff: [VOTE] Release Apache Wicket 8.0.0-M9
> >>>> This is a vote to release Apache Wicket 8.0.0-M9
> >>>>
> >>>> Please download the source distributions found in our staging area
> >>>> linked below.
> >>>>
> >>>> I have included the signatures for both the source archives. This vote
> >>>> lasts for 72 hours minimum.
> >>>>
> >>>> [ ] Yes, release Apache Wicket 8.0.0-M9
> >>>> [ ] No, don't release Apache Wicket 8.0.0-M9, because ...
> >>>>
> >>>> Distributions, changelog, keys and signatures can be found at:
> >>>>
> >>>>      https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9
> >>>>
> >>>> Staging repository:
> >>>>
> >>>> https://repository.apache.org/content/repositories/
> orgapachewicket-1105/
> >>>>
> >>>>
> >>>> The binaries are available in the above link, as are a staging
> >>>> repository for Maven. Typically the vote is on the source, but should
> >>>> you find a problem with one of the binaries, please let me know, I can
> >>>> re-roll them some way or the other.
> >>>>
> >>>> Staging git repository data:
> >>>>
> >>>>      Repository:  git@github.com:bitstorm/wicket.git
> >>>>      Branch:      build/wicket-8.0.0-M9
> >>>>      Release tag: rel/wicket-8.0.0-M9
> >>>>
> >>>>
> >>>> ============================================================
> ============
> >>>>
> >>>>
> >>>>      The signatures for the source release artefacts:
> >>>>
> >>>>
> >>>> Signature for apache-wicket-8.0.0-M9.zip:
> >>>>
> >>>>      -----BEGIN PGP SIGNATURE-----
> >>>> Version: GnuPG v1
> >>>>
> >>>> iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
> >>>> Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
> >>>> rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
> >>>> YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
> >>>> Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
> >>>> EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
> >>>> Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
> >>>> E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
> >>>> TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
> >>>> Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
> >>>> K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
> >>>> jIvOQJKU+bwlubLLneTg
> >>>> =MOtP
> >>>> -----END PGP SIGNATURE-----
> >>>>
> >>>> Signature for apache-wicket-8.0.0-M9.tar.gz:
> >>>>
> >>>>      -----BEGIN PGP SIGNATURE-----
> >>>> Version: GnuPG v1
> >>>>
> >>>> iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
> >>>> b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
> >>>> oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
> >>>> nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
> >>>> B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
> >>>> hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
> >>>> aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
> >>>> sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
> >>>> YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
> >>>> GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
> >>>> 3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
> >>>> CCJOHO3iofZ0wlGnB5J7
> >>>> =/qPh
> >>>> -----END PGP SIGNATURE-----
> >>>>
> >>>> ============================================================
> ============
> >>>>
> >>>>
> >>>>      CHANGELOG for 8.0.0-M9:
> >>>>
> >>>> ** Bug
> >>>>
> >>>>      * [WICKET-6332] - NullPointerException in PageParameters#equals()
> >>>>      * [WICKET-6441] - MockHttpSession and MockSessionStore don't call
> >>>> onInvalidate() on invalidate()
> >>>>      * [WICKET-6448] - Provide behavior that disables a button after
> >>>> click
> >>>>      * [WICKET-6477] - Component.getDefaultModelObject() wraps in
> >>>> RuntimeException instead of WicketRuntimeException
> >>>>      * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
> >>>>      * [WICKET-6489] - Exception when "identifier|code" javascript is
> >>>> not start on PrependJavaScript
> >>>>      * [WICKET-6491] - AjaxDownload is not working in blob mode for
> >>>> Microsoft browsers
> >>>>      * [WICKET-6492] - javascript files are not minified in deployment
> >>>> mode and not united
> >>>>      * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession one
> >>>> used instead of Websocket one) + NPE if no HttpSession is found during
> >>>> Handshake Request
> >>>>      * [WICKET-6496] - Duplicate definition of interface JSONString
> >>>>      * [WICKET-6501] - DefaultPageManagerProvider does not honour
> >>>> StoreSettings.setAsynchronous(false)
> >>>>      * [WICKET-6506] - Performance issue when large component isn't
> >>>> visible
> >>>>      * [WICKET-6512] - pageId is being reset during
> >>>> Session::replaceSession() call
> >>>>      * [WICKET-6513] - NullPointerException at
> >>>> PageStoreManager$SessionEntry after login
> >>>>      * [WICKET-6518] - Memory leaks on quickstart restart in tomcat
> >>>>      * [WICKET-6522] - ThreadLocal leak in PageStoreManager
> >>>>      * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same
> component
> >>>> timeId conflict
> >>>>      * [WICKET-6524] - Do not require bean validation 2.0.0
> >>>>      * [WICKET-6529] - Feedback from onSubmit not rendered on
> stateless
> >>>> pages
> >>>>      * [WICKET-6530] - Race-condition in session invalidation
> >>>>
> >>>> ** New Feature
> >>>>
> >>>>      * [WICKET-6497] - unify javascript files
> >>>>      * [WICKET-6498] - wicket 8 - js to asnyc and or defer
> >>>>
> >>>> ** Improvement
> >>>>
> >>>>      * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking
> >>>> lazy load
> >>>>      * [WICKET-6284] - Introduce lambda-enhanced factory method in
> >>>> ResourceReference
> >>>>      * [WICKET-6499] - Support for Bean Validation 2.0
> >>>>      * [WICKET-6503] - Ajax refresh and feedback panel
> >>>>      * [WICKET-6504] - Use a serializable model for
> >>>> FileSystemResource's
> >>>> path
> >>>>      * [WICKET-6509] - Import junit packages as optional
> >>>>      * [WICKET-6514] - FeedbackCollector(Component) should not collect
> >>>> session-scoped feedback messages
> >>>>      * [WICKET-6517] - use Ajax for multipart instead of iframe
> >>>>
> >>>> ** Task
> >>>>
> >>>>      * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent() before
> >>>> Wicket 8.0.0
>



-- 
WBR
Maxim aka solomax

Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Korbinian Bachl <ko...@whiskyworld.de>.
thanks a lot Sven!

----- Ursprüngliche Mail -----
> Von: "Sven Meier" <sv...@meiers.net>
> An: dev@wicket.apache.org
> Gesendet: Sonntag, 11. Februar 2018 21:24:53
> Betreff: Re: [VOTE] Release Apache Wicket 8.0.0-M9

> Hi,
> 
> JavaScriptDeferHeaderResponse is an *alternative* to
> JavaScriptFilteredIntoFooterHeaderResponse, it doesn't break anything -
> but even if you wanted to, you could use both simultaneously.
> 
> Regarding WICKET-6498's experimental status - I've added the following
> to the JavaDoc:
> 
>  * Note: This solution depends on the execution order of JavaScript in
> the browser:
>  * The 'DOMContentLoaded' event has to be fired <me>after</em> all
> deferred JavaScript
>  * resources have been loaded. This doesn't seem to be the case in all
> browsers, thus
>  * this class should be considered experimental.
> 
> IMHO this is warning enough.
> 
> Sven
> 
> 
> Am 11.02.2018 um 20:03 schrieb Andrea Del Bene:
>> Good point. We should also underline that WICKET-6498 breaks custom
>> response decoration that might be used to place JavaScript inside body
>> tag.
>>
>>
>> On 11/02/2018 18:16, Korbinian Bachl wrote:
>>> +1 to release for M9
>>>
>>> IMHO a warning should be added with regards to WICKET-6498 as it is
>>> not yet working in a reliable way but may break depending on client
>>> specifics;
>>>
>>> ----- Ursprüngliche Mail -----
>>>> Von: "Andrea Del Bene" <an...@gmail.com>
>>>> An: dev@wicket.apache.org
>>>> Gesendet: Sonntag, 11. Februar 2018 17:34:08
>>>> Betreff: [VOTE] Release Apache Wicket 8.0.0-M9
>>>> This is a vote to release Apache Wicket 8.0.0-M9
>>>>
>>>> Please download the source distributions found in our staging area
>>>> linked below.
>>>>
>>>> I have included the signatures for both the source archives. This vote
>>>> lasts for 72 hours minimum.
>>>>
>>>> [ ] Yes, release Apache Wicket 8.0.0-M9
>>>> [ ] No, don't release Apache Wicket 8.0.0-M9, because ...
>>>>
>>>> Distributions, changelog, keys and signatures can be found at:
>>>>
>>>>      https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9
>>>>
>>>> Staging repository:
>>>>
>>>> https://repository.apache.org/content/repositories/orgapachewicket-1105/
>>>>
>>>>
>>>> The binaries are available in the above link, as are a staging
>>>> repository for Maven. Typically the vote is on the source, but should
>>>> you find a problem with one of the binaries, please let me know, I can
>>>> re-roll them some way or the other.
>>>>
>>>> Staging git repository data:
>>>>
>>>>      Repository:  git@github.com:bitstorm/wicket.git
>>>>      Branch:      build/wicket-8.0.0-M9
>>>>      Release tag: rel/wicket-8.0.0-M9
>>>>
>>>>
>>>> ========================================================================
>>>>
>>>>
>>>>      The signatures for the source release artefacts:
>>>>
>>>>
>>>> Signature for apache-wicket-8.0.0-M9.zip:
>>>>
>>>>      -----BEGIN PGP SIGNATURE-----
>>>> Version: GnuPG v1
>>>>
>>>> iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
>>>> Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
>>>> rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
>>>> YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
>>>> Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
>>>> EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
>>>> Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
>>>> E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
>>>> TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
>>>> Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
>>>> K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
>>>> jIvOQJKU+bwlubLLneTg
>>>> =MOtP
>>>> -----END PGP SIGNATURE-----
>>>>
>>>> Signature for apache-wicket-8.0.0-M9.tar.gz:
>>>>
>>>>      -----BEGIN PGP SIGNATURE-----
>>>> Version: GnuPG v1
>>>>
>>>> iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
>>>> b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
>>>> oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
>>>> nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
>>>> B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
>>>> hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
>>>> aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
>>>> sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
>>>> YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
>>>> GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
>>>> 3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
>>>> CCJOHO3iofZ0wlGnB5J7
>>>> =/qPh
>>>> -----END PGP SIGNATURE-----
>>>>
>>>> ========================================================================
>>>>
>>>>
>>>>      CHANGELOG for 8.0.0-M9:
>>>>
>>>> ** Bug
>>>>
>>>>      * [WICKET-6332] - NullPointerException in PageParameters#equals()
>>>>      * [WICKET-6441] - MockHttpSession and MockSessionStore don't call
>>>> onInvalidate() on invalidate()
>>>>      * [WICKET-6448] - Provide behavior that disables a button after
>>>> click
>>>>      * [WICKET-6477] - Component.getDefaultModelObject() wraps in
>>>> RuntimeException instead of WicketRuntimeException
>>>>      * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
>>>>      * [WICKET-6489] - Exception when "identifier|code" javascript is
>>>> not start on PrependJavaScript
>>>>      * [WICKET-6491] - AjaxDownload is not working in blob mode for
>>>> Microsoft browsers
>>>>      * [WICKET-6492] - javascript files are not minified in deployment
>>>> mode and not united
>>>>      * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession one
>>>> used instead of Websocket one) + NPE if no HttpSession is found during
>>>> Handshake Request
>>>>      * [WICKET-6496] - Duplicate definition of interface JSONString
>>>>      * [WICKET-6501] - DefaultPageManagerProvider does not honour
>>>> StoreSettings.setAsynchronous(false)
>>>>      * [WICKET-6506] - Performance issue when large component isn't
>>>> visible
>>>>      * [WICKET-6512] - pageId is being reset during
>>>> Session::replaceSession() call
>>>>      * [WICKET-6513] - NullPointerException at
>>>> PageStoreManager$SessionEntry after login
>>>>      * [WICKET-6518] - Memory leaks on quickstart restart in tomcat
>>>>      * [WICKET-6522] - ThreadLocal leak in PageStoreManager
>>>>      * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same component
>>>> timeId conflict
>>>>      * [WICKET-6524] - Do not require bean validation 2.0.0
>>>>      * [WICKET-6529] - Feedback from onSubmit not rendered on stateless
>>>> pages
>>>>      * [WICKET-6530] - Race-condition in session invalidation
>>>>
>>>> ** New Feature
>>>>
>>>>      * [WICKET-6497] - unify javascript files
>>>>      * [WICKET-6498] - wicket 8 - js to asnyc and or defer
>>>>
>>>> ** Improvement
>>>>
>>>>      * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking
>>>> lazy load
>>>>      * [WICKET-6284] - Introduce lambda-enhanced factory method in
>>>> ResourceReference
>>>>      * [WICKET-6499] - Support for Bean Validation 2.0
>>>>      * [WICKET-6503] - Ajax refresh and feedback panel
>>>>      * [WICKET-6504] - Use a serializable model for
>>>> FileSystemResource's
>>>> path
>>>>      * [WICKET-6509] - Import junit packages as optional
>>>>      * [WICKET-6514] - FeedbackCollector(Component) should not collect
>>>> session-scoped feedback messages
>>>>      * [WICKET-6517] - use Ajax for multipart instead of iframe
>>>>
>>>> ** Task
>>>>
>>>>      * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent() before
>>>> Wicket 8.0.0

Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Sven Meier <sv...@meiers.net>.
Hi Andrea,

that's a good idea. WICKET-6189 is another contender for mentioning in the release notes.

Sven

⁣Gesendet mit Blue ​

Am 12. Feb. 2018, 12:50, um 12:50, Andrea Del Bene <an...@gmail.com> schrieb:
>Sorry, when I said "change log" I actually meant the release note.
>
>On Mon, Feb 12, 2018 at 12:48 PM, Andrea Del Bene
><an...@gmail.com>
>wrote:
>
>> Hi,
>>
>> On Mon, Feb 12, 2018 at 12:38 PM, Sven Meier <sv...@meiers.net> wrote:
>>
>>> Hi Andrea,
>>>
>>> read here:
>>>
>>> https://cwiki.apache.org/confluence/display/WICKET/Migration
>>> +to+Wicket+8.0#MigrationtoWicket8.0-Application'sIHeaderResp
>>> onseDecoratorASFJIRAkey,summary,type,created,updated,due,
>>> assignee,reporter,priority,status,resolution5aa69414-a9e9
>>> -3523-82ec-879b028fb15bWICKET-6498
>>>
>>> ... the decorator has to make sure it uses a ResourceAggretator too:
>>>
>>>         @Override
>>>         public IHeaderResponse decorate(IHeaderResponse response) {
>>>             return new ResourceAggregator(new
>>> JavaScriptFilteredIntoFooterHeaderResponse(response, bucketName));
>>>         }
>>>
>>> Have fun
>>> Sven
>>>
>>>
>>
>> That's ok, it's easy to adapt existing code to use
>ResourceAggretator. But
>> if we don't do this our application silently fails to render all the
>header
>> items. I think this might be a a little confusing for users if we
>don't
>> explicitly say in the change log that they have to pay attention to
>this
>> particular change.
>>
>>

Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Andrea Del Bene <an...@gmail.com>.
Sorry, when I said "change log" I actually meant the release note.

On Mon, Feb 12, 2018 at 12:48 PM, Andrea Del Bene <an...@gmail.com>
wrote:

> Hi,
>
> On Mon, Feb 12, 2018 at 12:38 PM, Sven Meier <sv...@meiers.net> wrote:
>
>> Hi Andrea,
>>
>> read here:
>>
>> https://cwiki.apache.org/confluence/display/WICKET/Migration
>> +to+Wicket+8.0#MigrationtoWicket8.0-Application'sIHeaderResp
>> onseDecoratorASFJIRAkey,summary,type,created,updated,due,
>> assignee,reporter,priority,status,resolution5aa69414-a9e9
>> -3523-82ec-879b028fb15bWICKET-6498
>>
>> ... the decorator has to make sure it uses a ResourceAggretator too:
>>
>>         @Override
>>         public IHeaderResponse decorate(IHeaderResponse response) {
>>             return new ResourceAggregator(new
>> JavaScriptFilteredIntoFooterHeaderResponse(response, bucketName));
>>         }
>>
>> Have fun
>> Sven
>>
>>
>
> That's ok, it's easy to adapt existing code to use ResourceAggretator. But
> if we don't do this our application silently fails to render all the header
> items. I think this might be a a little confusing for users if we don't
> explicitly say in the change log that they have to pay attention to this
> particular change.
>
>

Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Andrea Del Bene <an...@gmail.com>.
Hi,

On Mon, Feb 12, 2018 at 12:38 PM, Sven Meier <sv...@meiers.net> wrote:

> Hi Andrea,
>
> read here:
>
> https://cwiki.apache.org/confluence/display/WICKET/Migration
> +to+Wicket+8.0#MigrationtoWicket8.0-Application'sIHeaderResp
> onseDecoratorASFJIRAkey,summary,type,created,updated,
> due,assignee,reporter,priority,status,resolution5aa69414-a9e9-3523-82ec-
> 879b028fb15bWICKET-6498
>
> ... the decorator has to make sure it uses a ResourceAggretator too:
>
>         @Override
>         public IHeaderResponse decorate(IHeaderResponse response) {
>             return new ResourceAggregator(new
> JavaScriptFilteredIntoFooterHeaderResponse(response, bucketName));
>         }
>
> Have fun
> Sven
>
>

That's ok, it's easy to adapt existing code to use ResourceAggretator. But
if we don't do this our application silently fails to render all the header
items. I think this might be a a little confusing for users if we don't
explicitly say in the change log that they have to pay attention to this
particular change.

Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Sven Meier <sv...@meiers.net>.
Hi Andrea,

read here:

https://cwiki.apache.org/confluence/display/WICKET/Migration+to+Wicket+8.0#MigrationtoWicket8.0-Application'sIHeaderResponseDecoratorASFJIRAkey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution5aa69414-a9e9-3523-82ec-879b028fb15bWICKET-6498

... the decorator has to make sure it uses a ResourceAggretator too:

         @Override
         public IHeaderResponse decorate(IHeaderResponse response) {
             return new ResourceAggregator(new 
JavaScriptFilteredIntoFooterHeaderResponse(response, bucketName));
         }

Have fun
Sven


Am 12.02.2018 um 11:24 schrieb Andrea Del Bene:
> Hi Sven,
>
> what I noticed with my application and with one of the tutorial examples is
> that with the current solutions based on
> JavaScriptFilteredIntoFooterHeaderResponse
> some header item are "swallowed" without being rendered. Missing items
> usually are Wicket internal javascript files like wicket-event-jquery.js.
> I'm attaching a quickstart project to WICKET-6498 so you can investigate
> the behavior.
>
> On Sun, Feb 11, 2018 at 9:24 PM, Sven Meier <sv...@meiers.net> wrote:
>
>> Hi,
>>
>> JavaScriptDeferHeaderResponse is an *alternative* to
>> JavaScriptFilteredIntoFooterHeaderResponse, it doesn't break anything -
>> but even if you wanted to, you could use both simultaneously.
>>
>> Regarding WICKET-6498's experimental status - I've added the following to
>> the JavaDoc:
>>
>>   * Note: This solution depends on the execution order of JavaScript in the
>> browser:
>>   * The 'DOMContentLoaded' event has to be fired <me>after</em> all
>> deferred JavaScript
>>   * resources have been loaded. This doesn't seem to be the case in all
>> browsers, thus
>>   * this class should be considered experimental.
>>
>> IMHO this is warning enough.
>>
>> Sven
>>
>>
>>
>> Am 11.02.2018 um 20:03 schrieb Andrea Del Bene:
>>
>>> Good point. We should also underline that WICKET-6498 breaks custom
>>> response decoration that might be used to place JavaScript inside body tag.
>>>
>>>
>>> On 11/02/2018 18:16, Korbinian Bachl wrote:
>>>
>>>> +1 to release for M9
>>>>
>>>> IMHO a warning should be added with regards to WICKET-6498 as it is not
>>>> yet working in a reliable way but may break depending on client specifics;
>>>>
>>>> ----- Ursprüngliche Mail -----
>>>>
>>>>> Von: "Andrea Del Bene" <an...@gmail.com>
>>>>> An: dev@wicket.apache.org
>>>>> Gesendet: Sonntag, 11. Februar 2018 17:34:08
>>>>> Betreff: [VOTE] Release Apache Wicket 8.0.0-M9
>>>>> This is a vote to release Apache Wicket 8.0.0-M9
>>>>>
>>>>> Please download the source distributions found in our staging area
>>>>> linked below.
>>>>>
>>>>> I have included the signatures for both the source archives. This vote
>>>>> lasts for 72 hours minimum.
>>>>>
>>>>> [ ] Yes, release Apache Wicket 8.0.0-M9
>>>>> [ ] No, don't release Apache Wicket 8.0.0-M9, because ...
>>>>>
>>>>> Distributions, changelog, keys and signatures can be found at:
>>>>>
>>>>>       https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9
>>>>>
>>>>> Staging repository:
>>>>>
>>>>> https://repository.apache.org/content/repositories/orgapache
>>>>> wicket-1105/
>>>>>
>>>>> The binaries are available in the above link, as are a staging
>>>>> repository for Maven. Typically the vote is on the source, but should
>>>>> you find a problem with one of the binaries, please let me know, I can
>>>>> re-roll them some way or the other.
>>>>>
>>>>> Staging git repository data:
>>>>>
>>>>>       Repository:  git@github.com:bitstorm/wicket.git
>>>>>       Branch:      build/wicket-8.0.0-M9
>>>>>       Release tag: rel/wicket-8.0.0-M9
>>>>>
>>>>>
>>>>> ========================================================================
>>>>>
>>>>>
>>>>>       The signatures for the source release artefacts:
>>>>>
>>>>>
>>>>> Signature for apache-wicket-8.0.0-M9.zip:
>>>>>
>>>>>       -----BEGIN PGP SIGNATURE-----
>>>>> Version: GnuPG v1
>>>>>
>>>>> iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
>>>>> Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
>>>>> rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
>>>>> YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
>>>>> Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
>>>>> EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
>>>>> Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
>>>>> E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
>>>>> TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
>>>>> Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
>>>>> K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
>>>>> jIvOQJKU+bwlubLLneTg
>>>>> =MOtP
>>>>> -----END PGP SIGNATURE-----
>>>>>
>>>>> Signature for apache-wicket-8.0.0-M9.tar.gz:
>>>>>
>>>>>       -----BEGIN PGP SIGNATURE-----
>>>>> Version: GnuPG v1
>>>>>
>>>>> iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
>>>>> b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
>>>>> oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
>>>>> nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
>>>>> B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
>>>>> hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
>>>>> aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
>>>>> sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
>>>>> YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
>>>>> GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
>>>>> 3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
>>>>> CCJOHO3iofZ0wlGnB5J7
>>>>> =/qPh
>>>>> -----END PGP SIGNATURE-----
>>>>>
>>>>> ========================================================================
>>>>>
>>>>>
>>>>>       CHANGELOG for 8.0.0-M9:
>>>>>
>>>>> ** Bug
>>>>>
>>>>>       * [WICKET-6332] - NullPointerException in PageParameters#equals()
>>>>>       * [WICKET-6441] - MockHttpSession and MockSessionStore don't call
>>>>> onInvalidate() on invalidate()
>>>>>       * [WICKET-6448] - Provide behavior that disables a button after
>>>>> click
>>>>>       * [WICKET-6477] - Component.getDefaultModelObject() wraps in
>>>>> RuntimeException instead of WicketRuntimeException
>>>>>       * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
>>>>>       * [WICKET-6489] - Exception when "identifier|code" javascript is
>>>>> not start on PrependJavaScript
>>>>>       * [WICKET-6491] - AjaxDownload is not working in blob mode for
>>>>> Microsoft browsers
>>>>>       * [WICKET-6492] - javascript files are not minified in deployment
>>>>> mode and not united
>>>>>       * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession one
>>>>> used instead of Websocket one) + NPE if no HttpSession is found during
>>>>> Handshake Request
>>>>>       * [WICKET-6496] - Duplicate definition of interface JSONString
>>>>>       * [WICKET-6501] - DefaultPageManagerProvider does not honour
>>>>> StoreSettings.setAsynchronous(false)
>>>>>       * [WICKET-6506] - Performance issue when large component isn't
>>>>> visible
>>>>>       * [WICKET-6512] - pageId is being reset during
>>>>> Session::replaceSession() call
>>>>>       * [WICKET-6513] - NullPointerException at
>>>>> PageStoreManager$SessionEntry after login
>>>>>       * [WICKET-6518] - Memory leaks on quickstart restart in tomcat
>>>>>       * [WICKET-6522] - ThreadLocal leak in PageStoreManager
>>>>>       * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same component
>>>>> timeId conflict
>>>>>       * [WICKET-6524] - Do not require bean validation 2.0.0
>>>>>       * [WICKET-6529] - Feedback from onSubmit not rendered on stateless
>>>>> pages
>>>>>       * [WICKET-6530] - Race-condition in session invalidation
>>>>>
>>>>> ** New Feature
>>>>>
>>>>>       * [WICKET-6497] - unify javascript files
>>>>>       * [WICKET-6498] - wicket 8 - js to asnyc and or defer
>>>>>
>>>>> ** Improvement
>>>>>
>>>>>       * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking
>>>>> lazy load
>>>>>       * [WICKET-6284] - Introduce lambda-enhanced factory method in
>>>>> ResourceReference
>>>>>       * [WICKET-6499] - Support for Bean Validation 2.0
>>>>>       * [WICKET-6503] - Ajax refresh and feedback panel
>>>>>       * [WICKET-6504] - Use a serializable model for FileSystemResource's
>>>>> path
>>>>>       * [WICKET-6509] - Import junit packages as optional
>>>>>       * [WICKET-6514] - FeedbackCollector(Component) should not collect
>>>>> session-scoped feedback messages
>>>>>       * [WICKET-6517] - use Ajax for multipart instead of iframe
>>>>>
>>>>> ** Task
>>>>>
>>>>>       * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent() before
>>>>> Wicket 8.0.0
>>>>>


Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Andrea Del Bene <an...@gmail.com>.
Hi Sven,

what I noticed with my application and with one of the tutorial examples is
that with the current solutions based on
JavaScriptFilteredIntoFooterHeaderResponse
some header item are "swallowed" without being rendered. Missing items
usually are Wicket internal javascript files like wicket-event-jquery.js.
I'm attaching a quickstart project to WICKET-6498 so you can investigate
the behavior.

On Sun, Feb 11, 2018 at 9:24 PM, Sven Meier <sv...@meiers.net> wrote:

> Hi,
>
> JavaScriptDeferHeaderResponse is an *alternative* to
> JavaScriptFilteredIntoFooterHeaderResponse, it doesn't break anything -
> but even if you wanted to, you could use both simultaneously.
>
> Regarding WICKET-6498's experimental status - I've added the following to
> the JavaDoc:
>
>  * Note: This solution depends on the execution order of JavaScript in the
> browser:
>  * The 'DOMContentLoaded' event has to be fired <me>after</em> all
> deferred JavaScript
>  * resources have been loaded. This doesn't seem to be the case in all
> browsers, thus
>  * this class should be considered experimental.
>
> IMHO this is warning enough.
>
> Sven
>
>
>
> Am 11.02.2018 um 20:03 schrieb Andrea Del Bene:
>
>> Good point. We should also underline that WICKET-6498 breaks custom
>> response decoration that might be used to place JavaScript inside body tag.
>>
>>
>> On 11/02/2018 18:16, Korbinian Bachl wrote:
>>
>>> +1 to release for M9
>>>
>>> IMHO a warning should be added with regards to WICKET-6498 as it is not
>>> yet working in a reliable way but may break depending on client specifics;
>>>
>>> ----- Ursprüngliche Mail -----
>>>
>>>> Von: "Andrea Del Bene" <an...@gmail.com>
>>>> An: dev@wicket.apache.org
>>>> Gesendet: Sonntag, 11. Februar 2018 17:34:08
>>>> Betreff: [VOTE] Release Apache Wicket 8.0.0-M9
>>>> This is a vote to release Apache Wicket 8.0.0-M9
>>>>
>>>> Please download the source distributions found in our staging area
>>>> linked below.
>>>>
>>>> I have included the signatures for both the source archives. This vote
>>>> lasts for 72 hours minimum.
>>>>
>>>> [ ] Yes, release Apache Wicket 8.0.0-M9
>>>> [ ] No, don't release Apache Wicket 8.0.0-M9, because ...
>>>>
>>>> Distributions, changelog, keys and signatures can be found at:
>>>>
>>>>      https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9
>>>>
>>>> Staging repository:
>>>>
>>>> https://repository.apache.org/content/repositories/orgapache
>>>> wicket-1105/
>>>>
>>>> The binaries are available in the above link, as are a staging
>>>> repository for Maven. Typically the vote is on the source, but should
>>>> you find a problem with one of the binaries, please let me know, I can
>>>> re-roll them some way or the other.
>>>>
>>>> Staging git repository data:
>>>>
>>>>      Repository:  git@github.com:bitstorm/wicket.git
>>>>      Branch:      build/wicket-8.0.0-M9
>>>>      Release tag: rel/wicket-8.0.0-M9
>>>>
>>>>
>>>> ========================================================================
>>>>
>>>>
>>>>      The signatures for the source release artefacts:
>>>>
>>>>
>>>> Signature for apache-wicket-8.0.0-M9.zip:
>>>>
>>>>      -----BEGIN PGP SIGNATURE-----
>>>> Version: GnuPG v1
>>>>
>>>> iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
>>>> Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
>>>> rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
>>>> YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
>>>> Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
>>>> EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
>>>> Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
>>>> E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
>>>> TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
>>>> Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
>>>> K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
>>>> jIvOQJKU+bwlubLLneTg
>>>> =MOtP
>>>> -----END PGP SIGNATURE-----
>>>>
>>>> Signature for apache-wicket-8.0.0-M9.tar.gz:
>>>>
>>>>      -----BEGIN PGP SIGNATURE-----
>>>> Version: GnuPG v1
>>>>
>>>> iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
>>>> b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
>>>> oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
>>>> nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
>>>> B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
>>>> hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
>>>> aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
>>>> sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
>>>> YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
>>>> GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
>>>> 3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
>>>> CCJOHO3iofZ0wlGnB5J7
>>>> =/qPh
>>>> -----END PGP SIGNATURE-----
>>>>
>>>> ========================================================================
>>>>
>>>>
>>>>      CHANGELOG for 8.0.0-M9:
>>>>
>>>> ** Bug
>>>>
>>>>      * [WICKET-6332] - NullPointerException in PageParameters#equals()
>>>>      * [WICKET-6441] - MockHttpSession and MockSessionStore don't call
>>>> onInvalidate() on invalidate()
>>>>      * [WICKET-6448] - Provide behavior that disables a button after
>>>> click
>>>>      * [WICKET-6477] - Component.getDefaultModelObject() wraps in
>>>> RuntimeException instead of WicketRuntimeException
>>>>      * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
>>>>      * [WICKET-6489] - Exception when "identifier|code" javascript is
>>>> not start on PrependJavaScript
>>>>      * [WICKET-6491] - AjaxDownload is not working in blob mode for
>>>> Microsoft browsers
>>>>      * [WICKET-6492] - javascript files are not minified in deployment
>>>> mode and not united
>>>>      * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession one
>>>> used instead of Websocket one) + NPE if no HttpSession is found during
>>>> Handshake Request
>>>>      * [WICKET-6496] - Duplicate definition of interface JSONString
>>>>      * [WICKET-6501] - DefaultPageManagerProvider does not honour
>>>> StoreSettings.setAsynchronous(false)
>>>>      * [WICKET-6506] - Performance issue when large component isn't
>>>> visible
>>>>      * [WICKET-6512] - pageId is being reset during
>>>> Session::replaceSession() call
>>>>      * [WICKET-6513] - NullPointerException at
>>>> PageStoreManager$SessionEntry after login
>>>>      * [WICKET-6518] - Memory leaks on quickstart restart in tomcat
>>>>      * [WICKET-6522] - ThreadLocal leak in PageStoreManager
>>>>      * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same component
>>>> timeId conflict
>>>>      * [WICKET-6524] - Do not require bean validation 2.0.0
>>>>      * [WICKET-6529] - Feedback from onSubmit not rendered on stateless
>>>> pages
>>>>      * [WICKET-6530] - Race-condition in session invalidation
>>>>
>>>> ** New Feature
>>>>
>>>>      * [WICKET-6497] - unify javascript files
>>>>      * [WICKET-6498] - wicket 8 - js to asnyc and or defer
>>>>
>>>> ** Improvement
>>>>
>>>>      * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking
>>>> lazy load
>>>>      * [WICKET-6284] - Introduce lambda-enhanced factory method in
>>>> ResourceReference
>>>>      * [WICKET-6499] - Support for Bean Validation 2.0
>>>>      * [WICKET-6503] - Ajax refresh and feedback panel
>>>>      * [WICKET-6504] - Use a serializable model for FileSystemResource's
>>>> path
>>>>      * [WICKET-6509] - Import junit packages as optional
>>>>      * [WICKET-6514] - FeedbackCollector(Component) should not collect
>>>> session-scoped feedback messages
>>>>      * [WICKET-6517] - use Ajax for multipart instead of iframe
>>>>
>>>> ** Task
>>>>
>>>>      * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent() before
>>>> Wicket 8.0.0
>>>>
>>>
>>
>

Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Tobias Soloschenko <to...@googlemail.com>.
+1

kind regards

Tobias

> Am 11.02.2018 um 21:24 schrieb Sven Meier <sv...@meiers.net>:
> 
> Hi,
> 
> JavaScriptDeferHeaderResponse is an *alternative* to JavaScriptFilteredIntoFooterHeaderResponse, it doesn't break anything - but even if you wanted to, you could use both simultaneously.
> 
> Regarding WICKET-6498's experimental status - I've added the following to the JavaDoc:
> 
>  * Note: This solution depends on the execution order of JavaScript in the browser:
>  * The 'DOMContentLoaded' event has to be fired <me>after</em> all deferred JavaScript
>  * resources have been loaded. This doesn't seem to be the case in all browsers, thus
>  * this class should be considered experimental.
> 
> IMHO this is warning enough.
> 
> Sven
> 
> 
>> Am 11.02.2018 um 20:03 schrieb Andrea Del Bene:
>> Good point. We should also underline that WICKET-6498 breaks custom response decoration that might be used to place JavaScript inside body tag.
>> 
>> 
>>> On 11/02/2018 18:16, Korbinian Bachl wrote:
>>> +1 to release for M9
>>> 
>>> IMHO a warning should be added with regards to WICKET-6498 as it is not yet working in a reliable way but may break depending on client specifics;
>>> 
>>> ----- Ursprüngliche Mail -----
>>>> Von: "Andrea Del Bene" <an...@gmail.com>
>>>> An: dev@wicket.apache.org
>>>> Gesendet: Sonntag, 11. Februar 2018 17:34:08
>>>> Betreff: [VOTE] Release Apache Wicket 8.0.0-M9
>>>> This is a vote to release Apache Wicket 8.0.0-M9
>>>> 
>>>> Please download the source distributions found in our staging area
>>>> linked below.
>>>> 
>>>> I have included the signatures for both the source archives. This vote
>>>> lasts for 72 hours minimum.
>>>> 
>>>> [ ] Yes, release Apache Wicket 8.0.0-M9
>>>> [ ] No, don't release Apache Wicket 8.0.0-M9, because ...
>>>> 
>>>> Distributions, changelog, keys and signatures can be found at:
>>>> 
>>>>      https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9
>>>> 
>>>> Staging repository:
>>>> 
>>>> https://repository.apache.org/content/repositories/orgapachewicket-1105/ 
>>>> 
>>>> The binaries are available in the above link, as are a staging
>>>> repository for Maven. Typically the vote is on the source, but should
>>>> you find a problem with one of the binaries, please let me know, I can
>>>> re-roll them some way or the other.
>>>> 
>>>> Staging git repository data:
>>>> 
>>>>      Repository:  git@github.com:bitstorm/wicket.git
>>>>      Branch:      build/wicket-8.0.0-M9
>>>>      Release tag: rel/wicket-8.0.0-M9
>>>> 
>>>> 
>>>> ======================================================================== 
>>>> 
>>>>      The signatures for the source release artefacts:
>>>> 
>>>> 
>>>> Signature for apache-wicket-8.0.0-M9.zip:
>>>> 
>>>>      -----BEGIN PGP SIGNATURE-----
>>>> Version: GnuPG v1
>>>> 
>>>> iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
>>>> Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
>>>> rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
>>>> YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
>>>> Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
>>>> EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
>>>> Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
>>>> E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
>>>> TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
>>>> Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
>>>> K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
>>>> jIvOQJKU+bwlubLLneTg
>>>> =MOtP
>>>> -----END PGP SIGNATURE-----
>>>> 
>>>> Signature for apache-wicket-8.0.0-M9.tar.gz:
>>>> 
>>>>      -----BEGIN PGP SIGNATURE-----
>>>> Version: GnuPG v1
>>>> 
>>>> iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
>>>> b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
>>>> oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
>>>> nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
>>>> B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
>>>> hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
>>>> aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
>>>> sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
>>>> YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
>>>> GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
>>>> 3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
>>>> CCJOHO3iofZ0wlGnB5J7
>>>> =/qPh
>>>> -----END PGP SIGNATURE-----
>>>> 
>>>> ======================================================================== 
>>>> 
>>>>      CHANGELOG for 8.0.0-M9:
>>>> 
>>>> ** Bug
>>>> 
>>>>      * [WICKET-6332] - NullPointerException in PageParameters#equals()
>>>>      * [WICKET-6441] - MockHttpSession and MockSessionStore don't call
>>>> onInvalidate() on invalidate()
>>>>      * [WICKET-6448] - Provide behavior that disables a button after click
>>>>      * [WICKET-6477] - Component.getDefaultModelObject() wraps in
>>>> RuntimeException instead of WicketRuntimeException
>>>>      * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
>>>>      * [WICKET-6489] - Exception when "identifier|code" javascript is
>>>> not start on PrependJavaScript
>>>>      * [WICKET-6491] - AjaxDownload is not working in blob mode for
>>>> Microsoft browsers
>>>>      * [WICKET-6492] - javascript files are not minified in deployment
>>>> mode and not united
>>>>      * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession one
>>>> used instead of Websocket one) + NPE if no HttpSession is found during
>>>> Handshake Request
>>>>      * [WICKET-6496] - Duplicate definition of interface JSONString
>>>>      * [WICKET-6501] - DefaultPageManagerProvider does not honour
>>>> StoreSettings.setAsynchronous(false)
>>>>      * [WICKET-6506] - Performance issue when large component isn't visible
>>>>      * [WICKET-6512] - pageId is being reset during
>>>> Session::replaceSession() call
>>>>      * [WICKET-6513] - NullPointerException at
>>>> PageStoreManager$SessionEntry after login
>>>>      * [WICKET-6518] - Memory leaks on quickstart restart in tomcat
>>>>      * [WICKET-6522] - ThreadLocal leak in PageStoreManager
>>>>      * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same component
>>>> timeId conflict
>>>>      * [WICKET-6524] - Do not require bean validation 2.0.0
>>>>      * [WICKET-6529] - Feedback from onSubmit not rendered on stateless
>>>> pages
>>>>      * [WICKET-6530] - Race-condition in session invalidation
>>>> 
>>>> ** New Feature
>>>> 
>>>>      * [WICKET-6497] - unify javascript files
>>>>      * [WICKET-6498] - wicket 8 - js to asnyc and or defer
>>>> 
>>>> ** Improvement
>>>> 
>>>>      * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking
>>>> lazy load
>>>>      * [WICKET-6284] - Introduce lambda-enhanced factory method in
>>>> ResourceReference
>>>>      * [WICKET-6499] - Support for Bean Validation 2.0
>>>>      * [WICKET-6503] - Ajax refresh and feedback panel
>>>>      * [WICKET-6504] - Use a serializable model for FileSystemResource's
>>>> path
>>>>      * [WICKET-6509] - Import junit packages as optional
>>>>      * [WICKET-6514] - FeedbackCollector(Component) should not collect
>>>> session-scoped feedback messages
>>>>      * [WICKET-6517] - use Ajax for multipart instead of iframe
>>>> 
>>>> ** Task
>>>> 
>>>>      * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent() before
>>>> Wicket 8.0.0
>> 
> 

Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Sven Meier <sv...@meiers.net>.
Hi,

JavaScriptDeferHeaderResponse is an *alternative* to 
JavaScriptFilteredIntoFooterHeaderResponse, it doesn't break anything - 
but even if you wanted to, you could use both simultaneously.

Regarding WICKET-6498's experimental status - I've added the following 
to the JavaDoc:

  * Note: This solution depends on the execution order of JavaScript in 
the browser:
  * The 'DOMContentLoaded' event has to be fired <me>after</em> all 
deferred JavaScript
  * resources have been loaded. This doesn't seem to be the case in all 
browsers, thus
  * this class should be considered experimental.

IMHO this is warning enough.

Sven


Am 11.02.2018 um 20:03 schrieb Andrea Del Bene:
> Good point. We should also underline that WICKET-6498 breaks custom 
> response decoration that might be used to place JavaScript inside body 
> tag.
>
>
> On 11/02/2018 18:16, Korbinian Bachl wrote:
>> +1 to release for M9
>>
>> IMHO a warning should be added with regards to WICKET-6498 as it is 
>> not yet working in a reliable way but may break depending on client 
>> specifics;
>>
>> ----- Ursprüngliche Mail -----
>>> Von: "Andrea Del Bene" <an...@gmail.com>
>>> An: dev@wicket.apache.org
>>> Gesendet: Sonntag, 11. Februar 2018 17:34:08
>>> Betreff: [VOTE] Release Apache Wicket 8.0.0-M9
>>> This is a vote to release Apache Wicket 8.0.0-M9
>>>
>>> Please download the source distributions found in our staging area
>>> linked below.
>>>
>>> I have included the signatures for both the source archives. This vote
>>> lasts for 72 hours minimum.
>>>
>>> [ ] Yes, release Apache Wicket 8.0.0-M9
>>> [ ] No, don't release Apache Wicket 8.0.0-M9, because ...
>>>
>>> Distributions, changelog, keys and signatures can be found at:
>>>
>>>      https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9
>>>
>>> Staging repository:
>>>
>>> https://repository.apache.org/content/repositories/orgapachewicket-1105/ 
>>>
>>>
>>> The binaries are available in the above link, as are a staging
>>> repository for Maven. Typically the vote is on the source, but should
>>> you find a problem with one of the binaries, please let me know, I can
>>> re-roll them some way or the other.
>>>
>>> Staging git repository data:
>>>
>>>      Repository:  git@github.com:bitstorm/wicket.git
>>>      Branch:      build/wicket-8.0.0-M9
>>>      Release tag: rel/wicket-8.0.0-M9
>>>
>>>
>>> ======================================================================== 
>>>
>>>
>>>      The signatures for the source release artefacts:
>>>
>>>
>>> Signature for apache-wicket-8.0.0-M9.zip:
>>>
>>>      -----BEGIN PGP SIGNATURE-----
>>> Version: GnuPG v1
>>>
>>> iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
>>> Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
>>> rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
>>> YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
>>> Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
>>> EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
>>> Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
>>> E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
>>> TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
>>> Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
>>> K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
>>> jIvOQJKU+bwlubLLneTg
>>> =MOtP
>>> -----END PGP SIGNATURE-----
>>>
>>> Signature for apache-wicket-8.0.0-M9.tar.gz:
>>>
>>>      -----BEGIN PGP SIGNATURE-----
>>> Version: GnuPG v1
>>>
>>> iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
>>> b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
>>> oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
>>> nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
>>> B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
>>> hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
>>> aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
>>> sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
>>> YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
>>> GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
>>> 3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
>>> CCJOHO3iofZ0wlGnB5J7
>>> =/qPh
>>> -----END PGP SIGNATURE-----
>>>
>>> ======================================================================== 
>>>
>>>
>>>      CHANGELOG for 8.0.0-M9:
>>>
>>> ** Bug
>>>
>>>      * [WICKET-6332] - NullPointerException in PageParameters#equals()
>>>      * [WICKET-6441] - MockHttpSession and MockSessionStore don't call
>>> onInvalidate() on invalidate()
>>>      * [WICKET-6448] - Provide behavior that disables a button after 
>>> click
>>>      * [WICKET-6477] - Component.getDefaultModelObject() wraps in
>>> RuntimeException instead of WicketRuntimeException
>>>      * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
>>>      * [WICKET-6489] - Exception when "identifier|code" javascript is
>>> not start on PrependJavaScript
>>>      * [WICKET-6491] - AjaxDownload is not working in blob mode for
>>> Microsoft browsers
>>>      * [WICKET-6492] - javascript files are not minified in deployment
>>> mode and not united
>>>      * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession one
>>> used instead of Websocket one) + NPE if no HttpSession is found during
>>> Handshake Request
>>>      * [WICKET-6496] - Duplicate definition of interface JSONString
>>>      * [WICKET-6501] - DefaultPageManagerProvider does not honour
>>> StoreSettings.setAsynchronous(false)
>>>      * [WICKET-6506] - Performance issue when large component isn't 
>>> visible
>>>      * [WICKET-6512] - pageId is being reset during
>>> Session::replaceSession() call
>>>      * [WICKET-6513] - NullPointerException at
>>> PageStoreManager$SessionEntry after login
>>>      * [WICKET-6518] - Memory leaks on quickstart restart in tomcat
>>>      * [WICKET-6522] - ThreadLocal leak in PageStoreManager
>>>      * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same component
>>> timeId conflict
>>>      * [WICKET-6524] - Do not require bean validation 2.0.0
>>>      * [WICKET-6529] - Feedback from onSubmit not rendered on stateless
>>> pages
>>>      * [WICKET-6530] - Race-condition in session invalidation
>>>
>>> ** New Feature
>>>
>>>      * [WICKET-6497] - unify javascript files
>>>      * [WICKET-6498] - wicket 8 - js to asnyc and or defer
>>>
>>> ** Improvement
>>>
>>>      * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking
>>> lazy load
>>>      * [WICKET-6284] - Introduce lambda-enhanced factory method in
>>> ResourceReference
>>>      * [WICKET-6499] - Support for Bean Validation 2.0
>>>      * [WICKET-6503] - Ajax refresh and feedback panel
>>>      * [WICKET-6504] - Use a serializable model for 
>>> FileSystemResource's
>>> path
>>>      * [WICKET-6509] - Import junit packages as optional
>>>      * [WICKET-6514] - FeedbackCollector(Component) should not collect
>>> session-scoped feedback messages
>>>      * [WICKET-6517] - use Ajax for multipart instead of iframe
>>>
>>> ** Task
>>>
>>>      * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent() before
>>> Wicket 8.0.0
>


Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Andrea Del Bene <an...@gmail.com>.
Good point. We should also underline that WICKET-6498 breaks custom 
response decoration that might be used to place JavaScript inside body tag.


On 11/02/2018 18:16, Korbinian Bachl wrote:
> +1 to release for M9
>
> IMHO a warning should be added with regards to WICKET-6498 as it is not yet working in a reliable way but may break depending on client specifics;
>
> ----- Ursprüngliche Mail -----
>> Von: "Andrea Del Bene" <an...@gmail.com>
>> An: dev@wicket.apache.org
>> Gesendet: Sonntag, 11. Februar 2018 17:34:08
>> Betreff: [VOTE] Release Apache Wicket 8.0.0-M9
>> This is a vote to release Apache Wicket 8.0.0-M9
>>
>> Please download the source distributions found in our staging area
>> linked below.
>>
>> I have included the signatures for both the source archives. This vote
>> lasts for 72 hours minimum.
>>
>> [ ] Yes, release Apache Wicket 8.0.0-M9
>> [ ] No, don't release Apache Wicket 8.0.0-M9, because ...
>>
>> Distributions, changelog, keys and signatures can be found at:
>>
>>      https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9
>>
>> Staging repository:
>>
>> https://repository.apache.org/content/repositories/orgapachewicket-1105/
>>
>> The binaries are available in the above link, as are a staging
>> repository for Maven. Typically the vote is on the source, but should
>> you find a problem with one of the binaries, please let me know, I can
>> re-roll them some way or the other.
>>
>> Staging git repository data:
>>
>>      Repository:  git@github.com:bitstorm/wicket.git
>>      Branch:      build/wicket-8.0.0-M9
>>      Release tag: rel/wicket-8.0.0-M9
>>
>>
>> ========================================================================
>>
>>      The signatures for the source release artefacts:
>>
>>
>> Signature for apache-wicket-8.0.0-M9.zip:
>>
>>      -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1
>>
>> iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
>> Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
>> rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
>> YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
>> Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
>> EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
>> Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
>> E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
>> TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
>> Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
>> K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
>> jIvOQJKU+bwlubLLneTg
>> =MOtP
>> -----END PGP SIGNATURE-----
>>
>> Signature for apache-wicket-8.0.0-M9.tar.gz:
>>
>>      -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1
>>
>> iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
>> b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
>> oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
>> nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
>> B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
>> hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
>> aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
>> sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
>> YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
>> GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
>> 3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
>> CCJOHO3iofZ0wlGnB5J7
>> =/qPh
>> -----END PGP SIGNATURE-----
>>
>> ========================================================================
>>
>>      CHANGELOG for 8.0.0-M9:
>>
>> ** Bug
>>
>>      * [WICKET-6332] - NullPointerException in PageParameters#equals()
>>      * [WICKET-6441] - MockHttpSession and MockSessionStore don't call
>> onInvalidate() on invalidate()
>>      * [WICKET-6448] - Provide behavior that disables a button after click
>>      * [WICKET-6477] - Component.getDefaultModelObject() wraps in
>> RuntimeException instead of WicketRuntimeException
>>      * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
>>      * [WICKET-6489] - Exception when "identifier|code" javascript is
>> not start on PrependJavaScript
>>      * [WICKET-6491] - AjaxDownload is not working in blob mode for
>> Microsoft browsers
>>      * [WICKET-6492] - javascript files are not minified in deployment
>> mode and not united
>>      * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession one
>> used instead of Websocket one) + NPE if no HttpSession is found during
>> Handshake Request
>>      * [WICKET-6496] - Duplicate definition of interface JSONString
>>      * [WICKET-6501] - DefaultPageManagerProvider does not honour
>> StoreSettings.setAsynchronous(false)
>>      * [WICKET-6506] - Performance issue when large component isn't visible
>>      * [WICKET-6512] - pageId is being reset during
>> Session::replaceSession() call
>>      * [WICKET-6513] - NullPointerException at
>> PageStoreManager$SessionEntry after login
>>      * [WICKET-6518] - Memory leaks on quickstart restart in tomcat
>>      * [WICKET-6522] - ThreadLocal leak in PageStoreManager
>>      * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same component
>> timeId conflict
>>      * [WICKET-6524] - Do not require bean validation 2.0.0
>>      * [WICKET-6529] - Feedback from onSubmit not rendered on stateless
>> pages
>>      * [WICKET-6530] - Race-condition in session invalidation
>>
>> ** New Feature
>>
>>      * [WICKET-6497] - unify javascript files
>>      * [WICKET-6498] - wicket 8 - js to asnyc and or defer
>>
>> ** Improvement
>>
>>      * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking
>> lazy load
>>      * [WICKET-6284] - Introduce lambda-enhanced factory method in
>> ResourceReference
>>      * [WICKET-6499] - Support for Bean Validation 2.0
>>      * [WICKET-6503] - Ajax refresh and feedback panel
>>      * [WICKET-6504] - Use a serializable model for FileSystemResource's
>> path
>>      * [WICKET-6509] - Import junit packages as optional
>>      * [WICKET-6514] - FeedbackCollector(Component) should not collect
>> session-scoped feedback messages
>>      * [WICKET-6517] - use Ajax for multipart instead of iframe
>>
>> ** Task
>>
>>      * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent() before
>> Wicket 8.0.0


Re: [VOTE] Release Apache Wicket 8.0.0-M9

Posted by Korbinian Bachl <ko...@whiskyworld.de>.
+1 to release for M9

IMHO a warning should be added with regards to WICKET-6498 as it is not yet working in a reliable way but may break depending on client specifics;

----- Ursprüngliche Mail -----
> Von: "Andrea Del Bene" <an...@gmail.com>
> An: dev@wicket.apache.org
> Gesendet: Sonntag, 11. Februar 2018 17:34:08
> Betreff: [VOTE] Release Apache Wicket 8.0.0-M9

> This is a vote to release Apache Wicket 8.0.0-M9
> 
> Please download the source distributions found in our staging area
> linked below.
> 
> I have included the signatures for both the source archives. This vote
> lasts for 72 hours minimum.
> 
> [ ] Yes, release Apache Wicket 8.0.0-M9
> [ ] No, don't release Apache Wicket 8.0.0-M9, because ...
> 
> Distributions, changelog, keys and signatures can be found at:
> 
>     https://dist.apache.org/repos/dist/dev/wicket/8.0.0-M9
> 
> Staging repository:
> 
> https://repository.apache.org/content/repositories/orgapachewicket-1105/
> 
> The binaries are available in the above link, as are a staging
> repository for Maven. Typically the vote is on the source, but should
> you find a problem with one of the binaries, please let me know, I can
> re-roll them some way or the other.
> 
> Staging git repository data:
> 
>     Repository:  git@github.com:bitstorm/wicket.git
>     Branch:      build/wicket-8.0.0-M9
>     Release tag: rel/wicket-8.0.0-M9
> 
> 
> ========================================================================
> 
>     The signatures for the source release artefacts:
> 
> 
> Signature for apache-wicket-8.0.0-M9.zip:
> 
>     -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
> 
> iQIcBAABAgAGBQJagFiiAAoJEIePAfqo01bhPxsP/jgrMjf/3IVHWSOftoHEYf+j
> Wtb8gvB0Y3sY8L6syj5GQCuhceaovbq3NCnAz0qrn/tLRuUnybyj8GfyMrQv4wNP
> rDj7zPRqhsldgbSTsjDP98b0V99F5ct68HsxOr3LzxNijFNFRxIDnF+73QZNjUcA
> YL4xuxP80WvMb1mmwASg+l9MxhEWpeYWoyOBHNWFmjgI/4r3ineq2YSjAq3MZKOC
> Vu4CqYS+ajEFMqduHU4aa9j4Lj4X81by34c9xCKERaioI7kFhoZzhws6ufoA/wNo
> EPBPBft9oG72rUfX9VwyZxHMBmU50eKmEtFeCtWXqu5v8Js2rVTxmw4EGKENj3+8
> Kiup7+zXu9t07mvoS4mCJ8fcl7P+g24e02pdqHDBea/a7zAKUdrIe6MCMJ2Qlw0g
> E/xlDJ4utPcU7E88IQiCLpmarN3uBZKnivzm3Uir5U0dJtffu4IacABg5Svp3DAl
> TcUOmM9QxKYjD8Ey6uORoGTm3gZmx4FcnNjSw0ch27fyNUpYVfEyU88KH9vz2dQP
> Tcs9LxRpII4pBGXu0nK5zWZfXBgqxYfUUrIroCrzVWub+wqEw8pXo2K9GdrUYpcg
> K12TIpW3X43zNG7L6lTJtFe2yffVLdyS1DDoqU3QI4gHe/vdIC3atd4BP0Aeauj1
> jIvOQJKU+bwlubLLneTg
> =MOtP
> -----END PGP SIGNATURE-----
> 
> Signature for apache-wicket-8.0.0-M9.tar.gz:
> 
>     -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
> 
> iQIcBAABAgAGBQJagFihAAoJEIePAfqo01bheU8QAIkUJK3zjjVeARkAbN3Zi1hE
> b5qnaSiXkuxZyTfVzDS4Ui7OZwIOY1RJ1YlJ4fZwio+BJhpxnCiPjPLRC1VNwA4q
> oMBsOfwePU92kJYQERfVfJgNkk1ixyh52k3qsoS4EIdKT+bOW52hT8zaXRNazhG3
> nwyDTe00c/ibj5KM68L7R4LXef6tbnZAjegKBDNUsvWQltwE2xc1lVapnNoqtOAM
> B26gWh5G8QDQxjWJESk9ik+Vyyg9We8lABV5+Hkqrugv3yECiD9ObcYE29bE/OHN
> hfgzo5EX+umXzTkoHltQ0ZxAxPiWWquH3tjsy1/z/8r3BT4YBZs+PIoOCSPem6kK
> aUoJiBEZ55WsBVd5NdYY7PiSwZ2KWsuE1XmqADY+USuhytPln04YNK9srdVESnCL
> sBxGP0kgHKrD92O1aTLpzan3VhD1O8KzjH/8MMEWJxevQbW/gorlAjh7+iCVcH7g
> YurqMjtq91YFFlZwU5YlczfhnZmR4/Efp3/O57S76HOyaMWYloj0vs2OQH3TJTm7
> GLvO/b9R46mgnnlHVhxN2z1f0xTOFwpeXIjchb+jHs0SuxOVAqrIpGmsFG8Siv/V
> 3spQEzAzM/Enl2PgaCNlU0aus/i35FRLEmlCf7nyuwVQCbsE3d5W/fKLYeJOD9Wq
> CCJOHO3iofZ0wlGnB5J7
> =/qPh
> -----END PGP SIGNATURE-----
> 
> ========================================================================
> 
>     CHANGELOG for 8.0.0-M9:
> 
> ** Bug
> 
>     * [WICKET-6332] - NullPointerException in PageParameters#equals()
>     * [WICKET-6441] - MockHttpSession and MockSessionStore don't call
> onInvalidate() on invalidate()
>     * [WICKET-6448] - Provide behavior that disables a button after click
>     * [WICKET-6477] - Component.getDefaultModelObject() wraps in
> RuntimeException instead of WicketRuntimeException
>     * [WICKET-6484] - Wicket.Cookie.set does not set 'secure' flag
>     * [WICKET-6489] - Exception when "identifier|code" javascript is
> not start on PrependJavaScript
>     * [WICKET-6491] - AjaxDownload is not working in blob mode for
> Microsoft browsers
>     * [WICKET-6492] - javascript files are not minified in deployment
> mode and not united
>     * [WICKET-6493] - WebSocket SessionIds are wrong (HttpSession one
> used instead of Websocket one) + NPE if no HttpSession is found during
> Handshake Request
>     * [WICKET-6496] - Duplicate definition of interface JSONString
>     * [WICKET-6501] - DefaultPageManagerProvider does not honour
> StoreSettings.setAsynchronous(false)
>     * [WICKET-6506] - Performance issue when large component isn't visible
>     * [WICKET-6512] - pageId is being reset during
> Session::replaceSession() call
>     * [WICKET-6513] - NullPointerException at
> PageStoreManager$SessionEntry after login
>     * [WICKET-6518] - Memory leaks on quickstart restart in tomcat
>     * [WICKET-6522] - ThreadLocal leak in PageStoreManager
>     * [WICKET-6523] - Two AbstractAjaxTimerBehaviors on same component
> timeId conflict
>     * [WICKET-6524] - Do not require bean validation 2.0.0
>     * [WICKET-6529] - Feedback from onSubmit not rendered on stateless
> pages
>     * [WICKET-6530] - Race-condition in session invalidation
> 
> ** New Feature
> 
>     * [WICKET-6497] - unify javascript files
>     * [WICKET-6498] - wicket 8 - js to asnyc and or defer
> 
> ** Improvement
> 
>     * [WICKET-6055] - AjaxLazyLoadPanel should provide non-blocking
> lazy load
>     * [WICKET-6284] - Introduce lambda-enhanced factory method in
> ResourceReference
>     * [WICKET-6499] - Support for Bean Validation 2.0
>     * [WICKET-6503] - Ajax refresh and feedback panel
>     * [WICKET-6504] - Use a serializable model for FileSystemResource's
> path
>     * [WICKET-6509] - Import junit packages as optional
>     * [WICKET-6514] - FeedbackCollector(Component) should not collect
> session-scoped feedback messages
>     * [WICKET-6517] - use Ajax for multipart instead of iframe
> 
> ** Task
> 
>     * [WICKET-6148] - Remove AjaxEventBehavior#onCheckEvent() before
> Wicket 8.0.0