[GitHub] [flink] zentol commented on a diff in pull request #21007: [FLINK-29569][rest][docs] Remove deprecated "expand" usages

[GitBox <gi...@apache.org>]

zentol commented on code in PR #21007:
URL: https://github.com/apache/flink/pull/21007#discussion_r991390466


##########
flink-docs/src/main/java/org/apache/flink/docs/rest/RestAPIDocGenerator.java:
##########
@@ -207,44 +207,29 @@ private static String createHtmlEntry(MessageHeaders<?, ?, ?> spec) {
         {
             sb.append("    <tr>\n");
             sb.append("      <td colspan=\"2\">\n");
-            sb.append("      <div class=\"book-expand\">\n");
             sb.append("        <label>\n");
-            sb.append("          <div class=\"book-expand-head flex justify-between\">\n");
-            sb.append("            <span>Request</span>\n");
-            sb.append("            &nbsp;");
-            sb.append("            <span>▾</span>\n");
+            sb.append("          <details>\n");
+            sb.append("          <summary>Request</summary>\n");

Review Comment:
   Oh this was intentional since it goes into a similar direction. The deprecated expand macro was essentially exactly what we were doing here for the REST API docs, so I updated that as well so the docs all use the same functionality.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org