Re: [PATCH] issue #4375: provide --password-fd option

[William Orr <wi...@worrbase.com>]

Hey there!

Sorry for the long delay! I've finally amended the patch to make the
recommended fixes.

Thanks

Re: [PATCH] issue #4375: provide --password-fd option

[Stefan Sperling <st...@apache.org>]

On Thu, Dec 21, 2017 at 07:57:23PM -0800, William Orr wrote:
> Hey there!
>
> Sorry for the long delay! I've finally amended the patch to make the
> recommended fixes.

Thanks, committed in http://svn.apache.org/r1819093

In the future, please provide updated log messages along with updated patches.
You've already shown us that you can write good log messages in the first
submission of your patch, and the real reason we are asking people to
do this is to see if they're able to write good log messages ;)
So I have written a new log message from scratch this time.

> +svn_error_t *
> +svn_io_stdin_readline(const char **result,
> +                      apr_pool_t *result_pool,
> +                      apr_pool_t *scratch_pool)
> +{
> +  svn_stringbuf_t *buf = NULL;
> +  svn_stream_t *stdin = NULL;

I had to rename this variable to stdin_stream to avoid the following
error during compilation (on OpenBSD -current):

subversion/libsvn_subr/io.c: In function 'svn_io_stdin_readline':
subversion/libsvn_subr/io.c:5450: error: expected identifier or '(' before '&' token
subversion/libsvn_subr/io.c:5453: error: lvalue required as unary '&' operand
subversion/libsvn_subr/io.c:5454: warning: passing argument 1 of 'svn_stream_readline' from incompatible pointer type

> +  svn_boolean_t oob = FALSE;
> +
> +  SVN_ERR(svn_stream_for_stdin2(&stdin, TRUE, scratch_pool));
> +  SVN_ERR(svn_stream_readline(stdin, &buf, APR_EOL_STR, &oob, result_pool));
> +
> +  *result = buf->data;
> +
> +  return SVN_NO_ERROR;
> +}