You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/28 10:56:37 UTC
[GitHub] [flink] astamur opened a new pull request, #21407: [FLINK-30224][Connectors/Kinesis] An IT test for slow FlinKinesisConsumer's run() which caused an NPE in close
astamur opened a new pull request, #21407:
URL: https://github.com/apache/flink/pull/21407
[FLINK-30224](https://issues.apache.org/jira/projects/FLINK/issues/FLINK-30224)
- An IT test was added which reproduced this issue;
- Previously the issue itself was fixed in [FLINK-29324](https://issues.apache.org/jira/projects/FLINK/issues/FLINK-29324).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21407: [FLINK-30224][Connectors/Kinesis] An IT test for slow FlinKinesisConsumer's run() which caused an NPE in close
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21407:
URL: https://github.com/apache/flink/pull/21407#issuecomment-1328887254
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cc06647550b355c288b2615e7ac5797592e3d993",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cc06647550b355c288b2615e7ac5797592e3d993",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cc06647550b355c288b2615e7ac5797592e3d993 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #21407: [FLINK-30224][Connectors/Kinesis] An IT test for slow FlinKinesisConsumer's run() which caused an NPE in close
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on PR #21407:
URL: https://github.com/apache/flink/pull/21407#issuecomment-1346244117
@astamur it looks like you did not use the standard PR template, can you please fix the description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #21407: [FLINK-30224][Connectors/Kinesis] An IT test for slow FlinKinesisConsumer's run() which caused an NPE in close
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on PR #21407:
URL: https://github.com/apache/flink/pull/21407#issuecomment-1347251548
As discussed, please move to flink-connector-aws
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] astamur closed pull request #21407: [FLINK-30224][Connectors/Kinesis] An IT test for slow FlinKinesisConsumer's run() which caused an NPE in close
Posted by GitBox <gi...@apache.org>.
astamur closed pull request #21407: [FLINK-30224][Connectors/Kinesis] An IT test for slow FlinKinesisConsumer's run() which caused an NPE in close
URL: https://github.com/apache/flink/pull/21407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] astamur commented on a diff in pull request #21407: [FLINK-30224][Connectors/Kinesis] An IT test for slow FlinKinesisConsumer's run() which caused an NPE in close
Posted by GitBox <gi...@apache.org>.
astamur commented on code in PR #21407:
URL: https://github.com/apache/flink/pull/21407#discussion_r1045731622
##########
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisITCase.java:
##########
@@ -175,6 +184,40 @@ private void testStopWithSavepoint(boolean drain, boolean efo) throws Exception
}
}
+ /**
+ * Tests stop with savepoint while {@link
+ * FlinkKinesisConsumer#run(SourceFunction.SourceContext)}} with a slow run method is still
+ * hasn't finished run method and hasn't set a {@link KinesisDataFetcher} yet.
+ */
Review Comment:
Done. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] astamur commented on pull request #21407: [FLINK-30224][Connectors/Kinesis] An IT test for slow FlinKinesisConsumer's run() which caused an NPE in close
Posted by GitBox <gi...@apache.org>.
astamur commented on PR #21407:
URL: https://github.com/apache/flink/pull/21407#issuecomment-1329247096
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on pull request #21407: [FLINK-30224][Connectors/Kinesis] An IT test for slow FlinKinesisConsumer's run() which caused an NPE in close
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on PR #21407:
URL: https://github.com/apache/flink/pull/21407#issuecomment-1333640951
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a diff in pull request #21407: [FLINK-30224][Connectors/Kinesis] An IT test for slow FlinKinesisConsumer's run() which caused an NPE in close
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on code in PR #21407:
URL: https://github.com/apache/flink/pull/21407#discussion_r1045654367
##########
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisITCase.java:
##########
@@ -175,6 +184,40 @@ private void testStopWithSavepoint(boolean drain, boolean efo) throws Exception
}
}
+ /**
+ * Tests stop with savepoint while {@link
+ * FlinkKinesisConsumer#run(SourceFunction.SourceContext)}} with a slow run method is still
+ * hasn't finished run method and hasn't set a {@link KinesisDataFetcher} yet.
+ */
Review Comment:
@astamur this comment is confusing to read, can you please improve?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org