You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2018/06/15 03:59:00 UTC
[jira] [Commented] (HBASE-20736) Fix smattering of error-prone
warnings
[ https://issues.apache.org/jira/browse/HBASE-20736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513303#comment-16513303 ]
Hadoop QA commented on HBASE-20736:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 15 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 7s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 15s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hbase-build-configuration {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 7s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m 17s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 17s{color} | {color:red} hbase-zookeeper in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 1m 22s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 8s{color} | {color:green} hbase-build-configuration in the patch passed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 25s{color} | {color:green} hbase-common generated 0 new + 37 unchanged - 5 fixed = 37 total (was 42) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 13s{color} | {color:green} hbase-hadoop-compat generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 16s{color} | {color:red} hbase-hadoop2-compat generated 1 new + 33 unchanged - 6 fixed = 34 total (was 39) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 33s{color} | {color:red} hbase-client generated 1 new + 97 unchanged - 6 fixed = 98 total (was 103) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 17s{color} | {color:red} hbase-zookeeper in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 18s{color} | {color:green} hbase-http generated 0 new + 16 unchanged - 1 fixed = 16 total (was 17) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 18s{color} | {color:green} hbase-procedure generated 0 new + 4 unchanged - 5 fixed = 4 total (was 9) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 22s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 21s{color} | {color:red} hbase-common: The patch generated 3 new + 12 unchanged - 2 fixed = 15 total (was 14) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 27s{color} | {color:red} hbase-client: The patch generated 1 new + 54 unchanged - 0 fixed = 55 total (was 54) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s{color} | {color:red} hbase-http: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 13s{color} | {color:red} hbase-procedure: The patch generated 1 new + 16 unchanged - 0 fixed = 17 total (was 16) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 2m 32s{color} | {color:red} patch has 14 errors when building our shaded downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 6s{color} | {color:red} The patch causes 15 errors with Hadoop v2.7.4. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 23s{color} | {color:red} The patch causes 15 errors with Hadoop v3.0.0. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hbase-build-configuration {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 11s{color} | {color:red} hbase-zookeeper in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 23s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 7s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 9s{color} | {color:green} hbase-build-configuration in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 32s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 24s{color} | {color:green} hbase-hadoop-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 30s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 59s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 13s{color} | {color:red} hbase-zookeeper in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 44s{color} | {color:green} hbase-http in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 36s{color} | {color:green} hbase-procedure in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 38s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 19s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 56m 37s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-20736 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12927920/HBASE-20736.master.002.patch |
| Optional Tests | asflicense javac javadoc unit shadedjars hadoopcheck xml compile findbugs hbaseanti checkstyle |
| uname | Linux b473cb59e5d4 4.4.0-104-generic #127-Ubuntu SMP Mon Dec 11 12:16:42 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh |
| git revision | master / 86653c708f |
| maven | version: Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) |
| Default Java | 1.8.0_171 |
| findbugs | v3.1.0-RC3 |
| mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/artifact/patchprocess/patch-mvninstall-root.txt |
| compile | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/artifact/patchprocess/patch-compile-hbase-zookeeper.txt |
| compile | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/artifact/patchprocess/patch-compile-hbase-server.txt |
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/artifact/patchprocess/diff-compile-javac-hbase-hadoop2-compat.txt |
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/artifact/patchprocess/diff-compile-javac-hbase-client.txt |
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/artifact/patchprocess/patch-compile-hbase-zookeeper.txt |
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/artifact/patchprocess/patch-compile-hbase-server.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/artifact/patchprocess/diff-checkstyle-hbase-common.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/artifact/patchprocess/diff-checkstyle-hbase-client.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/artifact/patchprocess/diff-checkstyle-hbase-http.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/artifact/patchprocess/diff-checkstyle-hbase-procedure.txt |
| shadedjars | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/artifact/patchprocess/patch-shadedjars.txt |
| hadoopcheck | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/artifact/patchprocess/patch-javac-2.7.4.txt |
| hadoopcheck | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/artifact/patchprocess/patch-javac-3.0.0.txt |
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/artifact/patchprocess/patch-findbugs-hbase-zookeeper.txt |
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/artifact/patchprocess/patch-findbugs-hbase-server.txt |
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/artifact/patchprocess/patch-unit-hbase-zookeeper.txt |
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/artifact/patchprocess/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/testReport/ |
| Max. process+thread count | 315 (vs. ulimit of 10000) |
| modules | C: hbase-build-configuration hbase-common hbase-hadoop-compat hbase-hadoop2-compat hbase-client hbase-zookeeper hbase-http hbase-procedure hbase-server U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/13266/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Fix smattering of error-prone warnings
> --------------------------------------
>
> Key: HBASE-20736
> URL: https://issues.apache.org/jira/browse/HBASE-20736
> Project: HBase
> Issue Type: Bug
> Reporter: Mike Drob
> Assignee: Mike Drob
> Priority: Major
> Attachments: HBASE-20736.master.001.patch, HBASE-20736.master.002.patch
>
>
> I wanted some coding on cruise control for a few hours tonight, so I deiced to fix error-prone warnings. I only fixed ones that were straight-forward, easy to do, and could defensibly have value in the fix. I skipped a lot, and won't claim to have any particular reason. Got as far as hbase-server in the output before deciding to move on with my life (didn't cover the tests at all).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)