You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Benjamin Francisoud (JIRA)" <ji...@apache.org> on 2008/02/07 11:39:07 UTC

[jira] Updated: (PIG-68) Improving build.xml in many ways :)

     [ https://issues.apache.org/jira/browse/PIG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Francisoud updated PIG-68:
-----------------------------------

    Attachment: build.xml-PIG-68-v04.patch

My mistake, I didn't use the correct syntax in the delete tag.

In this patch version I replaced it with:
{code:xml}
<delete>
    <fileset dir="${src.dir}/org/apache/pig/impl/logicalLayer/parser" includes="*.java"/>
    <fileset dir="${src.dir}/org/apache/pig/tools/pigscript/parser" includes="*.java"/>
</delete>
{code}

> Improving build.xml in many ways :)
> -----------------------------------
>
>                 Key: PIG-68
>                 URL: https://issues.apache.org/jira/browse/PIG-68
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: 0.1.0
>            Reporter: Benjamin Francisoud
>            Priority: Minor
>         Attachments: build.xml-PIG-68-v01.patch, build.xml-PIG-68-v02.patch, build.xml-PIG-68-v03.patch, build.xml-PIG-68-v04.patch
>
>
> The build file can be improve in many ways:
> * add revision number to pig.jar name (like: pig-r1234.jar)
> * put pig.jar in the dist dir
> * "clean" target leave a "depend" folder undeleted
> * use a regexp to delete files in "org\apache\pig\impl\logicalLayer\parser" folder instead of listing all files one by one that you want to delete
> * put all artifacts (classes, jar, etc...) in the dist folder so that when doing clean you just need to specify dist
> * provide a description for targets (for "ant -projecthelp" command)
> * use spaces or tabs but not both (spaces are better for patch and diff in my opinion)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.