You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by "Brijesh-Thakkar (via GitHub)" <gi...@apache.org> on 2025/12/31 16:20:05 UTC
[PR] [#3985] Rename remaining data-explorer UI references to chart
Brijesh-Thakkar opened a new pull request, #4081:
URL: https://github.com/apache/streampipes/pull/4081
### Purpose
This PR completes the UI refactor from `data-explorer` to `chart` by updating all remaining
UI references that were not covered by the initial module rename.
The changes ensure consistent naming across the UI by:
- Renaming Angular selectors from `sp-data-explorer-*` to `sp-chart-*`
- Updating chart widget and config components (table, image, status, gauge, map, traffic-light,
time-series, correlation, heatmap, indicator, and shared base widgets)
- Cleaning up remaining `data-explorer` references in UI comments and test (`data-cy`) attributes
This aligns the UI codebase with the already renamed `chart` module and avoids confusion caused
by outdated naming.
### Remarks
- This PR contains UI-only refactoring and does not change runtime behavior or business logic.
- No backend, API, or data model changes are included.
- Changes were applied incrementally using small, focused commits to simplify review.
Related issues:
- Fixes #3985
- Relates to #4021
PR introduces (a) breaking change(s): **no**
PR introduces (a) deprecation(s): **no**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#3985] Rename remaining data-explorer UI references to chart
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4081:
URL: https://github.com/apache/streampipes/pull/4081#issuecomment-3787703914
Hello there :wave:<br> <br> We noticed that it's been some time since activity occurred on your pull request :thinking:. In order to keep things moving forward, we're marking this PR as _stale_ and giving you 7 days to respond before it's automatically closed :alarm_clock:.<br> <br> Please take a moment to review your pull request and make any necessary updates or changes :man_technologist:. If you need more time or have any questions, please don't hesitate to let us know :speech_balloon:.<br> <br> Thank you for your contributions to our project, and we look forward to hearing back from you soon :pray:.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#3985] Rename remaining data-explorer UI references to chart
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #4081:
URL: https://github.com/apache/streampipes/pull/4081#discussion_r2655615249
##########
ui/src/app/dashboard-shared/components/chart-view/abstract-chart-view.directive.ts:
##########
@@ -58,7 +58,7 @@ export abstract class AbstractChartViewDirective {
widgetsVisible = true;
/**
- * This is the date range (start, end) to view the data and is set in data-explorer.ts
+ * This is the date range (start, end) to view the data and is set in chart.ts
Review Comment:
The comment references "chart.ts" but the actual file is "chart-view.component.ts". The comment should be updated to reference the correct filename.
```suggestion
* This is the date range (start, end) to view the data and is set in chart-view.component.ts
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#3985] Rename remaining data-explorer UI references to chart
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4081:
URL: https://github.com/apache/streampipes/pull/4081#issuecomment-3821298081
Hello there :wave:<br> <br> Unfortunately, we didn't hear back from you regarding your pull request, so we're closing it now. Don't worry, you can always reopen the PR at any time if you wish to continue working on it :raised_hands:.<br> <br> Please note that the branch associated with this pull request will not be deleted, so you can still access your changes and continue to work on them as needed :computer:.<br> <br> Thank you for your contributions to our project, and we hope to see you again soon!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#3985] Rename remaining data-explorer UI references to chart
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #4081: [#3985] Rename remaining data-explorer UI references to chart
URL: https://github.com/apache/streampipes/pull/4081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [#3985] Rename remaining data-explorer UI references to chart
Posted by "Brijesh-Thakkar (via GitHub)" <gi...@apache.org>.
Brijesh-Thakkar commented on code in PR #4081:
URL: https://github.com/apache/streampipes/pull/4081#discussion_r2655619887
##########
ui/src/app/dashboard-shared/components/chart-view/abstract-chart-view.directive.ts:
##########
@@ -58,7 +58,7 @@ export abstract class AbstractChartViewDirective {
widgetsVisible = true;
/**
- * This is the date range (start, end) to view the data and is set in data-explorer.ts
+ * This is the date range (start, end) to view the data and is set in chart.ts
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org