You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2011/08/09 23:36:27 UTC

[jira] [Commented] (HADOOP-7531) Add servlet util methods for handling paths in requests

    [ https://issues.apache.org/jira/browse/HADOOP-7531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081946#comment-13081946 ] 

Daryn Sharp commented on HADOOP-7531:
-------------------------------------

Should the encoding/decoding exceptions really be trapped and subbed with null?  How will the caller know exactly how or why the operation failed?  It seems prone to error as illustrated in the linked jira.  The return value is being +'ed onto a string which will unexpectedly result in "null" being added to the string.

To avoid copy/paste code, would it make sense for {{getDecodedPath}} to call {{URIUtil.decode(getRawPath(request, servletName))}}?

> Add servlet util methods for handling paths in requests 
> --------------------------------------------------------
>
>                 Key: HADOOP-7531
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7531
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 0.23.0
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 0.23.0
>
>         Attachments: hadoop-7531-1.patch
>
>
> Common side of HDFS-2235.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira