You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Thomas Fischer (JIRA)" <de...@myfaces.apache.org> on 2007/09/27 16:10:50 UTC

[jira] Created: (MYFACES-1735) Myfaces 1.2 should provide local copies of web-facesconfig_1_x.dtd

Myfaces 1.2 should provide local copies of  web-facesconfig_1_x.dtd
-------------------------------------------------------------------

                 Key: MYFACES-1735
                 URL: https://issues.apache.org/jira/browse/MYFACES-1735
             Project: MyFaces Core
          Issue Type: Bug
    Affects Versions:  1.2.0
         Environment: using tomahawk 1.1.6
            Reporter: Thomas Fischer


Situation: Tomahawk 1.1.6 is used in a myfaces 1.2.0 application. The computer where the application is run on is not connected to the internet.

Problem: Myfaces refuses to start.

Expected behaviour: Myfaces should start.

Analysis: When debugging, the error is that myfaces cannot resolve the dtd declaration in tomahawk's faces-config.xml file. I do not think this is tomahawk's problem, because tomahawk wants to be myfaces-1.1 compatible. Myfaces should provide the web-facesconfig_1_0.dtd and web-facesconfig_1_1.dtd in its jar.

In a short glance at the code in org.apache.myfaces.config.impl.FacesConfigEntityResolver , it might seem that these resources are still provided:
public InputSource resolveEntity(...)
{
    InputStream stream;
    if (systemId.equals(FACES_CONFIG_1_0_DTD_SYSTEM_ID))
    {
        stream = ClassUtils.getResourceAsStream(FACES_CONFIG_1_0_DTD_RESOURCE);
    }
    else if (systemId.equals(FACES_CONFIG_1_1_DTD_SYSTEM_ID))
    {
        stream = ClassUtils.getResourceAsStream(FACES_CONFIG_1_1_DTD_RESOURCE);
    }
    ....
}
However, the referenced resources (web-facesconfig_1_0.dtd and web-facesconfig_1_1.dtd in the org.apache.myfaces.resource package) are not packaged in any myfaces 1.2 jar. They used to be present in myfaces-impl-1.1.x.jar

Proposed Resolution: provide web-facesconfig_1_0.dtd and web-facesconfig_1_1.dtd in the org.apache.myfaces.resource package in myfaces-impl-1.2.x.jar



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-1735) Myfaces 1.2 should provide local copies of web-facesconfig_1_x.dtd

Posted by "Thomas Fischer (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530733 ] 

Thomas Fischer commented on MYFACES-1735:
-----------------------------------------

Set on "patch provided" because the necessary files are still in the myfaces repository

> Myfaces 1.2 should provide local copies of  web-facesconfig_1_x.dtd
> -------------------------------------------------------------------
>
>                 Key: MYFACES-1735
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1735
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions:  1.2.0
>         Environment: using tomahawk 1.1.6
>            Reporter: Thomas Fischer
>
> Situation: Tomahawk 1.1.6 is used in a myfaces 1.2.0 application. The computer where the application is run on is not connected to the internet.
> Problem: Myfaces refuses to start.
> Expected behaviour: Myfaces should start.
> Analysis: When debugging, the error is that myfaces cannot resolve the dtd declaration in tomahawk's faces-config.xml file. I do not think this is tomahawk's problem, because tomahawk wants to be myfaces-1.1 compatible. Myfaces should provide the web-facesconfig_1_0.dtd and web-facesconfig_1_1.dtd in its jar.
> In a short glance at the code in org.apache.myfaces.config.impl.FacesConfigEntityResolver , it might seem that these resources are still provided:
> public InputSource resolveEntity(...)
> {
>     InputStream stream;
>     if (systemId.equals(FACES_CONFIG_1_0_DTD_SYSTEM_ID))
>     {
>         stream = ClassUtils.getResourceAsStream(FACES_CONFIG_1_0_DTD_RESOURCE);
>     }
>     else if (systemId.equals(FACES_CONFIG_1_1_DTD_SYSTEM_ID))
>     {
>         stream = ClassUtils.getResourceAsStream(FACES_CONFIG_1_1_DTD_RESOURCE);
>     }
>     ....
> }
> However, the referenced resources (web-facesconfig_1_0.dtd and web-facesconfig_1_1.dtd in the org.apache.myfaces.resource package) are not packaged in any myfaces 1.2 jar. They used to be present in myfaces-impl-1.1.x.jar
> Proposed Resolution: provide web-facesconfig_1_0.dtd and web-facesconfig_1_1.dtd in the org.apache.myfaces.resource package in myfaces-impl-1.2.x.jar

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MYFACES-1735) Myfaces 1.2 should provide local copies of web-facesconfig_1_x.dtd

Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Marinschek updated MYFACES-1735:
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2.1-SNAPSHOT
         Assignee: Martin Marinschek
           Status: Resolved  (was: Patch Available)

Hi Thomas,

thanks for looking at this - should be fixed now.

regards,

Martin

> Myfaces 1.2 should provide local copies of  web-facesconfig_1_x.dtd
> -------------------------------------------------------------------
>
>                 Key: MYFACES-1735
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1735
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions:  1.2.0
>         Environment: using tomahawk 1.1.6
>            Reporter: Thomas Fischer
>            Assignee: Martin Marinschek
>             Fix For: 1.2.1-SNAPSHOT
>
>
> Situation: Tomahawk 1.1.6 is used in a myfaces 1.2.0 application. The computer where the application is run on is not connected to the internet.
> Problem: Myfaces refuses to start.
> Expected behaviour: Myfaces should start.
> Analysis: When debugging, the error is that myfaces cannot resolve the dtd declaration in tomahawk's faces-config.xml file. I do not think this is tomahawk's problem, because tomahawk wants to be myfaces-1.1 compatible. Myfaces should provide the web-facesconfig_1_0.dtd and web-facesconfig_1_1.dtd in its jar.
> In a short glance at the code in org.apache.myfaces.config.impl.FacesConfigEntityResolver , it might seem that these resources are still provided:
> public InputSource resolveEntity(...)
> {
>     InputStream stream;
>     if (systemId.equals(FACES_CONFIG_1_0_DTD_SYSTEM_ID))
>     {
>         stream = ClassUtils.getResourceAsStream(FACES_CONFIG_1_0_DTD_RESOURCE);
>     }
>     else if (systemId.equals(FACES_CONFIG_1_1_DTD_SYSTEM_ID))
>     {
>         stream = ClassUtils.getResourceAsStream(FACES_CONFIG_1_1_DTD_RESOURCE);
>     }
>     ....
> }
> However, the referenced resources (web-facesconfig_1_0.dtd and web-facesconfig_1_1.dtd in the org.apache.myfaces.resource package) are not packaged in any myfaces 1.2 jar. They used to be present in myfaces-impl-1.1.x.jar
> Proposed Resolution: provide web-facesconfig_1_0.dtd and web-facesconfig_1_1.dtd in the org.apache.myfaces.resource package in myfaces-impl-1.2.x.jar

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-1735) Myfaces 1.2 should provide local copies of web-facesconfig_1_x.dtd

Posted by "Matt Raible (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542146 ] 

Matt Raible commented on MYFACES-1735:
--------------------------------------

Any chance of getting 1.2.1 released this week to get this fix? ;-)

> Myfaces 1.2 should provide local copies of  web-facesconfig_1_x.dtd
> -------------------------------------------------------------------
>
>                 Key: MYFACES-1735
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1735
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions:  1.2.0
>         Environment: using tomahawk 1.1.6
>            Reporter: Thomas Fischer
>            Assignee: Martin Marinschek
>             Fix For: 1.2.1-SNAPSHOT
>
>
> Situation: Tomahawk 1.1.6 is used in a myfaces 1.2.0 application. The computer where the application is run on is not connected to the internet.
> Problem: Myfaces refuses to start.
> Expected behaviour: Myfaces should start.
> Analysis: When debugging, the error is that myfaces cannot resolve the dtd declaration in tomahawk's faces-config.xml file. I do not think this is tomahawk's problem, because tomahawk wants to be myfaces-1.1 compatible. Myfaces should provide the web-facesconfig_1_0.dtd and web-facesconfig_1_1.dtd in its jar.
> In a short glance at the code in org.apache.myfaces.config.impl.FacesConfigEntityResolver , it might seem that these resources are still provided:
> public InputSource resolveEntity(...)
> {
>     InputStream stream;
>     if (systemId.equals(FACES_CONFIG_1_0_DTD_SYSTEM_ID))
>     {
>         stream = ClassUtils.getResourceAsStream(FACES_CONFIG_1_0_DTD_RESOURCE);
>     }
>     else if (systemId.equals(FACES_CONFIG_1_1_DTD_SYSTEM_ID))
>     {
>         stream = ClassUtils.getResourceAsStream(FACES_CONFIG_1_1_DTD_RESOURCE);
>     }
>     ....
> }
> However, the referenced resources (web-facesconfig_1_0.dtd and web-facesconfig_1_1.dtd in the org.apache.myfaces.resource package) are not packaged in any myfaces 1.2 jar. They used to be present in myfaces-impl-1.1.x.jar
> Proposed Resolution: provide web-facesconfig_1_0.dtd and web-facesconfig_1_1.dtd in the org.apache.myfaces.resource package in myfaces-impl-1.2.x.jar

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MYFACES-1735) Myfaces 1.2 should provide local copies of web-facesconfig_1_x.dtd

Posted by "Thomas Fischer (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Fischer updated MYFACES-1735:
------------------------------------

    Status: Patch Available  (was: Open)

> Myfaces 1.2 should provide local copies of  web-facesconfig_1_x.dtd
> -------------------------------------------------------------------
>
>                 Key: MYFACES-1735
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1735
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions:  1.2.0
>         Environment: using tomahawk 1.1.6
>            Reporter: Thomas Fischer
>
> Situation: Tomahawk 1.1.6 is used in a myfaces 1.2.0 application. The computer where the application is run on is not connected to the internet.
> Problem: Myfaces refuses to start.
> Expected behaviour: Myfaces should start.
> Analysis: When debugging, the error is that myfaces cannot resolve the dtd declaration in tomahawk's faces-config.xml file. I do not think this is tomahawk's problem, because tomahawk wants to be myfaces-1.1 compatible. Myfaces should provide the web-facesconfig_1_0.dtd and web-facesconfig_1_1.dtd in its jar.
> In a short glance at the code in org.apache.myfaces.config.impl.FacesConfigEntityResolver , it might seem that these resources are still provided:
> public InputSource resolveEntity(...)
> {
>     InputStream stream;
>     if (systemId.equals(FACES_CONFIG_1_0_DTD_SYSTEM_ID))
>     {
>         stream = ClassUtils.getResourceAsStream(FACES_CONFIG_1_0_DTD_RESOURCE);
>     }
>     else if (systemId.equals(FACES_CONFIG_1_1_DTD_SYSTEM_ID))
>     {
>         stream = ClassUtils.getResourceAsStream(FACES_CONFIG_1_1_DTD_RESOURCE);
>     }
>     ....
> }
> However, the referenced resources (web-facesconfig_1_0.dtd and web-facesconfig_1_1.dtd in the org.apache.myfaces.resource package) are not packaged in any myfaces 1.2 jar. They used to be present in myfaces-impl-1.1.x.jar
> Proposed Resolution: provide web-facesconfig_1_0.dtd and web-facesconfig_1_1.dtd in the org.apache.myfaces.resource package in myfaces-impl-1.2.x.jar

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.