You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/28 02:59:10 UTC

[GitHub] [spark] ulysses-you commented on a change in pull request #31372: [SPARK-34272][SQL] Pretty SQL should check NonSQLExpression

ulysses-you commented on a change in pull request #31372:
URL: https://github.com/apache/spark/pull/31372#discussion_r565787380



##########
File path: sql/core/src/test/resources/sql-tests/results/udf/postgreSQL/udf-aggregates_part1.sql.out
##########
@@ -109,7 +109,7 @@ struct<udf(var_samp(b)):double>
 -- !query
 SELECT udf(stddev_pop(CAST(b AS Decimal(38,0)))) FROM aggtest
 -- !query schema
-struct<udf(stddev_pop(CAST(b AS DECIMAL(38,0)))):double>
+struct<udf(stddev_pop(ansi_cast(b as decimal(38,0)))):double>

Review comment:
       The difference is introduced by `NonSQLExpression.sql` which use `toString` instead of `sql` and `Cast` has different implementation between `toString` and `sql`. Then the change happened.  Is this get your point ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org