[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #34691: GH-34639: [C++] Support RecordBatch::FromStructArray even if struct array has nulls/offsets

["jorisvandenbossche (via GitHub)" <gi...@apache.org>]

jorisvandenbossche commented on code in PR #34691:
URL: https://github.com/apache/arrow/pull/34691#discussion_r1146291062


##########
cpp/src/arrow/record_batch.h:
##########
@@ -82,10 +82,15 @@ class ARROW_EXPORT RecordBatch {
   /// \brief Construct record batch from struct array
   ///
   /// This constructs a record batch using the child arrays of the given
-  /// array, which must be a struct array.  Note that the struct array's own
-  /// null bitmap is not reflected in the resulting record batch.
+  /// array, which must be a struct array.
+  ///
+  /// \param[in] pool the memory pool to allocate new validity bitmaps

Review Comment:
   Because you added the `pool` param documentation, it now seems to complain that `array` is not documented



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org