[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1251: MINIFICPP-1636 - Use std::filesystem instead of boost and platform specific implementations

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #1251:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1251#discussion_r793878534



##########
File path: libminifi/include/utils/file/FileUtils.h
##########
@@ -25,14 +25,7 @@
 #include <utility>
 #include <vector>
 
-#ifdef USE_BOOST
-#include <dirent.h>
-#include <boost/filesystem.hpp>
-#include <boost/system/error_code.hpp>
-#ifndef WIN32
-#include <sys/stat.h>
-#endif
-#else
+#ifndef USE_BOOST

Review comment:
       We can now remove this check and just assume that it's not defined. We will eventually get rid of all boost code from libminifi.

##########
File path: docker/DockerVerify.sh
##########
@@ -44,11 +44,11 @@ echo "Installing test dependencies..." 1>&2
 # hint include/library paths if homewbrew is in use
 if brew list 2> /dev/null | grep openssl > /dev/null 2>&1; then
   echo "Using homebrew paths for openssl" 1>&2
-  LDFLAGS="-L$(brew --prefix openssl)/lib"
+  LDFLAGS="-L$(brew --prefix openssl@1.1)/lib"
   export LDFLAGS
-  CFLAGS="-I$(brew --prefix openssl)/include"
+  CFLAGS="-I$(brew --prefix openssl@1.1)/include"
   export CFLAGS
-  SWIG_FEATURES="-cpperraswarn -includeall -I$(brew --prefix openssl)/include"
+  SWIG_FEATURES="-cpperraswarn -includeall -I$(brew --prefix openssl@1.1)/include"

Review comment:
       Why is this version pin? Was something not working on mac?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org