You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/24 16:49:04 UTC

[GitHub] [airflow] mik-laj commented on pull request #15509: Remove condition field from depends_on for Docker Compose version 3 file.

mik-laj commented on pull request #15509:
URL: https://github.com/apache/airflow/pull/15509#issuecomment-826120396


   Docker Compose supports condition field.  This prevents the container from running until the service reports that it is healthy. 
   https://github.com/docker/compose/blob/c81046aac0ce1360f1bab64368f9a318c593d82a/compose/config/compose_spec.json#L184-L195
   https://github.com/docker/compose/blob/0bea52b18dda3de8c28fcfb0c80cc08b8950645e/compose/service.py#L756-L757
   It is also supported by compose spec:
   https://github.com/compose-spec/compose-spec/blob/b7fb5b65fff19651ecdb2d4d3232b01fb6866f70/schema/compose-spec.json#L184-L196
   To me, it looks like an issue in the docker documentation.
   
   See also: https://github.com/apache/airflow/pull/13446
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org