You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/06 11:00:36 UTC

[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #1878: Crypto (JCE) native support

jamesnetherton opened a new pull request #1878:
URL: https://github.com/apache/camel-quarkus/pull/1878


   Fixes #1593


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] aldettinger commented on pull request #1878: Crypto (JCE) native support

Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #1878:
URL: https://github.com/apache/camel-quarkus/pull/1878#issuecomment-704762363


   Good PR @jamesnetherton . Just a note that I have spotted this [guy](https://github.com/apache/camel/blob/master/components/camel-crypto/src/main/java/org/apache/camel/component/crypto/processor/DigitalSignatureProcessor.java#L91), I wonder if it's covered.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton merged pull request #1878: Crypto (JCE) native support

Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #1878:
URL: https://github.com/apache/camel-quarkus/pull/1878


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on pull request #1878: Crypto (JCE) native support

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1878:
URL: https://github.com/apache/camel-quarkus/pull/1878#issuecomment-704782978


   I raised https://github.com/apache/camel-quarkus/issues/1881.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on pull request #1878: Crypto (JCE) native support

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1878:
URL: https://github.com/apache/camel-quarkus/pull/1878#issuecomment-704785546


   > It would be nice to have a README with the info how the pgp and jks files were created for the case that we need to alter them in the future
   
   I stole them from the Camel tests :-). But I can see if I can put something together.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on pull request #1878: Crypto (JCE) native support

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1878:
URL: https://github.com/apache/camel-quarkus/pull/1878#issuecomment-704777694


   > Just a note that I have spotted this [guy](https://github.com/apache/camel/blob/master/components/camel-crypto/src/main/java/org/apache/camel/component/crypto/processor/DigitalSignatureProcessor.java#L91), I wonder if it's covered.
   
   Good spot! Kind of a weird way to clear headers :smiley:. Unsurprisingly, `getFields` returns an empty array in native mode.
   
   I can follow up with a workaround and then fix properly on the Camel side.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org