You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/04/23 22:34:33 UTC
[Impala-ASF-CR] Fix critique-gerrit-review to ignore shell/ext-py
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13093
Change subject: Fix critique-gerrit-review to ignore shell/ext-py
......................................................................
Fix critique-gerrit-review to ignore shell/ext-py
See https://gerrit.cloudera.org/#/c/12884/ for an example of the bot
misbehaving
Change-Id: I76f954a8985fba2f04be34499d8c8723facd0e27
---
M bin/jenkins/critique-gerrit-review.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/13093/1
--
To view, visit http://gerrit.cloudera.org:8080/13093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I76f954a8985fba2f04be34499d8c8723facd0e27
Gerrit-Change-Number: 13093
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Fix critique-gerrit-review to ignore shell/ext-py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13093 )
Change subject: Fix critique-gerrit-review to ignore shell/ext-py
......................................................................
Fix critique-gerrit-review to ignore shell/ext-py
See https://gerrit.cloudera.org/#/c/12884/ for an example of the bot
misbehaving
Change-Id: I76f954a8985fba2f04be34499d8c8723facd0e27
Reviewed-on: http://gerrit.cloudera.org:8080/13093
Reviewed-by: Fredy Wijaya <fw...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/jenkins/critique-gerrit-review.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Fredy Wijaya: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I76f954a8985fba2f04be34499d8c8723facd0e27
Gerrit-Change-Number: 13093
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] Fix critique-gerrit-review to ignore shell/ext-py
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13093 )
Change subject: Fix critique-gerrit-review to ignore shell/ext-py
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76f954a8985fba2f04be34499d8c8723facd0e27
Gerrit-Change-Number: 13093
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Apr 2019 22:41:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix critique-gerrit-review to ignore shell/ext-py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13093 )
Change subject: Fix critique-gerrit-review to ignore shell/ext-py
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2870/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76f954a8985fba2f04be34499d8c8723facd0e27
Gerrit-Change-Number: 13093
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Apr 2019 23:24:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix critique-gerrit-review to ignore shell/ext-py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13093 )
Change subject: Fix critique-gerrit-review to ignore shell/ext-py
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4055/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76f954a8985fba2f04be34499d8c8723facd0e27
Gerrit-Change-Number: 13093
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Apr 2019 22:35:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Fix critique-gerrit-review to ignore shell/ext-py
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13093 )
Change subject: Fix critique-gerrit-review to ignore shell/ext-py
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76f954a8985fba2f04be34499d8c8723facd0e27
Gerrit-Change-Number: 13093
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 24 Apr 2019 03:52:12 +0000
Gerrit-HasComments: No