You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/03 13:58:00 UTC
[jira] [Work logged] (BEAM-6030) Remove Metrics Sinks specific
methods from PipelineOptions
[ https://issues.apache.org/jira/browse/BEAM-6030?focusedWorklogId=180683&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-180683 ]
ASF GitHub Bot logged work on BEAM-6030:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jan/19 13:57
Start Date: 03/Jan/19 13:57
Worklog Time Spent: 10m
Work Description: echauchot commented on pull request #7400: [BEAM-6030] Split metrics related options out of PipelineOptions
URL: https://github.com/apache/beam/pull/7400
I chose to put all metrics related options in a single class (as native spark does) rather than extracting only sink options (in either one class or one per sink) because it would have seemed strange to separate sink class choice from its configuration.
R: @kennknowles
------------------------
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 180683)
Time Spent: 10m
Remaining Estimate: 0h
> Remove Metrics Sinks specific methods from PipelineOptions
> ----------------------------------------------------------
>
> Key: BEAM-6030
> URL: https://issues.apache.org/jira/browse/BEAM-6030
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Affects Versions: 2.8.0
> Reporter: Federico Mendez
> Assignee: Etienne Chauchot
> Priority: Critical
> Time Spent: 10m
> Remaining Estimate: 0h
>
> https://issues.apache.org/jira/browse/BEAM-4553 introduced methods in the base PipelineOptions interfaces that are specific to Graphite get/setMetricsGraphiteHost and get/setMetricsGraphitePort.
> I'd suggest to those elements should be moved to a PipelineOptionsGraphiteMetricsSink interfaces to avoid having technology specific methods in base classes/interfaces.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)