[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1457: [CELEBORN-552] Add HeartBeat between the client and worker to avoid i…

["RexXiong (via GitHub)" <gi...@apache.org>]

RexXiong commented on code in PR #1457:
URL: https://github.com/apache/incubator-celeborn/pull/1457#discussion_r1176544859


##########
common/src/main/java/org/apache/celeborn/common/network/util/TransportFrameDecoder.java:
##########
@@ -132,7 +134,7 @@ private ByteBuf decodeNext() {
     nextFrameSize = UNKNOWN_FRAME_SIZE;
 
     Preconditions.checkArgument(frameSize < MAX_FRAME_SIZE, "Too large frame: %s", frameSize);
-    Preconditions.checkArgument(frameSize > 0, "Frame length should be positive: %s", frameSize);
+    Preconditions.checkArgument(frameSize >= 0, "Frame length should be positive: %s", frameSize);

Review Comment:
   No need to be positive now, can change comments



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org