You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "RABI K.C." <ra...@gmail.com> on 2019/10/23 16:37:15 UTC
[VOTE] KIP-530: Consider renaming 'UsePreviousTimeOnInvalidTimeStamp'
class to 'UsePartitionTimeOnInvalidTimeStamp'
Hello All,
As per the discussion I want to call for a vote to go forward with the
changes mentioned in KIP-530.
Links:
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=130028807
https://issues.apache.org/jira/browse/KAFKA-8953
With Best Regards,
Rabi Kumar K C
Re: [VOTE] KIP-530: Consider renaming 'UsePreviousTimeOnInvalidTimeStamp'
class to 'UsePartitionTimeOnInvalidTimeStamp'
Posted by "RABI K.C." <ra...@gmail.com>.
Hello All,
Calling this vote to a close with +3 binding (Matthias J. Sax, Guozhang
Wang, Bill Bejeck) and +1 non-binding (Bruno Cadonna).
Thank You all for the discussion and votes. Will be opening a PR for this
soon
With Best Regards,
Rabi Kumar K C
On Fri, Oct 25, 2019 at 10:47 AM RABI K.C. <ra...@gmail.com> wrote:
> Hi Bill,
>
> Yes we will deprecate 'UsePreviousTimeOnInvalidTimeStamp' and then add
> 'UsePartitionOnInvalidTimeStamp'.
>
> With Best Regards,
> Rabi Kumar K C
>
> On Thu, Oct 24, 2019 at 5:32 PM Guozhang Wang <wa...@gmail.com> wrote:
>
>> +1 (binding).
>>
>>
>> Guozhang
>>
>> On Thu, Oct 24, 2019 at 8:22 AM Bill Bejeck <bb...@gmail.com> wrote:
>>
>> > Hi Rabi,
>> >
>> > Thanks for the KIP.
>> > Just to be clear, we're going to deprecate
>> > `UsePreviousTimeOnInvalidTimeStamp`
>> > and add `UsePartitionOnInvalidTimeStamp` class correct?
>> >
>> > Otherwise, it's a +1 (binding) from me.
>> >
>> > -Bill
>> >
>> > On Thu, Oct 24, 2019 at 8:09 AM Bruno Cadonna <br...@confluent.io>
>> wrote:
>> >
>> > > Hi Rabi,
>> > >
>> > > Thank you for the KIP!
>> > >
>> > > +1 (non-binding)
>> > >
>> > > Best,
>> > > Bruno
>> > >
>> > > On Thu, Oct 24, 2019 at 8:42 AM Matthias J. Sax <
>> matthias@confluent.io>
>> > > wrote:
>> > > >
>> > > > +1 (binding)
>> > > >
>> > > > Thanks for the KIP!
>> > > >
>> > > > -Matthias
>> > > >
>> > > > On 10/23/19 9:37 AM, RABI K.C. wrote:
>> > > > > Hello All,
>> > > > >
>> > > > > As per the discussion I want to call for a vote to go forward with
>> > the
>> > > > > changes mentioned in KIP-530.
>> > > > >
>> > > > > Links:
>> > > > >
>> > >
>> >
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=130028807
>> > > > > https://issues.apache.org/jira/browse/KAFKA-8953
>> > > > >
>> > > > > With Best Regards,
>> > > > > Rabi Kumar K C
>> > > > >
>> > > >
>> > >
>> >
>>
>>
>> --
>> -- Guozhang
>>
>
Re: [VOTE] KIP-530: Consider renaming 'UsePreviousTimeOnInvalidTimeStamp'
class to 'UsePartitionTimeOnInvalidTimeStamp'
Posted by "RABI K.C." <ra...@gmail.com>.
Hi Bill,
Yes we will deprecate 'UsePreviousTimeOnInvalidTimeStamp' and then add
'UsePartitionOnInvalidTimeStamp'.
With Best Regards,
Rabi Kumar K C
On Thu, Oct 24, 2019 at 5:32 PM Guozhang Wang <wa...@gmail.com> wrote:
> +1 (binding).
>
>
> Guozhang
>
> On Thu, Oct 24, 2019 at 8:22 AM Bill Bejeck <bb...@gmail.com> wrote:
>
> > Hi Rabi,
> >
> > Thanks for the KIP.
> > Just to be clear, we're going to deprecate
> > `UsePreviousTimeOnInvalidTimeStamp`
> > and add `UsePartitionOnInvalidTimeStamp` class correct?
> >
> > Otherwise, it's a +1 (binding) from me.
> >
> > -Bill
> >
> > On Thu, Oct 24, 2019 at 8:09 AM Bruno Cadonna <br...@confluent.io>
> wrote:
> >
> > > Hi Rabi,
> > >
> > > Thank you for the KIP!
> > >
> > > +1 (non-binding)
> > >
> > > Best,
> > > Bruno
> > >
> > > On Thu, Oct 24, 2019 at 8:42 AM Matthias J. Sax <matthias@confluent.io
> >
> > > wrote:
> > > >
> > > > +1 (binding)
> > > >
> > > > Thanks for the KIP!
> > > >
> > > > -Matthias
> > > >
> > > > On 10/23/19 9:37 AM, RABI K.C. wrote:
> > > > > Hello All,
> > > > >
> > > > > As per the discussion I want to call for a vote to go forward with
> > the
> > > > > changes mentioned in KIP-530.
> > > > >
> > > > > Links:
> > > > >
> > >
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=130028807
> > > > > https://issues.apache.org/jira/browse/KAFKA-8953
> > > > >
> > > > > With Best Regards,
> > > > > Rabi Kumar K C
> > > > >
> > > >
> > >
> >
>
>
> --
> -- Guozhang
>
Re: [VOTE] KIP-530: Consider renaming 'UsePreviousTimeOnInvalidTimeStamp'
class to 'UsePartitionTimeOnInvalidTimeStamp'
Posted by Guozhang Wang <wa...@gmail.com>.
+1 (binding).
Guozhang
On Thu, Oct 24, 2019 at 8:22 AM Bill Bejeck <bb...@gmail.com> wrote:
> Hi Rabi,
>
> Thanks for the KIP.
> Just to be clear, we're going to deprecate
> `UsePreviousTimeOnInvalidTimeStamp`
> and add `UsePartitionOnInvalidTimeStamp` class correct?
>
> Otherwise, it's a +1 (binding) from me.
>
> -Bill
>
> On Thu, Oct 24, 2019 at 8:09 AM Bruno Cadonna <br...@confluent.io> wrote:
>
> > Hi Rabi,
> >
> > Thank you for the KIP!
> >
> > +1 (non-binding)
> >
> > Best,
> > Bruno
> >
> > On Thu, Oct 24, 2019 at 8:42 AM Matthias J. Sax <ma...@confluent.io>
> > wrote:
> > >
> > > +1 (binding)
> > >
> > > Thanks for the KIP!
> > >
> > > -Matthias
> > >
> > > On 10/23/19 9:37 AM, RABI K.C. wrote:
> > > > Hello All,
> > > >
> > > > As per the discussion I want to call for a vote to go forward with
> the
> > > > changes mentioned in KIP-530.
> > > >
> > > > Links:
> > > >
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=130028807
> > > > https://issues.apache.org/jira/browse/KAFKA-8953
> > > >
> > > > With Best Regards,
> > > > Rabi Kumar K C
> > > >
> > >
> >
>
--
-- Guozhang
Re: [VOTE] KIP-530: Consider renaming 'UsePreviousTimeOnInvalidTimeStamp'
class to 'UsePartitionTimeOnInvalidTimeStamp'
Posted by Bill Bejeck <bb...@gmail.com>.
Hi Rabi,
Thanks for the KIP.
Just to be clear, we're going to deprecate `UsePreviousTimeOnInvalidTimeStamp`
and add `UsePartitionOnInvalidTimeStamp` class correct?
Otherwise, it's a +1 (binding) from me.
-Bill
On Thu, Oct 24, 2019 at 8:09 AM Bruno Cadonna <br...@confluent.io> wrote:
> Hi Rabi,
>
> Thank you for the KIP!
>
> +1 (non-binding)
>
> Best,
> Bruno
>
> On Thu, Oct 24, 2019 at 8:42 AM Matthias J. Sax <ma...@confluent.io>
> wrote:
> >
> > +1 (binding)
> >
> > Thanks for the KIP!
> >
> > -Matthias
> >
> > On 10/23/19 9:37 AM, RABI K.C. wrote:
> > > Hello All,
> > >
> > > As per the discussion I want to call for a vote to go forward with the
> > > changes mentioned in KIP-530.
> > >
> > > Links:
> > >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=130028807
> > > https://issues.apache.org/jira/browse/KAFKA-8953
> > >
> > > With Best Regards,
> > > Rabi Kumar K C
> > >
> >
>
Re: [VOTE] KIP-530: Consider renaming 'UsePreviousTimeOnInvalidTimeStamp'
class to 'UsePartitionTimeOnInvalidTimeStamp'
Posted by Bruno Cadonna <br...@confluent.io>.
Hi Rabi,
Thank you for the KIP!
+1 (non-binding)
Best,
Bruno
On Thu, Oct 24, 2019 at 8:42 AM Matthias J. Sax <ma...@confluent.io> wrote:
>
> +1 (binding)
>
> Thanks for the KIP!
>
> -Matthias
>
> On 10/23/19 9:37 AM, RABI K.C. wrote:
> > Hello All,
> >
> > As per the discussion I want to call for a vote to go forward with the
> > changes mentioned in KIP-530.
> >
> > Links:
> > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=130028807
> > https://issues.apache.org/jira/browse/KAFKA-8953
> >
> > With Best Regards,
> > Rabi Kumar K C
> >
>
Re: [VOTE] KIP-530: Consider renaming
'UsePreviousTimeOnInvalidTimeStamp' class to
'UsePartitionTimeOnInvalidTimeStamp'
Posted by "Matthias J. Sax" <ma...@confluent.io>.
+1 (binding)
Thanks for the KIP!
-Matthias
On 10/23/19 9:37 AM, RABI K.C. wrote:
> Hello All,
>
> As per the discussion I want to call for a vote to go forward with the
> changes mentioned in KIP-530.
>
> Links:
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=130028807
> https://issues.apache.org/jira/browse/KAFKA-8953
>
> With Best Regards,
> Rabi Kumar K C
>