You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/11/13 18:41:14 UTC
[GitHub] [incubator-ratis] szetszwo opened a new pull request #276: RATIS-1155. Add a builder for DataStreamReplyByteBuffer.
szetszwo opened a new pull request #276:
URL: https://github.com/apache/incubator-ratis/pull/276
See https://issues.apache.org/jira/browse/RATIS-1155
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang closed pull request #276: RATIS-1155. Add a builder for DataStreamReplyByteBuffer.
Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #276:
URL: https://github.com/apache/incubator-ratis/pull/276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] amaliujia commented on pull request #276: RATIS-1155. Add a builder for DataStreamReplyByteBuffer.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #276:
URL: https://github.com/apache/incubator-ratis/pull/276#issuecomment-727158176
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang commented on pull request #276: RATIS-1155. Add a builder for DataStreamReplyByteBuffer.
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #276:
URL: https://github.com/apache/incubator-ratis/pull/276#issuecomment-727291774
@szetszwo Thanks the patch. @amaliujia Thanks for review. I have merged it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang merged pull request #276: RATIS-1155. Add a builder for DataStreamReplyByteBuffer.
Posted by GitBox <gi...@apache.org>.
runzhiwang merged pull request #276:
URL: https://github.com/apache/incubator-ratis/pull/276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang closed pull request #276: RATIS-1155. Add a builder for DataStreamReplyByteBuffer.
Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #276:
URL: https://github.com/apache/incubator-ratis/pull/276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] amaliujia commented on a change in pull request #276: RATIS-1155. Add a builder for DataStreamReplyByteBuffer.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #276:
URL: https://github.com/apache/incubator-ratis/pull/276#discussion_r523244384
##########
File path: ratis-client/src/main/java/org/apache/ratis/client/impl/OrderedStreamAsync.java
##########
@@ -43,8 +43,8 @@
private final long seqNum;
private final CompletableFuture<DataStreamReply> replyFuture = new CompletableFuture<>();
- DataStreamWindowRequest(long streamId, long offset, ByteBuffer data, long seqNum, Type type){
- super(streamId, offset, data, type);
+ DataStreamWindowRequest(Type type, long streamId, long offset, ByteBuffer data, long seqNum) {
Review comment:
I am ok though if the answer is just personal preference :) just want to make sure I am not missing something important.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] szetszwo commented on a change in pull request #276: RATIS-1155. Add a builder for DataStreamReplyByteBuffer.
Posted by GitBox <gi...@apache.org>.
szetszwo commented on a change in pull request #276:
URL: https://github.com/apache/incubator-ratis/pull/276#discussion_r523363738
##########
File path: ratis-client/src/main/java/org/apache/ratis/client/impl/OrderedStreamAsync.java
##########
@@ -43,8 +43,8 @@
private final long seqNum;
private final CompletableFuture<DataStreamReply> replyFuture = new CompletableFuture<>();
- DataStreamWindowRequest(long streamId, long offset, ByteBuffer data, long seqNum, Type type){
- super(streamId, offset, data, type);
+ DataStreamWindowRequest(Type type, long streamId, long offset, ByteBuffer data, long seqNum) {
Review comment:
`Type type, long streamId, long offset` should be put together in the same order. It will be consistent throughout the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] amaliujia commented on a change in pull request #276: RATIS-1155. Add a builder for DataStreamReplyByteBuffer.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #276:
URL: https://github.com/apache/incubator-ratis/pull/276#discussion_r523238469
##########
File path: ratis-client/src/main/java/org/apache/ratis/client/impl/OrderedStreamAsync.java
##########
@@ -43,8 +43,8 @@
private final long seqNum;
private final CompletableFuture<DataStreamReply> replyFuture = new CompletableFuture<>();
- DataStreamWindowRequest(long streamId, long offset, ByteBuffer data, long seqNum, Type type){
- super(streamId, offset, data, type);
+ DataStreamWindowRequest(Type type, long streamId, long offset, ByteBuffer data, long seqNum) {
Review comment:
Why choose to reorder parameters? if don't do so, this PR will be smaller?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang commented on pull request #276: RATIS-1155. Add a builder for DataStreamReplyByteBuffer.
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #276:
URL: https://github.com/apache/incubator-ratis/pull/276#issuecomment-727287180
reopen pr to trigger ci
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org