You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/03/25 16:15:19 UTC

[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #2382: dsl: support for kotlin dsl

jamesnetherton opened a new pull request #2382:
URL: https://github.com/apache/camel-quarkus/pull/2382


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2382: dsl: support for kotlin dsl

Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2382:
URL: https://github.com/apache/camel-quarkus/pull/2382#discussion_r601845203



##########
File path: extensions-jvm/kotlin-dsl/runtime/pom.xml
##########
@@ -0,0 +1,113 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to You under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+
+         http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+    <parent>
+        <groupId>org.apache.camel.quarkus</groupId>
+        <artifactId>camel-quarkus-kotlin-dsl-parent</artifactId>
+        <version>1.8.0-SNAPSHOT</version>
+        <relativePath>../pom.xml</relativePath>
+    </parent>
+
+    <artifactId>camel-quarkus-kotlin-dsl</artifactId>
+    <name>Camel Quarkus :: Kotlin DSL :: Runtime</name>
+    <description>Support for parsing Kotlin route definitions at runtime</description>
+
+    <properties>
+        <camel.quarkus.jvmSince>1.9.0</camel.quarkus.jvmSince>

Review comment:
       Let me cherry-pick this to my branch and fix there.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga commented on pull request #2382: dsl: support for kotlin dsl

Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2382:
URL: https://github.com/apache/camel-quarkus/pull/2382#issuecomment-807505768


   Cherry-picking to #2371


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga closed pull request #2382: dsl: support for kotlin dsl

Posted by GitBox <gi...@apache.org>.
ppalaga closed pull request #2382:
URL: https://github.com/apache/camel-quarkus/pull/2382


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2382: dsl: support for kotlin dsl

Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2382:
URL: https://github.com/apache/camel-quarkus/pull/2382#discussion_r601842283



##########
File path: extensions-jvm/kotlin-dsl/runtime/pom.xml
##########
@@ -0,0 +1,113 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to You under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+
+         http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+    <parent>
+        <groupId>org.apache.camel.quarkus</groupId>
+        <artifactId>camel-quarkus-kotlin-dsl-parent</artifactId>
+        <version>1.8.0-SNAPSHOT</version>
+        <relativePath>../pom.xml</relativePath>
+    </parent>
+
+    <artifactId>camel-quarkus-kotlin-dsl</artifactId>
+    <name>Camel Quarkus :: Kotlin DSL :: Runtime</name>
+    <description>Support for parsing Kotlin route definitions at runtime</description>
+
+    <properties>
+        <camel.quarkus.jvmSince>1.9.0</camel.quarkus.jvmSince>

Review comment:
       ```suggestion
           <camel.quarkus.jvmSince>1.8.0</camel.quarkus.jvmSince>
   ```
   
   and regen the docs




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org