You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:11:48 UTC
[GitHub] [airflow] faihegberg opened a new pull request #12057: Correct failure message in sql_sensor.py.
faihegberg opened a new pull request #12057:
URL: https://github.com/apache/airflow/pull/12057
An `AirFlowException` in `sql_sensor.py` is formatting its message as a success instead of a failure. This PR resolves the issue by correcting the message to indicate a failure, and adjusting tests which should reach this message to also check the message itself instead of just checking whether this Exception occurred.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12057: Correct failure message in sql_sensor.py.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12057:
URL: https://github.com/apache/airflow/pull/12057#issuecomment-721435311
[The Workflow run](https://github.com/apache/airflow/actions/runs/344559101) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG merged pull request #12057: Correct failure message in sql_sensor.py.
Posted by GitBox <gi...@apache.org>.
XD-DENG merged pull request #12057:
URL: https://github.com/apache/airflow/pull/12057
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12057: Correct failure message in sql_sensor.py.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12057:
URL: https://github.com/apache/airflow/pull/12057#issuecomment-721446566
[The Workflow run](https://github.com/apache/airflow/actions/runs/344599098) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #12057: Correct failure message in sql_sensor.py.
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #12057:
URL: https://github.com/apache/airflow/pull/12057#issuecomment-721439566
Can you please rebased your PR on latest Master since we have applied [Black](https://github.com/apache/airflow/commit/4e8f9cc8d02b29c325b8a5a76b4837671bdf5f68) and [PyUpgrade](https://github.com/apache/airflow/commit/8c42cf1b00c90f0d7f11b8a3a455381de8e003c5) on Master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12057: Correct failure message in sql_sensor.py.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12057:
URL: https://github.com/apache/airflow/pull/12057#issuecomment-721088942
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #12057: Correct failure message in sql_sensor.py.
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #12057:
URL: https://github.com/apache/airflow/pull/12057#issuecomment-721089521
Thanks @faihegberg for the PR.
As the bot msg above suggested, please rebase to the latest master, and we will merge this once the CI after your rebasing succeeds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org