You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/11/10 08:56:42 UTC
[GitHub] [fineract] taskain7 opened a new pull request, #2738: [FINERACT-1678] Loan COB - skip non-owned locked loan accounts
taskain7 opened a new pull request, #2738:
URL: https://github.com/apache/fineract/pull/2738
## Description
Loan COB processing should skip loan accounts that are already hard locked or already processed by other COB processing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics merged pull request #2738: [FINERACT-1678] Loan COB - skip non-owned locked loan accounts
Posted by GitBox <gi...@apache.org>.
galovics merged PR #2738:
URL: https://github.com/apache/fineract/pull/2738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #2738: [FINERACT-1678] Loan COB - skip non-owned locked loan accounts
Posted by GitBox <gi...@apache.org>.
adamsaghy commented on code in PR #2738:
URL: https://github.com/apache/fineract/pull/2738#discussion_r1020345529
##########
fineract-provider/src/test/java/org/apache/fineract/cob/loan/ApplyLoanLockTaskletStepDefinitions.java:
##########
@@ -58,11 +58,10 @@ public ApplyLoanLockTaskletStepDefinitions() {
if ("error".equals(action)) {
lenient().when(this.accountLockRepository.findAllByLoanIdIn(Mockito.anyList())).thenThrow(new RuntimeException("fail"));
} else {
- LoanAccountLock lock1 = new LoanAccountLock(1L, LockOwner.LOAN_COB_CHUNK_PROCESSING);
Review Comment:
Why did you modified this test? Was it doing something poorly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org