[GitHub] incubator-rya pull request #305: Rya 135 collection name

[kchilton2 <gi...@git.apache.org>]

Github user kchilton2 commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/305#discussion_r230497599
  
    --- Diff: dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/MongoDBRdfConfiguration.java ---
    @@ -35,19 +35,17 @@
      * A {@link RdfCloudTripleStoreConfiguration} that configures how Rya connects to a MongoDB Rya triple store.
      */
     public class MongoDBRdfConfiguration extends RdfCloudTripleStoreConfiguration {
    +    public static final String RYA_TRIPLES_COLLECTION = "rya_triples";
     
         // MongoDB Server connection values.
         public static final String MONGO_HOSTNAME = "mongo.db.instance";
         public static final String MONGO_PORT = "mongo.db.port";
     
         // MongoDB Database values.
    -    public static final String MONGO_DB_NAME = "mongo.db.name";
    +    public static final String RYA_INSTANCE_NAME = "mongo.db.name";
    --- End diff --
    
    I don't think this field should be renamed. It's still the Mongo DB Name. Elsewhere in the code we should decide that the rya instance name also happens to be the db name. If this is in fact just the instance name, and the DB name isn't allowed to be configured anymore, then the field's value shouldn't be "mongo.db.name" anymore.


---