[GitHub] [flink] wanglijie95 commented on a diff in pull request #20322: [FLINK-28585][runtime] Ensure all the concurrent executions of SpeculativeExecutionVertex to share the same input splits

[GitBox <gi...@apache.org>]

wanglijie95 commented on code in PR #20322:
URL: https://github.com/apache/flink/pull/20322#discussion_r928369221


##########
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/SpeculativeExecutionVertexTest.java:
##########
@@ -204,33 +212,46 @@ void testArchiveNonFailedExecutionWithArchiveFailedExecutionMethod() {
     }
 
     @Test
-    void testGetExecutionState() throws Exception {
-        final SpeculativeExecutionVertex ev = createSpeculativeExecutionVertex();
+    public void testGetNextInputSplit() throws Exception {

Review Comment:
   public is not needed



##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/SpeculativeExecutionVertex.java:
##########
@@ -46,6 +48,8 @@ public class SpeculativeExecutionVertex extends ExecutionVertex {
 
     private int originalAttemptNumber;
 
+    final Map<Integer, Integer> nextInputSplitIndexToConsumeByAttempts;

Review Comment:
   This map should be clear when `resetForNewExecution`



##########
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/SpeculativeExecutionVertexTest.java:
##########
@@ -204,33 +212,46 @@ void testArchiveNonFailedExecutionWithArchiveFailedExecutionMethod() {
     }
 
     @Test
-    void testGetExecutionState() throws Exception {
-        final SpeculativeExecutionVertex ev = createSpeculativeExecutionVertex();
+    public void testGetNextInputSplit() throws Exception {

Review Comment:
   Why remove `testGetExecutionState` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org