You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Gary Dusbabek (JIRA)" <ji...@apache.org> on 2009/12/23 20:08:29 UTC
[jira] Created: (CASSANDRA-652) RowMutations are being serialized
for the commit log during commit log recovery. This is wasteul.
RowMutations are being serialized for the commit log during commit log recovery. This is wasteul.
--------------------------------------------------------------------------------------------------
Key: CASSANDRA-652
URL: https://issues.apache.org/jira/browse/CASSANDRA-652
Project: Cassandra
Issue Type: Improvement
Components: Core
Affects Versions: 0.5
Reporter: Gary Dusbabek
Assignee: Gary Dusbabek
Priority: Minor
RowMutation.apply(false) implies that the RowMutation doesn't need to be written to the commit log, but it serializes itself regardless.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-652) RowMutations are being serialized
for the commit log during commit log recovery. This is wasteul.
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Dusbabek updated CASSANDRA-652:
------------------------------------
Attachment: 652.diff
> RowMutations are being serialized for the commit log during commit log recovery. This is wasteul.
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-652
> URL: https://issues.apache.org/jira/browse/CASSANDRA-652
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.5
> Reporter: Gary Dusbabek
> Assignee: Gary Dusbabek
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 652.diff
>
>
> RowMutation.apply(false) implies that the RowMutation doesn't need to be written to the commit log, but it serializes itself regardless.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-652) RowMutations are being serialized
for the commit log during commit log recovery. This is wasteul.
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794196#action_12794196 ]
Chris Goffinet commented on CASSANDRA-652:
------------------------------------------
+1 on v2
> RowMutations are being serialized for the commit log during commit log recovery. This is wasteul.
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-652
> URL: https://issues.apache.org/jira/browse/CASSANDRA-652
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.5
> Reporter: Gary Dusbabek
> Assignee: Gary Dusbabek
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 652-v2.patch, 652.diff
>
>
> RowMutation.apply(false) implies that the RowMutation doesn't need to be written to the commit log, but it serializes itself regardless.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-652) RowMutations are being serialized
for the commit log during commit log recovery. This is wasteul.
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794175#action_12794175 ]
Jonathan Ellis commented on CASSANDRA-652:
------------------------------------------
the reason Table.apply takes the buffer arg is so RMV can pass in the bytes[] it already had. somehow that code got lost, or maybe I never wrote it... let me see about adding that in too
> RowMutations are being serialized for the commit log during commit log recovery. This is wasteul.
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-652
> URL: https://issues.apache.org/jira/browse/CASSANDRA-652
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.5
> Reporter: Gary Dusbabek
> Assignee: Gary Dusbabek
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 652.diff
>
>
> RowMutation.apply(false) implies that the RowMutation doesn't need to be written to the commit log, but it serializes itself regardless.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-652) RowMutations are being serialized
for the commit log during commit log recovery. This is wasteul.
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-652:
-------------------------------------
Fix Version/s: (was: 0.9)
0.5
Affects Version/s: (was: 0.5)
> RowMutations are being serialized for the commit log during commit log recovery. This is wasteul.
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-652
> URL: https://issues.apache.org/jira/browse/CASSANDRA-652
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Gary Dusbabek
> Assignee: Gary Dusbabek
> Priority: Minor
> Fix For: 0.5
>
> Attachments: 652-v2.patch, 652.diff
>
>
> RowMutation.apply(false) implies that the RowMutation doesn't need to be written to the commit log, but it serializes itself regardless.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-652) RowMutations are being serialized
for the commit log during commit log recovery. This is wasteul.
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794186#action_12794186 ]
Chris Goffinet commented on CASSANDRA-652:
------------------------------------------
+1 LGTM.
> RowMutations are being serialized for the commit log during commit log recovery. This is wasteul.
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-652
> URL: https://issues.apache.org/jira/browse/CASSANDRA-652
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.5
> Reporter: Gary Dusbabek
> Assignee: Gary Dusbabek
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 652-v2.patch, 652.diff
>
>
> RowMutation.apply(false) implies that the RowMutation doesn't need to be written to the commit log, but it serializes itself regardless.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-652) RowMutations are being serialized
for the commit log during commit log recovery. This is wasteul.
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-652:
-------------------------------------
Attachment: 652-v2.patch
patch that fixes both inefficiencies
> RowMutations are being serialized for the commit log during commit log recovery. This is wasteul.
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-652
> URL: https://issues.apache.org/jira/browse/CASSANDRA-652
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.5
> Reporter: Gary Dusbabek
> Assignee: Gary Dusbabek
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 652-v2.patch, 652.diff
>
>
> RowMutation.apply(false) implies that the RowMutation doesn't need to be written to the commit log, but it serializes itself regardless.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CASSANDRA-652) RowMutations are being
serialized for the commit log during commit log recovery. This is wasteul.
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794175#action_12794175 ]
Jonathan Ellis edited comment on CASSANDRA-652 at 12/23/09 7:38 PM:
--------------------------------------------------------------------
the reason Table.apply takes the buffer arg is so RMVH can pass in the bytes[] it already had. somehow that code got lost, or maybe I never wrote it... let me see about adding that in too
was (Author: jbellis):
the reason Table.apply takes the buffer arg is so RMV can pass in the bytes[] it already had. somehow that code got lost, or maybe I never wrote it... let me see about adding that in too
> RowMutations are being serialized for the commit log during commit log recovery. This is wasteul.
> --------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-652
> URL: https://issues.apache.org/jira/browse/CASSANDRA-652
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.5
> Reporter: Gary Dusbabek
> Assignee: Gary Dusbabek
> Priority: Minor
> Fix For: 0.9
>
> Attachments: 652-v2.patch, 652.diff
>
>
> RowMutation.apply(false) implies that the RowMutation doesn't need to be written to the commit log, but it serializes itself regardless.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.