You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nemo.apache.org by wy...@apache.org on 2020/01/16 13:35:25 UTC
[incubator-nemo] branch master updated: [NEMO-429] SWPP TEAM 9 code
smell fix (#259)
This is an automated email from the ASF dual-hosted git repository.
wylee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nemo.git
The following commit(s) were added to refs/heads/master by this push:
new 5ba3f72 [NEMO-429] SWPP TEAM 9 code smell fix (#259)
5ba3f72 is described below
commit 5ba3f7248b59b5434ae87e3c84445679b018b1b6
Author: Yoo-Youngjae <44...@users.noreply.github.com>
AuthorDate: Thu Jan 16 22:35:19 2020 +0900
[NEMO-429] SWPP TEAM 9 code smell fix (#259)
* switch statement -> if statement
* transient added
Co-authored-by: manhair <43...@users.noreply.github.com>
Co-authored-by: WooYeon Lee <wy...@apache.org>
---
.../java/org/apache/nemo/client/ClientUtils.java | 24 +++++++++-------------
.../beam/MultinomialLogisticRegression.java | 2 +-
2 files changed, 11 insertions(+), 15 deletions(-)
diff --git a/client/src/main/java/org/apache/nemo/client/ClientUtils.java b/client/src/main/java/org/apache/nemo/client/ClientUtils.java
index a200a2e..afe9097 100644
--- a/client/src/main/java/org/apache/nemo/client/ClientUtils.java
+++ b/client/src/main/java/org/apache/nemo/client/ClientUtils.java
@@ -47,20 +47,16 @@ public final class ClientUtils {
*/
static void handleOptimizationType(final ControlMessage.DriverToClientMessage message,
final DriverRPCServer driverRPCServer) {
- switch (message.getOptimizationType()) {
- case XGBoost:
- new Thread(() ->
- driverRPCServer.send(ControlMessage.ClientToDriverMessage.newBuilder()
- .setType(ControlMessage.ClientToDriverMessageType.Notification)
- .setMessage(ControlMessage.NotificationMessage.newBuilder()
- .setOptimizationType(ControlMessage.OptimizationType.XGBoost)
- .setData(ClientUtils.launchXGBoostScript(message.getDataCollected().getData()))
- .build())
- .build()))
- .start();
- break;
- default:
- break;
+ if (message.getOptimizationType().equals(ControlMessage.OptimizationType.XGBoost)) {
+ new Thread(() ->
+ driverRPCServer.send(ControlMessage.ClientToDriverMessage.newBuilder()
+ .setType(ControlMessage.ClientToDriverMessageType.Notification)
+ .setMessage(ControlMessage.NotificationMessage.newBuilder()
+ .setOptimizationType(ControlMessage.OptimizationType.XGBoost)
+ .setData(ClientUtils.launchXGBoostScript(message.getDataCollected().getData()))
+ .build())
+ .build()))
+ .start();
}
}
diff --git a/examples/beam/src/main/java/org/apache/nemo/examples/beam/MultinomialLogisticRegression.java b/examples/beam/src/main/java/org/apache/nemo/examples/beam/MultinomialLogisticRegression.java
index 79f2bba..3efbd72 100644
--- a/examples/beam/src/main/java/org/apache/nemo/examples/beam/MultinomialLogisticRegression.java
+++ b/examples/beam/src/main/java/org/apache/nemo/examples/beam/MultinomialLogisticRegression.java
@@ -58,7 +58,7 @@ public final class MultinomialLogisticRegression {
private Map<Integer, List<Double>> model;
// TODO #274: Use bundles properly in Beam MultinomialLogisticRegression
- private ProcessContext savedContextHack;
+ private transient ProcessContext savedContextHack;
/**
* Constructor for CalculateGradient DoFn class.