[GitHub] [skywalking] wu-sheng edited a comment on pull request #6894: [WIP] group endpoint in skywalking agent automatically

[GitBox <gi...@apache.org>]

wu-sheng edited a comment on pull request #6894:
URL: https://github.com/apache/skywalking/pull/6894#issuecomment-832373497


   If I go deeper into your case, some of them are not making sense.
   > if a request with a path variable is rejected by a servlet filter (like authenticate filter)
   
   If this is an authentication filter, the path and parameter don't matter in most cases. Even we unify those URIs, what metrics could you get? You could easily build a plugin for your auth filter or use an application toolkit to override the operation name of the entry span if that really matters.
   
   > it will cause endpoint options in skywalking UI very hard to use (endpoint traffic), 
   
   UI doesn't care about this. What do you mean hard to use? This low traffic endpoint should not be seen on the UI
   
   > more cost for metric aggregation(especial endpoint 2 endpoint relations ), 
   
   Since 8.0, the OAP removed the register mechanism, the possibility of URI doesn't matter anymore. It just costs a little memory of OAP cluster.
   
   > and more alarm window for alarm module (even oom in OAP server).
   
   Like we mentioned many times, endpoint level alarm is never recommended. We support endpoint level alarm is helping you to set rules for specific endpoints, rather than for all.
   
   ___
   From all the above things, we really should focus on what are the real issues to trigger this feature. In SkyWalking, we are very focusing on the real case, rather than a feature people feeling in the first place.
   Only with that, we could make sure the agent costing limited and reasonable resources, and help the system running in high traffic. In current practice, we usually support 3k~10k/s per JVM. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org