You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@taverna.apache.org by Sagar <ku...@gmail.com> on 2016/06/02 05:28:36 UTC
Taverna Mobile Application
Hi All,
My semester end exam gone well and I am starting my internship on this
project as we talk earlier, Now I started working on Taverna Mobile
Application.
I go through Rajan Maurya's GsoC proposal and found he researched well and
I am following it as accordingly.
I have sent a pull request (PR no #14
<https://github.com/apache/incubator-taverna-mobile/pull/14>) and I have
added some libraries and start working on Announcements features.
- Added MVP architecture basic
- Setup Retrofit
- Setup Simple xml parser
- Setup Rx-JAVA and Rx-Android
- Setup ButterKnife
- Design Announcement layout
- Working ListView to show all Announcements
- [WIP] Detail of clicked Announcement
I am currently working on it.
Rajan Maurya, Please reviews the #PR
<https://github.com/apache/incubator-taverna-mobile/pull/14> till now and
suggests me something if there is something needed to change .
If anyone else wants to work on it or review my work, it'd be great.
--
*With warm regards *
*Sincerely yours*
Sagar
*Student ,(6th Semester )B.Tech IT and mathematical innovation*
*Cluster Innovation Centre*
*University of Delhi *
Re: Taverna Mobile Application
Posted by Stian Soiland-Reyes <st...@apache.org>.
Hi,
The Travis integration seems to be working:
https://travis-ci.org/apache/incubator-taverna-mobile
and leaving comments like on the bottom of:
https://github.com/apache/incubator-taverna-mobile/pull/15
> continuous-integration/travis-ci/pr The Travis CI build passed
https://travis-ci.org/apache/incubator-taverna-mobile/builds/137220117
my attempt to a Jenkins job (with a manual pre-script to install the
Android SDK)
is not quite happy however:
https://builds.apache.org/job/incubator-taverna-mobile-test/17/console
A problem occurred configuring project ':app'.
> Could not resolve all dependencies for configuration ':app:_debugCompile'.
> Could not find com.android.support:appcompat-v7:23.3.0.
Searched in the following locations:
https://jcenter.bintray.com/com/android/support/appcompat-v7/23.3.0/appcompat-v7-23.3.0.pom
https://jcenter.bintray.com/com/android/support/appcompat-v7/23.3.0/appcompat-v7-23.3.0.jar
https://repo1.maven.org/maven2/com/android/support/appcompat-v7/23.3.0/appcompat-v7-23.3.0.pom
https://repo1.maven.org/maven2/com/android/support/appcompat-v7/23.3.0/appcompat-v7-23.3.0.jar
Required by:
incubator-taverna-mobile-test:app:unspecified
I feel Jenkins is not far off from working.. what could be missing?
The job is set up with this pre-script:
https://paste.apache.org/NFtm
(I could add it to the git repository so it's easier to edit)
On 10 June 2016 at 15:43, Rajan Maurya <ra...@gmail.com> wrote:
> Hi stain,
>
> Please merge the Travis CI PR .
>
> If we don't have problem to use Travis in place Jenkins.
>
> Or you can enable Jenkins.
>
> It will very helpful for me review the Sagar next PR Code Analysis Tools
> Implementation with Travis or Jenkins.
> On 8 Jun 2016 6:02 p.m., "Sagar" <ku...@gmail.com> wrote:
>
>> Hi Stain,
>>
>> I have added ASF file header in all newly added file .Please check and
>> merge it so that I work on next feature because this is the base of my next
>> PRs.
>>
>> Thanks
>>
>> On Mon, Jun 6, 2016 at 9:24 PM, Rajan Maurya <ra...@gmail.com>
>> wrote:
>>
>> > Actually, the good way to manage and list the dependencies is :
>> >
>> >
>> >
>> https://github.com/therajanmaurya/android-client/blob/MVP-Phase-1/mifosng-android/build.gradle
>> > and
>> >
>> >
>> https://github.com/therajanmaurya/android-client/blob/MVP-Phase-1/build.gradle
>> >
>> > But I think, It has to be in separate #PR. So, Sagar will open his next
>> PR
>> > of managing the build.gradle.
>> >
>> > And About the licenses of the dependencies, we don't need to mention here
>> > we will add all dependencies licenses in Application (All Libraries used
>> > license).
>> > As a Feature.
>> >
>> > Thanks
>> >
>> >
>> > On Monday, June 6, 2016, Stian Soiland-Reyes <st...@apache.org> wrote:
>> >
>> > > On 5 June 2016 at 22:03, Sagar <ku...@gmail.com> wrote:
>> > > > Hi Rajan,
>> > > >
>> > > > I have fixed all your input. Please review it again and suggests me
>> > > > something if there is something needed to change .
>> > > >
>> > > > If anyone else wants to work on it or review my work, it'd be great.
>> > >
>> > > Thanks both! I've commented on the pull request that we just need some
>> > > ASF headers on the new files, so we know they are licensed correctly.
>> > >
>> > >
>> > >
>> >
>> https://github.com/apache/incubator-taverna-mobile/pull/14#issuecomment-223956980
>> > >
>> > > (Note the license headers are not quite consistent in the rest of
>> > > Taverna Mobile, see also
>> > > https://issues.apache.org/jira/browse/TAVERNA-976 )
>> > >
>> > >
>> > > I checked the licenses of the new dependencies manually - they are all
>> > > ASF 2.0 and so compabible. But do you know if there is a good Gradle
>> > > way to list all dependencies (including transitives) and their
>> > > licenses?
>> > >
>> > >
>> > >
>> >
>> https://github.com/sagar15795/incubator-taverna-mobile/blob/Announcement/app/build.gradle#L31
>> > >
>> > > --
>> > > Stian Soiland-Reyes
>> > > Apache Taverna (incubating), Apache Commons
>> > > http://orcid.org/0000-0001-9842-9718
>> > >
>> >
>> >
>> > --
>> > *Thanks*
>> > *Namaste*
>> >
>> > Rajan Maurya
>> > Contact Number : +91 8010665248
>> > Github : https://github.com/therajanmaurya
>> > College : Cluster Innovation Centre, University of Delhi
>> > Student : B.Tech. (Information Technology & Mathematical Innovations)
>> >
>>
>>
>>
>> --
>>
>> *With warm regards *
>> *Sincerely yours*
>> Sagar
>>
>>
>> *Student ,(6th Semester )B.Tech IT and mathematical innovation*
>> *Cluster Innovation Centre*
>> *University of Delhi *
>>
--
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons
http://orcid.org/0000-0001-9842-9718
Re: Taverna Mobile Application
Posted by Sagar <ku...@gmail.com>.
Hi,
Thanks, Rajan Maurya to help in person.
I have implemented the code analysis and all Travis build are passing.
Here is my PR <https://github.com/apache/incubator-taverna-mobile/pull/15>
Please look.
Rajan, please review my code.
Thanks.
On Fri, Jun 10, 2016 at 8:13 PM, Rajan Maurya <ra...@gmail.com>
wrote:
> Hi stain,
>
> Please merge the Travis CI PR .
>
> If we don't have problem to use Travis in place Jenkins.
>
> Or you can enable Jenkins.
>
> It will very helpful for me review the Sagar next PR Code Analysis Tools
> Implementation with Travis or Jenkins.
> On 8 Jun 2016 6:02 p.m., "Sagar" <ku...@gmail.com> wrote:
>
> > Hi Stain,
> >
> > I have added ASF file header in all newly added file .Please check and
> > merge it so that I work on next feature because this is the base of my
> next
> > PRs.
> >
> > Thanks
> >
> > On Mon, Jun 6, 2016 at 9:24 PM, Rajan Maurya <ra...@gmail.com>
> > wrote:
> >
> > > Actually, the good way to manage and list the dependencies is :
> > >
> > >
> > >
> >
> https://github.com/therajanmaurya/android-client/blob/MVP-Phase-1/mifosng-android/build.gradle
> > > and
> > >
> > >
> >
> https://github.com/therajanmaurya/android-client/blob/MVP-Phase-1/build.gradle
> > >
> > > But I think, It has to be in separate #PR. So, Sagar will open his next
> > PR
> > > of managing the build.gradle.
> > >
> > > And About the licenses of the dependencies, we don't need to mention
> here
> > > we will add all dependencies licenses in Application (All Libraries
> used
> > > license).
> > > As a Feature.
> > >
> > > Thanks
> > >
> > >
> > > On Monday, June 6, 2016, Stian Soiland-Reyes <st...@apache.org> wrote:
> > >
> > > > On 5 June 2016 at 22:03, Sagar <ku...@gmail.com> wrote:
> > > > > Hi Rajan,
> > > > >
> > > > > I have fixed all your input. Please review it again and suggests
> me
> > > > > something if there is something needed to change .
> > > > >
> > > > > If anyone else wants to work on it or review my work, it'd be
> great.
> > > >
> > > > Thanks both! I've commented on the pull request that we just need
> some
> > > > ASF headers on the new files, so we know they are licensed correctly.
> > > >
> > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-taverna-mobile/pull/14#issuecomment-223956980
> > > >
> > > > (Note the license headers are not quite consistent in the rest of
> > > > Taverna Mobile, see also
> > > > https://issues.apache.org/jira/browse/TAVERNA-976 )
> > > >
> > > >
> > > > I checked the licenses of the new dependencies manually - they are
> all
> > > > ASF 2.0 and so compabible. But do you know if there is a good Gradle
> > > > way to list all dependencies (including transitives) and their
> > > > licenses?
> > > >
> > > >
> > > >
> > >
> >
> https://github.com/sagar15795/incubator-taverna-mobile/blob/Announcement/app/build.gradle#L31
> > > >
> > > > --
> > > > Stian Soiland-Reyes
> > > > Apache Taverna (incubating), Apache Commons
> > > > http://orcid.org/0000-0001-9842-9718
> > > >
> > >
> > >
> > > --
> > > *Thanks*
> > > *Namaste*
> > >
> > > Rajan Maurya
> > > Contact Number : +91 8010665248
> > > Github : https://github.com/therajanmaurya
> > > College : Cluster Innovation Centre, University of Delhi
> > > Student : B.Tech. (Information Technology & Mathematical Innovations)
> > >
> >
> >
> >
> > --
> >
> > *With warm regards *
> > *Sincerely yours*
> > Sagar
> >
> >
> > *Student ,(6th Semester )B.Tech IT and mathematical innovation*
> > *Cluster Innovation Centre*
> > *University of Delhi *
> >
>
--
*With warm regards *
*Sincerely yours*
Sagar
*Student ,(6th Semester )B.Tech IT and mathematical innovation*
*Cluster Innovation Centre*
*University of Delhi *
Re: Taverna Mobile Application
Posted by Rajan Maurya <ra...@gmail.com>.
Hi stain,
Please merge the Travis CI PR .
If we don't have problem to use Travis in place Jenkins.
Or you can enable Jenkins.
It will very helpful for me review the Sagar next PR Code Analysis Tools
Implementation with Travis or Jenkins.
On 8 Jun 2016 6:02 p.m., "Sagar" <ku...@gmail.com> wrote:
> Hi Stain,
>
> I have added ASF file header in all newly added file .Please check and
> merge it so that I work on next feature because this is the base of my next
> PRs.
>
> Thanks
>
> On Mon, Jun 6, 2016 at 9:24 PM, Rajan Maurya <ra...@gmail.com>
> wrote:
>
> > Actually, the good way to manage and list the dependencies is :
> >
> >
> >
> https://github.com/therajanmaurya/android-client/blob/MVP-Phase-1/mifosng-android/build.gradle
> > and
> >
> >
> https://github.com/therajanmaurya/android-client/blob/MVP-Phase-1/build.gradle
> >
> > But I think, It has to be in separate #PR. So, Sagar will open his next
> PR
> > of managing the build.gradle.
> >
> > And About the licenses of the dependencies, we don't need to mention here
> > we will add all dependencies licenses in Application (All Libraries used
> > license).
> > As a Feature.
> >
> > Thanks
> >
> >
> > On Monday, June 6, 2016, Stian Soiland-Reyes <st...@apache.org> wrote:
> >
> > > On 5 June 2016 at 22:03, Sagar <ku...@gmail.com> wrote:
> > > > Hi Rajan,
> > > >
> > > > I have fixed all your input. Please review it again and suggests me
> > > > something if there is something needed to change .
> > > >
> > > > If anyone else wants to work on it or review my work, it'd be great.
> > >
> > > Thanks both! I've commented on the pull request that we just need some
> > > ASF headers on the new files, so we know they are licensed correctly.
> > >
> > >
> > >
> >
> https://github.com/apache/incubator-taverna-mobile/pull/14#issuecomment-223956980
> > >
> > > (Note the license headers are not quite consistent in the rest of
> > > Taverna Mobile, see also
> > > https://issues.apache.org/jira/browse/TAVERNA-976 )
> > >
> > >
> > > I checked the licenses of the new dependencies manually - they are all
> > > ASF 2.0 and so compabible. But do you know if there is a good Gradle
> > > way to list all dependencies (including transitives) and their
> > > licenses?
> > >
> > >
> > >
> >
> https://github.com/sagar15795/incubator-taverna-mobile/blob/Announcement/app/build.gradle#L31
> > >
> > > --
> > > Stian Soiland-Reyes
> > > Apache Taverna (incubating), Apache Commons
> > > http://orcid.org/0000-0001-9842-9718
> > >
> >
> >
> > --
> > *Thanks*
> > *Namaste*
> >
> > Rajan Maurya
> > Contact Number : +91 8010665248
> > Github : https://github.com/therajanmaurya
> > College : Cluster Innovation Centre, University of Delhi
> > Student : B.Tech. (Information Technology & Mathematical Innovations)
> >
>
>
>
> --
>
> *With warm regards *
> *Sincerely yours*
> Sagar
>
>
> *Student ,(6th Semester )B.Tech IT and mathematical innovation*
> *Cluster Innovation Centre*
> *University of Delhi *
>
Re: Taverna Mobile Application
Posted by Stian Soiland-Reyes <st...@apache.org>.
Hi,
Thanks for the pull request - it has been merged.
https://github.com/apache/incubator-taverna-mobile/pull/15
Let's start a new thread for each thing rather than continue on this
long thread :) I'm loosing a bit track of what has been replied to or
not..
While the GitHub integration sends a separate email., it's convenient
if you include the link to the pull request in question.
Also I'm not the only one who can review/merge your patches, so let's
address the whole of Taverna community rather than Stian. :)
I would suggest something like:
"Hi folks,
Could you review the pull request
https://github.com/apache/incubator-taverna-mobile/pull/15 ?
This fixes licensing headers.
"
On 8 June 2016 at 13:32, Sagar <ku...@gmail.com> wrote:
> Hi Stain,
>
> I have added ASF file header in all newly added file .Please check and
> merge it so that I work on next feature because this is the base of my next
> PRs.
>
> Thanks
>
> On Mon, Jun 6, 2016 at 9:24 PM, Rajan Maurya <ra...@gmail.com>
> wrote:
>
>> Actually, the good way to manage and list the dependencies is :
>>
>>
>> https://github.com/therajanmaurya/android-client/blob/MVP-Phase-1/mifosng-android/build.gradle
>> and
>>
>> https://github.com/therajanmaurya/android-client/blob/MVP-Phase-1/build.gradle
>>
>> But I think, It has to be in separate #PR. So, Sagar will open his next PR
>> of managing the build.gradle.
>>
>> And About the licenses of the dependencies, we don't need to mention here
>> we will add all dependencies licenses in Application (All Libraries used
>> license).
>> As a Feature.
>>
>> Thanks
>>
>>
>> On Monday, June 6, 2016, Stian Soiland-Reyes <st...@apache.org> wrote:
>>
>> > On 5 June 2016 at 22:03, Sagar <ku...@gmail.com> wrote:
>> > > Hi Rajan,
>> > >
>> > > I have fixed all your input. Please review it again and suggests me
>> > > something if there is something needed to change .
>> > >
>> > > If anyone else wants to work on it or review my work, it'd be great.
>> >
>> > Thanks both! I've commented on the pull request that we just need some
>> > ASF headers on the new files, so we know they are licensed correctly.
>> >
>> >
>> >
>> https://github.com/apache/incubator-taverna-mobile/pull/14#issuecomment-223956980
>> >
>> > (Note the license headers are not quite consistent in the rest of
>> > Taverna Mobile, see also
>> > https://issues.apache.org/jira/browse/TAVERNA-976 )
>> >
>> >
>> > I checked the licenses of the new dependencies manually - they are all
>> > ASF 2.0 and so compabible. But do you know if there is a good Gradle
>> > way to list all dependencies (including transitives) and their
>> > licenses?
>> >
>> >
>> >
>> https://github.com/sagar15795/incubator-taverna-mobile/blob/Announcement/app/build.gradle#L31
>> >
>> > --
>> > Stian Soiland-Reyes
>> > Apache Taverna (incubating), Apache Commons
>> > http://orcid.org/0000-0001-9842-9718
>> >
>>
>>
>> --
>> *Thanks*
>> *Namaste*
>>
>> Rajan Maurya
>> Contact Number : +91 8010665248
>> Github : https://github.com/therajanmaurya
>> College : Cluster Innovation Centre, University of Delhi
>> Student : B.Tech. (Information Technology & Mathematical Innovations)
>>
>
>
>
> --
>
> *With warm regards *
> *Sincerely yours*
> Sagar
>
>
> *Student ,(6th Semester )B.Tech IT and mathematical innovation*
> *Cluster Innovation Centre*
> *University of Delhi *
--
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons
http://orcid.org/0000-0001-9842-9718
Re: Taverna Mobile Application
Posted by Sagar <ku...@gmail.com>.
Hi Stain,
I have added ASF file header in all newly added file .Please check and
merge it so that I work on next feature because this is the base of my next
PRs.
Thanks
On Mon, Jun 6, 2016 at 9:24 PM, Rajan Maurya <ra...@gmail.com>
wrote:
> Actually, the good way to manage and list the dependencies is :
>
>
> https://github.com/therajanmaurya/android-client/blob/MVP-Phase-1/mifosng-android/build.gradle
> and
>
> https://github.com/therajanmaurya/android-client/blob/MVP-Phase-1/build.gradle
>
> But I think, It has to be in separate #PR. So, Sagar will open his next PR
> of managing the build.gradle.
>
> And About the licenses of the dependencies, we don't need to mention here
> we will add all dependencies licenses in Application (All Libraries used
> license).
> As a Feature.
>
> Thanks
>
>
> On Monday, June 6, 2016, Stian Soiland-Reyes <st...@apache.org> wrote:
>
> > On 5 June 2016 at 22:03, Sagar <ku...@gmail.com> wrote:
> > > Hi Rajan,
> > >
> > > I have fixed all your input. Please review it again and suggests me
> > > something if there is something needed to change .
> > >
> > > If anyone else wants to work on it or review my work, it'd be great.
> >
> > Thanks both! I've commented on the pull request that we just need some
> > ASF headers on the new files, so we know they are licensed correctly.
> >
> >
> >
> https://github.com/apache/incubator-taverna-mobile/pull/14#issuecomment-223956980
> >
> > (Note the license headers are not quite consistent in the rest of
> > Taverna Mobile, see also
> > https://issues.apache.org/jira/browse/TAVERNA-976 )
> >
> >
> > I checked the licenses of the new dependencies manually - they are all
> > ASF 2.0 and so compabible. But do you know if there is a good Gradle
> > way to list all dependencies (including transitives) and their
> > licenses?
> >
> >
> >
> https://github.com/sagar15795/incubator-taverna-mobile/blob/Announcement/app/build.gradle#L31
> >
> > --
> > Stian Soiland-Reyes
> > Apache Taverna (incubating), Apache Commons
> > http://orcid.org/0000-0001-9842-9718
> >
>
>
> --
> *Thanks*
> *Namaste*
>
> Rajan Maurya
> Contact Number : +91 8010665248
> Github : https://github.com/therajanmaurya
> College : Cluster Innovation Centre, University of Delhi
> Student : B.Tech. (Information Technology & Mathematical Innovations)
>
--
*With warm regards *
*Sincerely yours*
Sagar
*Student ,(6th Semester )B.Tech IT and mathematical innovation*
*Cluster Innovation Centre*
*University of Delhi *
Re: Taverna Mobile Application
Posted by Rajan Maurya <ra...@gmail.com>.
Actually, the good way to manage and list the dependencies is :
https://github.com/therajanmaurya/android-client/blob/MVP-Phase-1/mifosng-android/build.gradle
and
https://github.com/therajanmaurya/android-client/blob/MVP-Phase-1/build.gradle
But I think, It has to be in separate #PR. So, Sagar will open his next PR
of managing the build.gradle.
And About the licenses of the dependencies, we don't need to mention here
we will add all dependencies licenses in Application (All Libraries used
license).
As a Feature.
Thanks
On Monday, June 6, 2016, Stian Soiland-Reyes <st...@apache.org> wrote:
> On 5 June 2016 at 22:03, Sagar <ku...@gmail.com> wrote:
> > Hi Rajan,
> >
> > I have fixed all your input. Please review it again and suggests me
> > something if there is something needed to change .
> >
> > If anyone else wants to work on it or review my work, it'd be great.
>
> Thanks both! I've commented on the pull request that we just need some
> ASF headers on the new files, so we know they are licensed correctly.
>
>
> https://github.com/apache/incubator-taverna-mobile/pull/14#issuecomment-223956980
>
> (Note the license headers are not quite consistent in the rest of
> Taverna Mobile, see also
> https://issues.apache.org/jira/browse/TAVERNA-976 )
>
>
> I checked the licenses of the new dependencies manually - they are all
> ASF 2.0 and so compabible. But do you know if there is a good Gradle
> way to list all dependencies (including transitives) and their
> licenses?
>
>
> https://github.com/sagar15795/incubator-taverna-mobile/blob/Announcement/app/build.gradle#L31
>
> --
> Stian Soiland-Reyes
> Apache Taverna (incubating), Apache Commons
> http://orcid.org/0000-0001-9842-9718
>
--
*Thanks*
*Namaste*
Rajan Maurya
Contact Number : +91 8010665248
Github : https://github.com/therajanmaurya
College : Cluster Innovation Centre, University of Delhi
Student : B.Tech. (Information Technology & Mathematical Innovations)
Re: Taverna Mobile Application
Posted by Stian Soiland-Reyes <st...@apache.org>.
On 5 June 2016 at 22:03, Sagar <ku...@gmail.com> wrote:
> Hi Rajan,
>
> I have fixed all your input. Please review it again and suggests me
> something if there is something needed to change .
>
> If anyone else wants to work on it or review my work, it'd be great.
Thanks both! I've commented on the pull request that we just need some
ASF headers on the new files, so we know they are licensed correctly.
https://github.com/apache/incubator-taverna-mobile/pull/14#issuecomment-223956980
(Note the license headers are not quite consistent in the rest of
Taverna Mobile, see also
https://issues.apache.org/jira/browse/TAVERNA-976 )
I checked the licenses of the new dependencies manually - they are all
ASF 2.0 and so compabible. But do you know if there is a good Gradle
way to list all dependencies (including transitives) and their
licenses?
https://github.com/sagar15795/incubator-taverna-mobile/blob/Announcement/app/build.gradle#L31
--
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons
http://orcid.org/0000-0001-9842-9718
Re: Taverna Mobile Application
Posted by Sagar <ku...@gmail.com>.
Hi Rajan,
I have fixed all your input. Please review it again and suggests me
something if there is something needed to change .
If anyone else wants to work on it or review my work, it'd be great.
On Fri, Jun 3, 2016 at 6:30 PM, Gale Naylor <Ga...@noventussolutions.com>
wrote:
> Thanks, Rajan!
>
> On Thu, Jun 2, 2016, 8:15 PM Rajan Maurya <ra...@gmail.com>
> wrote:
>
> > Hi Gale,
> >
> > Ok, Actually I forget to mention the GitHub PR.
> >
> > Here is some point need to fix first to merge the PR
> >
> > 1. Implement Parcelable in POJO for making faster HTTPS Calls
> > 2.
> >
> > Do not make multiple POJO class in single like you have done here
> >
> >
> app/src/main/java/org/apache/taverna/mobile/data/model/Announcement.java.
> > Made author POJO in Announcement POJO because author POJO will be used
> > further in many places in future so make it separate.
> > 3.
> >
> > When you will make separate POJOs then you do not need the
> hierarchical
> > initialization of List. It's not good practice.
> > 4.
> >
> > Naming convention mMainPresenter in AnnouncementFragment, make it
> > mAnnouncementPresenter. It can be good. for future follow this
> >
> >
> https://github.com/ribot/android-guidelines/blob/master/project_and_code_guidelines.md#2-code-guidelines
> > .
> > 5.
> >
> > You are using ConnectivityManager for checking internet connection two
> > times in the same file bad practice.
> > I suggest making a util/ConnectionInfo something class to use anywhere
> > you need to check internet connection.
> > 6.
> >
> > What about if the loading data failed from the internet. Implement
> > showResponseError.
> >
> >
> > Thanks
> >
> >
> >
> >
> > On Fri, Jun 3, 2016 at 3:37 AM, Gale Naylor <GaleN@noventussolutions.com
> >
> > wrote:
> >
> > > Hi Rajan,
> > >
> > > The dev@taverna mailing list is intended to collect all development
> > work,
> > > including things like your suggested fixes to the Taverna Mobile App!
> > >
> > > Can you please include your suggestions in an email to the dev list? (A
> > > reply to this email would make sense.)
> > >
> > > Thanks!
> > >
> > > Gale
> > >
> > > On Thu, Jun 2, 2016 at 10:28 AM Rajan Maurya <rajanmaurya154@gmail.com
> >
> > > wrote:
> > >
> > > > Hi Sagar,
> > > >
> > > > I have reviewed the PR.
> > > > Please look and fix all of these that i have mentioned.
> > > >
> > > > Thanks
> > > > On Jun 2, 2016 11:23 AM, "Rajan Maurya" <ra...@gmail.com>
> > > wrote:
> > > >
> > > > > Hi Sagar,
> > > > >
> > > > > Its looks good. I will review it today and update you if there is
> > any
> > > > > need to change.
> > > > >
> > > > > Implement rest of Announcement Details part
> > > > >
> > > > > Good :)
> > > > >
> > > > >
> > > > > On Thu, Jun 2, 2016 at 10:58 AM, Sagar <ku...@gmail.com>
> > > > wrote:
> > > > >
> > > > >> Hi All,
> > > > >> My semester end exam gone well and I am starting my internship
> > on
> > > > this
> > > > >> project as we talk earlier, Now I started working on Taverna
> Mobile
> > > > >> Application.
> > > > >>
> > > > >> I go through Rajan Maurya's GsoC proposal and found he researched
> > well
> > > > and
> > > > >> I am following it as accordingly.
> > > > >>
> > > > >> I have sent a pull request (PR no #14
> > > > >> <https://github.com/apache/incubator-taverna-mobile/pull/14>)
> and
> > I
> > > > have
> > > > >> added some libraries and start working on Announcements features.
> > > > >>
> > > > >> - Added MVP architecture basic
> > > > >> - Setup Retrofit
> > > > >> - Setup Simple xml parser
> > > > >> - Setup Rx-JAVA and Rx-Android
> > > > >> - Setup ButterKnife
> > > > >> - Design Announcement layout
> > > > >> - Working ListView to show all Announcements
> > > > >> - [WIP] Detail of clicked Announcement
> > > > >>
> > > > >> I am currently working on it.
> > > > >>
> > > > >> Rajan Maurya, Please reviews the #PR
> > > > >> <https://github.com/apache/incubator-taverna-mobile/pull/14> till
> > now
> > > > >> and
> > > > >> suggests me something if there is something needed to change .
> > > > >>
> > > > >> If anyone else wants to work on it or review my work, it'd be
> great.
> > > > >>
> > > > >> --
> > > > >>
> > > > >> *With warm regards *
> > > > >> *Sincerely yours*
> > > > >> Sagar
> > > > >>
> > > > >>
> > > > >> *Student ,(6th Semester )B.Tech IT and mathematical innovation*
> > > > >> *Cluster Innovation Centre*
> > > > >> *University of Delhi *
> > > > >>
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > *Thanks*
> > > > > *Namaste*
> > > > >
> > > > > Rajan Maurya
> > > > > Contact Number : +91 8010665248
> > > > > Github : https://github.com/therajanmaurya
> > > > > College : Cluster Innovation Centre, University of Delhi
> > > > > Student : B.Tech. (Information Technology & Mathematical
> Innovations)
> > > > >
> > > > >
> > > >
> > >
> >
> >
> >
> > --
> > *Thanks*
> > *Namaste*
> >
> > Rajan Maurya
> > Contact Number : +91 8010665248
> > Github : https://github.com/therajanmaurya
> > College : Cluster Innovation Centre, University of Delhi
> > Student : B.Tech. (Information Technology & Mathematical Innovations)
> >
>
--
*With warm regards *
*Sincerely yours*
Sagar
*Student ,(6th Semester )B.Tech IT and mathematical innovation*
*Cluster Innovation Centre*
*University of Delhi *
Re: Taverna Mobile Application
Posted by Gale Naylor <Ga...@noventussolutions.com>.
Thanks, Rajan!
On Thu, Jun 2, 2016, 8:15 PM Rajan Maurya <ra...@gmail.com> wrote:
> Hi Gale,
>
> Ok, Actually I forget to mention the GitHub PR.
>
> Here is some point need to fix first to merge the PR
>
> 1. Implement Parcelable in POJO for making faster HTTPS Calls
> 2.
>
> Do not make multiple POJO class in single like you have done here
>
> app/src/main/java/org/apache/taverna/mobile/data/model/Announcement.java.
> Made author POJO in Announcement POJO because author POJO will be used
> further in many places in future so make it separate.
> 3.
>
> When you will make separate POJOs then you do not need the hierarchical
> initialization of List. It's not good practice.
> 4.
>
> Naming convention mMainPresenter in AnnouncementFragment, make it
> mAnnouncementPresenter. It can be good. for future follow this
>
> https://github.com/ribot/android-guidelines/blob/master/project_and_code_guidelines.md#2-code-guidelines
> .
> 5.
>
> You are using ConnectivityManager for checking internet connection two
> times in the same file bad practice.
> I suggest making a util/ConnectionInfo something class to use anywhere
> you need to check internet connection.
> 6.
>
> What about if the loading data failed from the internet. Implement
> showResponseError.
>
>
> Thanks
>
>
>
>
> On Fri, Jun 3, 2016 at 3:37 AM, Gale Naylor <Ga...@noventussolutions.com>
> wrote:
>
> > Hi Rajan,
> >
> > The dev@taverna mailing list is intended to collect all development
> work,
> > including things like your suggested fixes to the Taverna Mobile App!
> >
> > Can you please include your suggestions in an email to the dev list? (A
> > reply to this email would make sense.)
> >
> > Thanks!
> >
> > Gale
> >
> > On Thu, Jun 2, 2016 at 10:28 AM Rajan Maurya <ra...@gmail.com>
> > wrote:
> >
> > > Hi Sagar,
> > >
> > > I have reviewed the PR.
> > > Please look and fix all of these that i have mentioned.
> > >
> > > Thanks
> > > On Jun 2, 2016 11:23 AM, "Rajan Maurya" <ra...@gmail.com>
> > wrote:
> > >
> > > > Hi Sagar,
> > > >
> > > > Its looks good. I will review it today and update you if there is
> any
> > > > need to change.
> > > >
> > > > Implement rest of Announcement Details part
> > > >
> > > > Good :)
> > > >
> > > >
> > > > On Thu, Jun 2, 2016 at 10:58 AM, Sagar <ku...@gmail.com>
> > > wrote:
> > > >
> > > >> Hi All,
> > > >> My semester end exam gone well and I am starting my internship
> on
> > > this
> > > >> project as we talk earlier, Now I started working on Taverna Mobile
> > > >> Application.
> > > >>
> > > >> I go through Rajan Maurya's GsoC proposal and found he researched
> well
> > > and
> > > >> I am following it as accordingly.
> > > >>
> > > >> I have sent a pull request (PR no #14
> > > >> <https://github.com/apache/incubator-taverna-mobile/pull/14>) and
> I
> > > have
> > > >> added some libraries and start working on Announcements features.
> > > >>
> > > >> - Added MVP architecture basic
> > > >> - Setup Retrofit
> > > >> - Setup Simple xml parser
> > > >> - Setup Rx-JAVA and Rx-Android
> > > >> - Setup ButterKnife
> > > >> - Design Announcement layout
> > > >> - Working ListView to show all Announcements
> > > >> - [WIP] Detail of clicked Announcement
> > > >>
> > > >> I am currently working on it.
> > > >>
> > > >> Rajan Maurya, Please reviews the #PR
> > > >> <https://github.com/apache/incubator-taverna-mobile/pull/14> till
> now
> > > >> and
> > > >> suggests me something if there is something needed to change .
> > > >>
> > > >> If anyone else wants to work on it or review my work, it'd be great.
> > > >>
> > > >> --
> > > >>
> > > >> *With warm regards *
> > > >> *Sincerely yours*
> > > >> Sagar
> > > >>
> > > >>
> > > >> *Student ,(6th Semester )B.Tech IT and mathematical innovation*
> > > >> *Cluster Innovation Centre*
> > > >> *University of Delhi *
> > > >>
> > > >
> > > >
> > > >
> > > > --
> > > > *Thanks*
> > > > *Namaste*
> > > >
> > > > Rajan Maurya
> > > > Contact Number : +91 8010665248
> > > > Github : https://github.com/therajanmaurya
> > > > College : Cluster Innovation Centre, University of Delhi
> > > > Student : B.Tech. (Information Technology & Mathematical Innovations)
> > > >
> > > >
> > >
> >
>
>
>
> --
> *Thanks*
> *Namaste*
>
> Rajan Maurya
> Contact Number : +91 8010665248
> Github : https://github.com/therajanmaurya
> College : Cluster Innovation Centre, University of Delhi
> Student : B.Tech. (Information Technology & Mathematical Innovations)
>
Re: Taverna Mobile Application
Posted by Rajan Maurya <ra...@gmail.com>.
Hi Gale,
Ok, Actually I forget to mention the GitHub PR.
Here is some point need to fix first to merge the PR
1. Implement Parcelable in POJO for making faster HTTPS Calls
2.
Do not make multiple POJO class in single like you have done here
app/src/main/java/org/apache/taverna/mobile/data/model/Announcement.java.
Made author POJO in Announcement POJO because author POJO will be used
further in many places in future so make it separate.
3.
When you will make separate POJOs then you do not need the hierarchical
initialization of List. It's not good practice.
4.
Naming convention mMainPresenter in AnnouncementFragment, make it
mAnnouncementPresenter. It can be good. for future follow this
https://github.com/ribot/android-guidelines/blob/master/project_and_code_guidelines.md#2-code-guidelines
.
5.
You are using ConnectivityManager for checking internet connection two
times in the same file bad practice.
I suggest making a util/ConnectionInfo something class to use anywhere
you need to check internet connection.
6.
What about if the loading data failed from the internet. Implement
showResponseError.
Thanks
On Fri, Jun 3, 2016 at 3:37 AM, Gale Naylor <Ga...@noventussolutions.com>
wrote:
> Hi Rajan,
>
> The dev@taverna mailing list is intended to collect all development work,
> including things like your suggested fixes to the Taverna Mobile App!
>
> Can you please include your suggestions in an email to the dev list? (A
> reply to this email would make sense.)
>
> Thanks!
>
> Gale
>
> On Thu, Jun 2, 2016 at 10:28 AM Rajan Maurya <ra...@gmail.com>
> wrote:
>
> > Hi Sagar,
> >
> > I have reviewed the PR.
> > Please look and fix all of these that i have mentioned.
> >
> > Thanks
> > On Jun 2, 2016 11:23 AM, "Rajan Maurya" <ra...@gmail.com>
> wrote:
> >
> > > Hi Sagar,
> > >
> > > Its looks good. I will review it today and update you if there is any
> > > need to change.
> > >
> > > Implement rest of Announcement Details part
> > >
> > > Good :)
> > >
> > >
> > > On Thu, Jun 2, 2016 at 10:58 AM, Sagar <ku...@gmail.com>
> > wrote:
> > >
> > >> Hi All,
> > >> My semester end exam gone well and I am starting my internship on
> > this
> > >> project as we talk earlier, Now I started working on Taverna Mobile
> > >> Application.
> > >>
> > >> I go through Rajan Maurya's GsoC proposal and found he researched well
> > and
> > >> I am following it as accordingly.
> > >>
> > >> I have sent a pull request (PR no #14
> > >> <https://github.com/apache/incubator-taverna-mobile/pull/14>) and I
> > have
> > >> added some libraries and start working on Announcements features.
> > >>
> > >> - Added MVP architecture basic
> > >> - Setup Retrofit
> > >> - Setup Simple xml parser
> > >> - Setup Rx-JAVA and Rx-Android
> > >> - Setup ButterKnife
> > >> - Design Announcement layout
> > >> - Working ListView to show all Announcements
> > >> - [WIP] Detail of clicked Announcement
> > >>
> > >> I am currently working on it.
> > >>
> > >> Rajan Maurya, Please reviews the #PR
> > >> <https://github.com/apache/incubator-taverna-mobile/pull/14> till now
> > >> and
> > >> suggests me something if there is something needed to change .
> > >>
> > >> If anyone else wants to work on it or review my work, it'd be great.
> > >>
> > >> --
> > >>
> > >> *With warm regards *
> > >> *Sincerely yours*
> > >> Sagar
> > >>
> > >>
> > >> *Student ,(6th Semester )B.Tech IT and mathematical innovation*
> > >> *Cluster Innovation Centre*
> > >> *University of Delhi *
> > >>
> > >
> > >
> > >
> > > --
> > > *Thanks*
> > > *Namaste*
> > >
> > > Rajan Maurya
> > > Contact Number : +91 8010665248
> > > Github : https://github.com/therajanmaurya
> > > College : Cluster Innovation Centre, University of Delhi
> > > Student : B.Tech. (Information Technology & Mathematical Innovations)
> > >
> > >
> >
>
--
*Thanks*
*Namaste*
Rajan Maurya
Contact Number : +91 8010665248
Github : https://github.com/therajanmaurya
College : Cluster Innovation Centre, University of Delhi
Student : B.Tech. (Information Technology & Mathematical Innovations)
Re: Taverna Mobile Application
Posted by Gale Naylor <Ga...@noventussolutions.com>.
Hi Rajan,
The dev@taverna mailing list is intended to collect all development work,
including things like your suggested fixes to the Taverna Mobile App!
Can you please include your suggestions in an email to the dev list? (A
reply to this email would make sense.)
Thanks!
Gale
On Thu, Jun 2, 2016 at 10:28 AM Rajan Maurya <ra...@gmail.com>
wrote:
> Hi Sagar,
>
> I have reviewed the PR.
> Please look and fix all of these that i have mentioned.
>
> Thanks
> On Jun 2, 2016 11:23 AM, "Rajan Maurya" <ra...@gmail.com> wrote:
>
> > Hi Sagar,
> >
> > Its looks good. I will review it today and update you if there is any
> > need to change.
> >
> > Implement rest of Announcement Details part
> >
> > Good :)
> >
> >
> > On Thu, Jun 2, 2016 at 10:58 AM, Sagar <ku...@gmail.com>
> wrote:
> >
> >> Hi All,
> >> My semester end exam gone well and I am starting my internship on
> this
> >> project as we talk earlier, Now I started working on Taverna Mobile
> >> Application.
> >>
> >> I go through Rajan Maurya's GsoC proposal and found he researched well
> and
> >> I am following it as accordingly.
> >>
> >> I have sent a pull request (PR no #14
> >> <https://github.com/apache/incubator-taverna-mobile/pull/14>) and I
> have
> >> added some libraries and start working on Announcements features.
> >>
> >> - Added MVP architecture basic
> >> - Setup Retrofit
> >> - Setup Simple xml parser
> >> - Setup Rx-JAVA and Rx-Android
> >> - Setup ButterKnife
> >> - Design Announcement layout
> >> - Working ListView to show all Announcements
> >> - [WIP] Detail of clicked Announcement
> >>
> >> I am currently working on it.
> >>
> >> Rajan Maurya, Please reviews the #PR
> >> <https://github.com/apache/incubator-taverna-mobile/pull/14> till now
> >> and
> >> suggests me something if there is something needed to change .
> >>
> >> If anyone else wants to work on it or review my work, it'd be great.
> >>
> >> --
> >>
> >> *With warm regards *
> >> *Sincerely yours*
> >> Sagar
> >>
> >>
> >> *Student ,(6th Semester )B.Tech IT and mathematical innovation*
> >> *Cluster Innovation Centre*
> >> *University of Delhi *
> >>
> >
> >
> >
> > --
> > *Thanks*
> > *Namaste*
> >
> > Rajan Maurya
> > Contact Number : +91 8010665248
> > Github : https://github.com/therajanmaurya
> > College : Cluster Innovation Centre, University of Delhi
> > Student : B.Tech. (Information Technology & Mathematical Innovations)
> >
> >
>
Re: Taverna Mobile Application
Posted by Rajan Maurya <ra...@gmail.com>.
Hi Sagar,
I have reviewed the PR.
Please look and fix all of these that i have mentioned.
Thanks
On Jun 2, 2016 11:23 AM, "Rajan Maurya" <ra...@gmail.com> wrote:
> Hi Sagar,
>
> Its looks good. I will review it today and update you if there is any
> need to change.
>
> Implement rest of Announcement Details part
>
> Good :)
>
>
> On Thu, Jun 2, 2016 at 10:58 AM, Sagar <ku...@gmail.com> wrote:
>
>> Hi All,
>> My semester end exam gone well and I am starting my internship on this
>> project as we talk earlier, Now I started working on Taverna Mobile
>> Application.
>>
>> I go through Rajan Maurya's GsoC proposal and found he researched well and
>> I am following it as accordingly.
>>
>> I have sent a pull request (PR no #14
>> <https://github.com/apache/incubator-taverna-mobile/pull/14>) and I have
>> added some libraries and start working on Announcements features.
>>
>> - Added MVP architecture basic
>> - Setup Retrofit
>> - Setup Simple xml parser
>> - Setup Rx-JAVA and Rx-Android
>> - Setup ButterKnife
>> - Design Announcement layout
>> - Working ListView to show all Announcements
>> - [WIP] Detail of clicked Announcement
>>
>> I am currently working on it.
>>
>> Rajan Maurya, Please reviews the #PR
>> <https://github.com/apache/incubator-taverna-mobile/pull/14> till now
>> and
>> suggests me something if there is something needed to change .
>>
>> If anyone else wants to work on it or review my work, it'd be great.
>>
>> --
>>
>> *With warm regards *
>> *Sincerely yours*
>> Sagar
>>
>>
>> *Student ,(6th Semester )B.Tech IT and mathematical innovation*
>> *Cluster Innovation Centre*
>> *University of Delhi *
>>
>
>
>
> --
> *Thanks*
> *Namaste*
>
> Rajan Maurya
> Contact Number : +91 8010665248
> Github : https://github.com/therajanmaurya
> College : Cluster Innovation Centre, University of Delhi
> Student : B.Tech. (Information Technology & Mathematical Innovations)
>
>
Re: Taverna Mobile Application
Posted by Rajan Maurya <ra...@gmail.com>.
Hi Sagar,
Its looks good. I will review it today and update you if there is any need
to change.
Implement rest of Announcement Details part
Good :)
On Thu, Jun 2, 2016 at 10:58 AM, Sagar <ku...@gmail.com> wrote:
> Hi All,
> My semester end exam gone well and I am starting my internship on this
> project as we talk earlier, Now I started working on Taverna Mobile
> Application.
>
> I go through Rajan Maurya's GsoC proposal and found he researched well and
> I am following it as accordingly.
>
> I have sent a pull request (PR no #14
> <https://github.com/apache/incubator-taverna-mobile/pull/14>) and I have
> added some libraries and start working on Announcements features.
>
> - Added MVP architecture basic
> - Setup Retrofit
> - Setup Simple xml parser
> - Setup Rx-JAVA and Rx-Android
> - Setup ButterKnife
> - Design Announcement layout
> - Working ListView to show all Announcements
> - [WIP] Detail of clicked Announcement
>
> I am currently working on it.
>
> Rajan Maurya, Please reviews the #PR
> <https://github.com/apache/incubator-taverna-mobile/pull/14> till now and
> suggests me something if there is something needed to change .
>
> If anyone else wants to work on it or review my work, it'd be great.
>
> --
>
> *With warm regards *
> *Sincerely yours*
> Sagar
>
>
> *Student ,(6th Semester )B.Tech IT and mathematical innovation*
> *Cluster Innovation Centre*
> *University of Delhi *
>
--
*Thanks*
*Namaste*
Rajan Maurya
Contact Number : +91 8010665248
Github : https://github.com/therajanmaurya
College : Cluster Innovation Centre, University of Delhi
Student : B.Tech. (Information Technology & Mathematical Innovations)