You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/02 13:20:44 UTC

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31611: [SPARK-34488][CORE] Support task Metrics Distributions and executor Metrics Distributions in the REST API call for a specified stage

AngersZhuuuu commented on a change in pull request #31611:
URL: https://github.com/apache/spark/pull/31611#discussion_r585557644



##########
File path: docs/monitoring.md
##########
@@ -479,11 +479,31 @@ can be identified by their `[attempt-id]`. In the API listed below, when running
     <td><code>/applications/[app-id]/stages/[stage-id]</code></td>
     <td>
       A list of all attempts for the given stage.
+        <br><code>?details=true</code> list all attempts with stage detail data.
+        <br><code>?withSummaries=true</code> list task metrics distribution and executor metrics distribution
+        of each attempt.
+        <br><code>?quantiles=0.1,0.25,0.5,0.75,1.0</code> summarize the metrics with the given quantiles.

Review comment:
       Done

##########
File path: docs/monitoring.md
##########
@@ -479,11 +479,31 @@ can be identified by their `[attempt-id]`. In the API listed below, when running
     <td><code>/applications/[app-id]/stages/[stage-id]</code></td>
     <td>
       A list of all attempts for the given stage.
+        <br><code>?details=true</code> list all attempts with stage detail data.

Review comment:
       Done

##########
File path: docs/monitoring.md
##########
@@ -479,11 +479,31 @@ can be identified by their `[attempt-id]`. In the API listed below, when running
     <td><code>/applications/[app-id]/stages/[stage-id]</code></td>
     <td>
       A list of all attempts for the given stage.
+        <br><code>?details=true</code> list all attempts with stage detail data.
+        <br><code>?withSummaries=true</code> list task metrics distribution and executor metrics distribution
+        of each attempt.
+        <br><code>?quantiles=0.1,0.25,0.5,0.75,1.0</code> summarize the metrics with the given quantiles.
+        default value is <code>0.1,0.25,0.5,0.75,1.0</code>, only effect when <code>withSummaries=true</code>

Review comment:
       Done

##########
File path: docs/monitoring.md
##########
@@ -479,11 +479,31 @@ can be identified by their `[attempt-id]`. In the API listed below, when running
     <td><code>/applications/[app-id]/stages/[stage-id]</code></td>
     <td>
       A list of all attempts for the given stage.
+        <br><code>?details=true</code> list all attempts with stage detail data.
+        <br><code>?withSummaries=true</code> list task metrics distribution and executor metrics distribution
+        of each attempt.
+        <br><code>?quantiles=0.1,0.25,0.5,0.75,1.0</code> summarize the metrics with the given quantiles.
+        default value is <code>0.1,0.25,0.5,0.75,1.0</code>, only effect when <code>withSummaries=true</code>
+      <br>Example:
+        <br><code>?details=true</code>
+        <br><code>?withSummaries=true</code>
+        <br><code>?details=true&withSummaries=true&quantiles=0.01,0.5,0.99</code>
     </td>
   </tr>
   <tr>
     <td><code>/applications/[app-id]/stages/[stage-id]/[stage-attempt-id]</code></td>
-    <td>Details for the given stage attempt.</td>
+    <td>
+      Details for the given stage attempt.
+      <br><code>?details=true</code> list all attempts with stage detail data.

Review comment:
       Done

##########
File path: docs/monitoring.md
##########
@@ -479,11 +479,31 @@ can be identified by their `[attempt-id]`. In the API listed below, when running
     <td><code>/applications/[app-id]/stages/[stage-id]</code></td>
     <td>
       A list of all attempts for the given stage.
+        <br><code>?details=true</code> list all attempts with stage detail data.
+        <br><code>?withSummaries=true</code> list task metrics distribution and executor metrics distribution
+        of each attempt.
+        <br><code>?quantiles=0.1,0.25,0.5,0.75,1.0</code> summarize the metrics with the given quantiles.
+        default value is <code>0.1,0.25,0.5,0.75,1.0</code>, only effect when <code>withSummaries=true</code>
+      <br>Example:
+        <br><code>?details=true</code>
+        <br><code>?withSummaries=true</code>
+        <br><code>?details=true&withSummaries=true&quantiles=0.01,0.5,0.99</code>
     </td>
   </tr>
   <tr>
     <td><code>/applications/[app-id]/stages/[stage-id]/[stage-attempt-id]</code></td>
-    <td>Details for the given stage attempt.</td>
+    <td>
+      Details for the given stage attempt.
+      <br><code>?details=true</code> list all attempts with stage detail data.
+      <br><code>?withSummaries=true</code> list task metrics distribution and executor metrics distribution
+      of each attempt.
+      <br><code>?quantiles=0.1,0.25,0.5,0.75,1.0</code> summarize the metrics with the given quantiles.

Review comment:
       Done

##########
File path: docs/monitoring.md
##########
@@ -479,11 +479,31 @@ can be identified by their `[attempt-id]`. In the API listed below, when running
     <td><code>/applications/[app-id]/stages/[stage-id]</code></td>
     <td>
       A list of all attempts for the given stage.
+        <br><code>?details=true</code> list all attempts with stage detail data.
+        <br><code>?withSummaries=true</code> list task metrics distribution and executor metrics distribution
+        of each attempt.
+        <br><code>?quantiles=0.1,0.25,0.5,0.75,1.0</code> summarize the metrics with the given quantiles.
+        default value is <code>0.1,0.25,0.5,0.75,1.0</code>, only effect when <code>withSummaries=true</code>
+      <br>Example:
+        <br><code>?details=true</code>
+        <br><code>?withSummaries=true</code>
+        <br><code>?details=true&withSummaries=true&quantiles=0.01,0.5,0.99</code>
     </td>
   </tr>
   <tr>
     <td><code>/applications/[app-id]/stages/[stage-id]/[stage-attempt-id]</code></td>
-    <td>Details for the given stage attempt.</td>
+    <td>
+      Details for the given stage attempt.
+      <br><code>?details=true</code> list all attempts with stage detail data.
+      <br><code>?withSummaries=true</code> list task metrics distribution and executor metrics distribution
+      of each attempt.
+      <br><code>?quantiles=0.1,0.25,0.5,0.75,1.0</code> summarize the metrics with the given quantiles.
+      default value is <code>0.1,0.25,0.5,0.75,1.0</code>, only effect when <code>withSummaries=true</code>

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org