You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/02 01:32:13 UTC

[GitHub] [incubator-mxnet] access2rohit opened a new pull request #19271: [WIP]adding tests for convolution layer with large inputs

access2rohit opened a new pull request #19271:
URL: https://github.com/apache/incubator-mxnet/pull/19271


   ## Description ##
   adds test for convolution layer with large inputs.
   
   ## Checklist ##
   ### Essentials ###
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage
   - [x] Code is well-documented
   
   ### Testing ###
    will update


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu merged pull request #19271: Added tests for convolution layer with large inputs

Posted by GitBox <gi...@apache.org>.
leezu merged pull request #19271:
URL: https://github.com/apache/incubator-mxnet/pull/19271


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu commented on a change in pull request #19271: Added tests for convolution layer with large inputs

Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #19271:
URL: https://github.com/apache/incubator-mxnet/pull/19271#discussion_r535720318



##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -2345,3 +2349,27 @@ def test_insert():
     assert out[0, 1] == 1 and out[-1, 1] == 2
     assert out2[1] == 5 and out2[2] == 6
     assertRaises(MXNetError, np.insert, arr=inp3, obj=np.array([2, 2], dtype=np.int64), values=np.array([5, 6]))
+
+@pytest.mark.skip(reason='times out (20 mins)')
+def test_convolution():
+    dim = 2
+    batch_size = 1
+    channel = 3
+    height = SMALL_Y
+    width = LARGE_X // 3
+    num_filter = 4
+    kernel = (3,) * dim   # => shape = (3, 3)
+
+    inp=mx.np.ones(shape=(batch_size, channel, height, width))
+    weight = mx.np.ones(shape=(num_filter, channel, kernel[0], kernel[1]))
+    bias = mx.np.array(num_filter,)
+    inp.attach_grad()
+    with mx.autograd.record():
+        out = mx.npx.convolution(data=inp, weight=weight, num_filter=num_filter, \
+                                 kernel=kernel, no_bias=True)

Review comment:
       You could specify a stride to reduce the computational complexity and speed up the test?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19271: [WIP]adding tests for convolution layer with large inputs

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19271:
URL: https://github.com/apache/incubator-mxnet/pull/19271#issuecomment-702480275


   Hey @access2rohit , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [clang, website, unix-gpu, sanity, windows-cpu, unix-cpu, centos-gpu, windows-gpu, edge, centos-cpu, miscellaneous]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] access2rohit closed pull request #19271: Added tests for convolution layer with large inputs

Posted by GitBox <gi...@apache.org>.
access2rohit closed pull request #19271:
URL: https://github.com/apache/incubator-mxnet/pull/19271


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org