You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "tsonglew (via GitHub)" <gi...@apache.org> on 2024/11/12 08:18:46 UTC
[PR] Perf ignore uuid and timestamp generation for NoopContext [skywalking-python]
tsonglew opened a new pull request, #361:
URL: https://github.com/apache/skywalking-python/pull/361
### Improve the performance of NoopSpan
- [x] Add a benchmark for the improvement
- [x] The benchmark result.
Before
```text
----------------------------------------------------------------------------------------- benchmark: 3 tests -----------------------------------------------------------------------------------------
Name (time in ms) Min Max Mean StdDev Median IQR Outliers OPS Rounds Iterations
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_noopspan_1000 16.3042 (1.0) 23.7947 (1.0) 17.9170 (1.0) 1.9692 (1.0) 17.2309 (1.0) 1.0547 (1.0) 7;7 55.8130 (1.0) 39 1
test_noopspan_40000 869.6260 (53.34) 924.5368 (38.85) 901.9029 (50.34) 24.5816 (12.48) 916.3565 (53.18) 40.6119 (38.50) 1;0 1.1088 (0.02) 5 1
test_noopspan_200k 4,691.7849 (287.77) 4,847.9470 (203.74) 4,778.1474 (266.68) 67.2721 (34.16) 4,791.8445 (278.10) 118.2709 (112.13) 2;0 0.2093 (0.00) 5 1
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
```
After
```text
------------------------------------------------------------------------------------------ benchmark: 3 tests ------------------------------------------------------------------------------------------
Name (time in ms) Min Max Mean StdDev Median IQR Outliers OPS Rounds Iterations
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_noopspan_1000 4.1980 (1.0) 10.8732 (1.0) 5.3377 (1.0) 1.7625 (1.0) 4.5595 (1.0) 0.2741 (1.0) 15;15 187.3464 (1.0) 83 1
test_noopspan_40000 407.3876 (97.04) 415.4321 (38.21) 411.5557 (77.10) 2.9544 (1.68) 411.7374 (90.30) 3.6798 (13.43) 2;0 2.4298 (0.01) 5 1
test_noopspan_200k 2,087.1523 (497.18) 2,446.8792 (225.04) 2,259.6033 (423.33) 139.2377 (79.00) 2,274.1380 (498.77) 206.5788 (753.73) 2;0 0.4426 (0.00) 5 1
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
```
- [x] Links/URLs to the theory proof or discussion articles/blogs.
It seems that uuid and timestamp are useless for a noop span, since it won't be reported for analysis. So remove them to save cpu and time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Perf ignore uuid and timestamp generation for NoopContext [skywalking-python]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #361:
URL: https://github.com/apache/skywalking-python/pull/361#discussion_r1837671134
##########
.github/PULL_REQUEST_TEMPLATE:
##########
@@ -13,7 +13,7 @@
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
-- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
+- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/9e36eaccb4b4703101d83f920c3c58638e739298/oap-server/microbench/src/main/java/org/apache/skywalking/oap/server/microbench/library/datacarrier/LinkedArrayBenchmark.java)
Review Comment:
I think we just need to point to master branch? You could update this after this PR get accepted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Perf ignore uuid and timestamp generation for NoopContext [skywalking-python]
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 merged PR #361:
URL: https://github.com/apache/skywalking-python/pull/361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org