[jira] [Commented] (LOG4PHP-182) Improve coding standards by using PHP_CodeSniffer

["Bruce Ingalls (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4PHP-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397735#comment-13397735 ] 

Bruce Ingalls commented on LOG4PHP-182:
---------------------------------------

You'll also want to run PhpMD.

I'm partial to PEAR style, which seems to be most popular. It has some differences with log4php style, but is the closest of all CodeSniffer styles. It is unfortunate that log4php installs like a PEAR lib (but not yet a PHAR package), yet has a little different style.

Note that my small contribution started as PEAR style, which I then had to 'fix' into log4php style, which was not too bad.
Also note that ApiGen seems to be replacing PhpDoc/umentor, but currently is compatible.
                
> Improve coding standards by using PHP_CodeSniffer
> -------------------------------------------------
>
>                 Key: LOG4PHP-182
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-182
>             Project: Log4php
>          Issue Type: Improvement
>          Components: Code
>    Affects Versions: 2.2.1
>            Reporter: Ivan Habunek
>            Assignee: Ivan Habunek
>            Priority: Minor
>
> The coding standards for the project are defined in: 
> http://logging.apache.org/log4php/contributingpatches.html
> I propose to create a ruleset for PHP_CodeSniffer which reflects these standards, and to run a check as a part of our build process.
> Some rules may need to be better defined.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira