You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/25 18:29:14 UTC
[GitHub] [incubator-nuttx] a-lunev opened a new pull request #5343: net/tcp/tcp_send_unbuffered: significantly boosted the throughput (to the level of tcp_sendfile)
a-lunev opened a new pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5343: sim/netdev,tapdev: implemented emulation of TX done and RX ready interrupts
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5343: sim/netdev,tapdev: implemented emulation of TX done and RX ready interrupts
Posted by GitBox <gi...@apache.org>.
a-lunev commented on a change in pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343#discussion_r792306532
##########
File path: net/tcp/tcp_send_unbuffered.c
##########
@@ -348,6 +348,10 @@ static uint16_t tcpsend_eventhandler(FAR struct net_driver_s *dev,
&pstate->snd_buffer[pstate->snd_acked],
sndlen);
+ /* Notify the device driver of the availability of TX data */
+
+ tcp_send_txnotify(psock, conn);
Review comment:
Yes, I did it wrong. Please, disregard that first commit. I have totally reworked the patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5343: net/tcp/tcp_send_unbuffered: significantly boosted the throughput (to the level of tcp_sendfile)
Posted by GitBox <gi...@apache.org>.
a-lunev commented on a change in pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343#discussion_r792306532
##########
File path: net/tcp/tcp_send_unbuffered.c
##########
@@ -348,6 +348,10 @@ static uint16_t tcpsend_eventhandler(FAR struct net_driver_s *dev,
&pstate->snd_buffer[pstate->snd_acked],
sndlen);
+ /* Notify the device driver of the availability of TX data */
+
+ tcp_send_txnotify(psock, conn);
Review comment:
Yes, I did a wrong thing. Please, disregard that first commit. I have totally reworked the patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] a-lunev edited a comment on pull request #5343: net/tcp/tcp_send_unbuffered: significantly boosted the throughput (to the level of tcp_sendfile)
Posted by GitBox <gi...@apache.org>.
a-lunev edited a comment on pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343#issuecomment-1021544429
@xiaoxiang781216 in case of sip:tcpblaster config (if CONFIG_NET_SENDFILE=n and CONFIG_NET_TCP_WRITE_BUFFERS=n) this patch increases the TCP throughput (unbuffered TX path) from 205 Kbit/s up to about 432 Mbit/s. However, I am not observing a throughput increase in case of a real hardware (e.g. on ESP32 Wi-Fi). What do you think, is it reasonable to merge this change or discard?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] a-lunev commented on pull request #5343: net/tcp/tcp_send_unbuffered: significantly boosted the throughput (to the level of tcp_sendfile)
Posted by GitBox <gi...@apache.org>.
a-lunev commented on pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343#issuecomment-1021544429
@xiaoxiang781216 in case of sip:tcpblaster config this patch increases the TCP throughput (unbuffered TX path) from 205 Kbit/s up to about 432 Mbit/s. However, I am not observing a throughput increase in case of a real hardware (e.g. on ESP32). What do you think, is it reasonable to merge this change or discard?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] a-lunev removed a comment on pull request #5343: net/tcp/tcp_send_unbuffered: significantly boosted the throughput (to the level of tcp_sendfile)
Posted by GitBox <gi...@apache.org>.
a-lunev removed a comment on pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343#issuecomment-1021544429
@xiaoxiang781216 in case of sip:tcpblaster config (if CONFIG_NET_SENDFILE=n and CONFIG_NET_TCP_WRITE_BUFFERS=n) this patch increases the TCP throughput (unbuffered TX path) from 205 Kbit/s up to about 432 Mbit/s. However, I am not observing a throughput increase in case of a real hardware (e.g. on ESP32 Wi-Fi). What do you think, is it reasonable to merge this change or discard?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] a-lunev edited a comment on pull request #5343: net/tcp/tcp_send_unbuffered: significantly boosted the throughput (to the level of tcp_sendfile)
Posted by GitBox <gi...@apache.org>.
a-lunev edited a comment on pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343#issuecomment-1021544429
@xiaoxiang781216 in case of sip:tcpblaster config (if CONFIG_NET_SENDFILE=n and CONFIG_NET_TCP_WRITE_BUFFERS=n) this patch increases the TCP throughput (unbuffered TX path) from 205 Kbit/s up to about 432 Mbit/s. However, I am not observing a throughput increase in case of a real hardware (e.g. on ESP32). What do you think, is it reasonable to merge this change or discard?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5343: net/tcp/tcp_send_unbuffered: significantly boosted the throughput (to the level of tcp_sendfile)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343#discussion_r792285654
##########
File path: net/tcp/tcp_send_unbuffered.c
##########
@@ -348,6 +348,10 @@ static uint16_t tcpsend_eventhandler(FAR struct net_driver_s *dev,
&pstate->snd_buffer[pstate->snd_acked],
sndlen);
+ /* Notify the device driver of the availability of TX data */
+
+ tcp_send_txnotify(psock, conn);
Review comment:
I think the top level will call tcp_send_txnotify, why we need call here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] a-lunev commented on pull request #5343: sim/netdev,tuntap: implemented emulation of TX done and RX ready interrupts
Posted by GitBox <gi...@apache.org>.
a-lunev commented on pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343#issuecomment-1021855885
The PR is still draft. To be continued ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] a-lunev commented on pull request #5343: sim/netdev,tapdev: implemented emulation of TX done and RX ready interrupts
Posted by GitBox <gi...@apache.org>.
a-lunev commented on pull request #5343:
URL: https://github.com/apache/incubator-nuttx/pull/5343#issuecomment-1023268068
Ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org