You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2020/06/30 14:40:45 UTC
[kudu-CR] KUDU-3090 Ownership support in Java client
Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16125
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
KUDU-3090 Ownership support in Java client
Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
---
M java/kudu-client/build.gradle
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
D java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
10 files changed, 47 insertions(+), 94 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/16125/1
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Greg Solovyev, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16125
to look at the new patch set (#6).
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
KUDU-3090 Ownership support in Java client
Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
---
M java/kudu-client/build.gradle
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
D java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
12 files changed, 76 insertions(+), 93 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/16125/6
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 )
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
Patch Set 4:
(2 comments)
> Patch Set 3:
>
> Please add some tests for the new API.
ok, done. let me know if you think we need additional tests
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
File java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java:
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java@a262
PS3, Line 262:
> why delete this check?
not sure, this was in Grant's initial WIP patch, readded it.
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java:
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java@a32
PS3, Line 32:
> I am not sure why you are deleting this test. Are we still planning to sync
not sure, this was in Grant's initial WIP patch, readded it and modified it to check for Kudu ownership as well.
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 01 Jul 2020 15:12:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 )
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
File java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java:
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java@a262
PS3, Line 262:
> not sure, this was in Grant's initial WIP patch, readded it.
I think the intent was to prevent setting a null or "" owner since that doesn't make much sense given we always expect a table to have an owner.
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java:
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java@a32
PS3, Line 32:
> not sure, this was in Grant's initial WIP patch, readded it and modified it
We don't need to validate the HMS integration Java side now. It has nothing to do with the Java client and results in an extra HMS dependency.
Instead we should, and do, validate the HMS integration in the C++ server code.
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 06 Jul 2020 13:01:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 )
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 08 Jul 2020 14:04:06 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 )
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
File java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java:
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java@a262
PS3, Line 262:
> makes sense, there's a check on the server side now anyway, so I removed it
Done
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 07 Jul 2020 20:22:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 )
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
File java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java:
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java@a262
PS3, Line 262:
why delete this check?
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java:
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java@a32
PS3, Line 32:
I am not sure why you are deleting this test. Are we still planning to synchronize owner information between HMS and Kudu metadata?
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 30 Jun 2020 23:27:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Grant Henke, Greg Solovyev,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16125
to look at the new patch set (#8).
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
KUDU-3090 Ownership support in Java client
Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
---
M java/kudu-client/build.gradle
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
D java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
12 files changed, 77 insertions(+), 95 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/16125/8
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 )
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 10 Jul 2020 13:48:33 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 )
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16125/7/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java:
http://gerrit.cloudera.org:8080/#/c/16125/7/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@134
PS7, Line 134: * @return this table's owner
> For that matter, it might be worth adding a test for what happens if this is called on such a table. Would it make sense to add a Master flag for that, like --set_owner_to_user_if_none_specified or something?
Do you mean the master would return a specified user for unowned tables? I'm not sure that's a good idea as users wouldn't be able to tell apart unowned tables and tables owned by that user.
> Would also be useful in testing the C++ client.
Which tests would it be helpful for?
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 08 Jul 2020 12:16:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16125 )
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
KUDU-3090 Ownership support in Java client
Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Reviewed-on: http://gerrit.cloudera.org:8080/16125
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M java/kudu-client/build.gradle
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
D java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
12 files changed, 77 insertions(+), 95 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 9
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 )
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16125/7/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java:
http://gerrit.cloudera.org:8080/#/c/16125/7/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java@134
PS7, Line 134: * @return this table's owner
nit: mind adding something to the effect of "or an empty string if the table was created without an owner on a version of Kudu that didn't automatically assign an owner" or somesuch?
For that matter, it might be worth adding a test for what happens if this is called on such a table. Would it make sense to add a Master flag for that, like --set_owner_to_user_if_none_specified or something? Would also be useful in testing the C++ client.
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 08 Jul 2020 01:56:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16125
to look at the new patch set (#2).
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
KUDU-3090 Ownership support in Java client
Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
---
M java/kudu-client/build.gradle
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
D java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
11 files changed, 50 insertions(+), 95 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/16125/2
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 )
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
Patch Set 3:
Please add some tests for the new API.
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 01 Jul 2020 05:33:30 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Greg Solovyev,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16125
to look at the new patch set (#4).
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
KUDU-3090 Ownership support in Java client
Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
11 files changed, 80 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/16125/4
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 )
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
File java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java:
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java@a262
PS3, Line 262:
> I think the intent was to prevent setting a null or "" owner since that doe
yea but your commit removed the check, was that unintentional?
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java:
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java@a32
PS3, Line 32:
> We don't need to validate the HMS integration Java side now. It has nothing
Makes sense, removed it again.
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 06 Jul 2020 16:07:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Grant Henke, Greg Solovyev,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16125
to look at the new patch set (#7).
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
KUDU-3090 Ownership support in Java client
Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
---
M java/kudu-client/build.gradle
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
D java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
12 files changed, 76 insertions(+), 95 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/16125/7
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 )
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 07 Jul 2020 20:23:14 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 )
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
File java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java:
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java@a262
PS3, Line 262:
> oh, right. Perhaps the intent was to allow easier passthrough in the "defau
makes sense, there's a check on the server side now anyway, so I removed it.
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 07 Jul 2020 14:14:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 )
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
File java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java:
http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java@a262
PS3, Line 262:
> yea but your commit removed the check, was that unintentional?
oh, right. Perhaps the intent was to allow easier passthrough in the "default to current user" case. So that if automated code calls setOwner(null) it would default appropriately.
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 06 Jul 2020 18:46:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3090 Ownership support in Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Greg Solovyev, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16125
to look at the new patch set (#5).
Change subject: KUDU-3090 Ownership support in Java client
......................................................................
KUDU-3090 Ownership support in Java client
Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
---
M java/kudu-client/build.gradle
M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaRequest.java
M java/kudu-client/src/main/java/org/apache/kudu/client/GetTableSchemaResponse.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanToken.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
D java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKeyEncoding.java
12 files changed, 77 insertions(+), 94 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/16125/5
--
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)