You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/04/07 16:02:45 UTC
[GitHub] [shardingsphere] zhujunxxxxx opened a new pull request #9985: Fix oracle metadata loader problem
zhujunxxxxx opened a new pull request #9985:
URL: https://github.com/apache/shardingsphere/pull/9985
Fixes #9617.
Changes proposed in this pull request:
- fix oracle metadata loader
as I know oracle does't have `information_schema` schema, but last contributor query metadata from `information_schema`.
it's wrong, so I according to `https://docs.oracle.com/en/database/oracle/oracle-database` to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #9985: Fix oracle metadata loader problem
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #9985:
URL: https://github.com/apache/shardingsphere/pull/9985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhujunxxxxx commented on pull request #9985: Fix oracle metadata loader problem
Posted by GitBox <gi...@apache.org>.
zhujunxxxxx commented on pull request #9985:
URL: https://github.com/apache/shardingsphere/pull/9985#issuecomment-817087368
@tristaZero need you review.
> > Hi @zhujunxxxxx Thanks for your fixing.
> > @Liangda-w Could you have a look? Since this PR is working on your previous one.
>
> Yes, it's right. Oracle don't have `information_schema` and we should use `ALL_TAB_COLUMNS` instead. Thank you for pointing it out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Liangda-w commented on pull request #9985: Fix oracle metadata loader problem
Posted by GitBox <gi...@apache.org>.
Liangda-w commented on pull request #9985:
URL: https://github.com/apache/shardingsphere/pull/9985#issuecomment-816642485
> Hi @zhujunxxxxx Thanks for your fixing.
> @Liangda-w Could you have a look? Since this PR is working on your previous one.
Yes, it's right. Oracle don't have `information_schema` and we should use `ALL_TAB_COLUMNS` instead. Thank you for pointing it out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhujunxxxxx commented on pull request #9985: Fix oracle metadata loader problem
Posted by GitBox <gi...@apache.org>.
zhujunxxxxx commented on pull request #9985:
URL: https://github.com/apache/shardingsphere/pull/9985#issuecomment-815502384
@tristaZero this PR need you review. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #9985: Fix oracle metadata loader problem
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9985:
URL: https://github.com/apache/shardingsphere/pull/9985#issuecomment-815379276
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9985?src=pr&el=h1) Report
> Merging [#9985](https://codecov.io/gh/apache/shardingsphere/pull/9985?src=pr&el=desc) (2b5bee8) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a1a25457cc7c5c44836e06616af519169666c143?el=desc) (a1a2545) will **increase** coverage by `0.00%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/9985?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9985 +/- ##
=========================================
Coverage 67.91% 67.92%
Complexity 678 678
=========================================
Files 1685 1685
Lines 28395 28410 +15
Branches 5051 5055 +4
=========================================
+ Hits 19285 19298 +13
Misses 7668 7668
- Partials 1442 1444 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/9985?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lder/loader/dialect/OracleTableMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/9985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9zY2hlbWEvYnVpbGRlci9sb2FkZXIvZGlhbGVjdC9PcmFjbGVUYWJsZU1ldGFEYXRhTG9hZGVyLmphdmE=) | `86.76% <88.88%> (-0.03%)` | `1.00 <0.00> (ø)` | |
| [...pache/shardingsphere/encrypt/rule/EncryptRule.java](https://codecov.io/gh/apache/shardingsphere/pull/9985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZW5jcnlwdC9ydWxlL0VuY3J5cHRSdWxlLmphdmE=) | `78.18% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...che/shardingsphere/sharding/rule/ShardingRule.java](https://codecov.io/gh/apache/shardingsphere/pull/9985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9ydWxlL1NoYXJkaW5nUnVsZS5qYXZh) | `69.69% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...e/shardingsphere/authority/rule/AuthorityRule.java](https://codecov.io/gh/apache/shardingsphere/pull/9985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtYXV0aG9yaXR5L3NoYXJkaW5nc3BoZXJlLWF1dGhvcml0eS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2F1dGhvcml0eS9ydWxlL0F1dGhvcml0eVJ1bGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...b/discovery/common/rule/DatabaseDiscoveryRule.java](https://codecov.io/gh/apache/shardingsphere/pull/9985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL2Rpc2NvdmVyeS9jb21tb24vcnVsZS9EYXRhYmFzZURpc2NvdmVyeVJ1bGUuamF2YQ==) | `51.85% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../splitting/common/rule/ReadWriteSplittingRule.java](https://codecov.io/gh/apache/shardingsphere/pull/9985/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZC13cml0ZS1zcGxpdHRpbmcvc2hhcmRpbmdzcGhlcmUtcmVhZC13cml0ZS1zcGxpdHRpbmctY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9yZWFkd3JpdGUvc3BsaXR0aW5nL2NvbW1vbi9ydWxlL1JlYWRXcml0ZVNwbGl0dGluZ1J1bGUuamF2YQ==) | `86.11% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9985?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/9985?src=pr&el=footer). Last update [a1a2545...2b5bee8](https://codecov.io/gh/apache/shardingsphere/pull/9985?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org