You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/05/13 01:32:11 UTC

[GitHub] [trafficserver] maskit commented on a change in pull request #7807: Address assert on captive_action

maskit commented on a change in pull request #7807:
URL: https://github.com/apache/trafficserver/pull/7807#discussion_r631505298



##########
File path: proxy/http/HttpSM.h
##########
@@ -196,6 +196,13 @@ class PendingAction
   {
     return pending_action;
   }
+  void
+  try_clear(Action *current_action)

Review comment:
       +1 on `clear_if_action_is`. `try_clear` reminds me of `try_lock` and make me want to put it into if statement.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org