You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Jark Wu (JIRA)" <ji...@apache.org> on 2017/07/17 10:15:00 UTC

[jira] [Closed] (FLINK-6887) Split up CodeGenerator into several specific CodeGenerator

     [ https://issues.apache.org/jira/browse/FLINK-6887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jark Wu closed FLINK-6887.
--------------------------
    Resolution: Fixed

Fixed in 527e7499c5807be138d1ba0a278917190a7d4cf1

> Split up CodeGenerator into several specific CodeGenerator
> ----------------------------------------------------------
>
>                 Key: FLINK-6887
>                 URL: https://issues.apache.org/jira/browse/FLINK-6887
>             Project: Flink
>          Issue Type: Task
>          Components: Table API & SQL
>            Reporter: Jark Wu
>            Assignee: Jark Wu
>             Fix For: 1.4.0
>
>
> Currently, the {{CodeGenerator}} is very huge and a bit difficult to maintain. I suggest to split it up into several specific {{XXXCodeGenerator}}.
> For example, create {{AggregationFunctionCodeGenerator}}  class and make it extend to {{CodeGenerator}} and move the {{def generateAggregations(...)}} method to it. The same as {{TableFunctionCollectorCodeGenerator}} and {{InputFormatCodeGenerator}}.
> What do you think? [~fhueske], [~twalthr], [~sunjincheng121]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)