You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/10/21 20:06:36 UTC

[GitHub] [hive] szlta commented on a diff in pull request #3695: HIVE-26657: [Iceberg] Filter out the metadata.json file when migrating

szlta commented on code in PR #3695:
URL: https://github.com/apache/hive/pull/3695#discussion_r1002148004


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveTableUtil.java:
##########
@@ -125,7 +125,7 @@ private static List<DataFile> getDataFiles(RemoteIterator<LocatedFileStatus> fil
     while (fileStatusIterator.hasNext()) {
       LocatedFileStatus fileStatus = fileStatusIterator.next();
       String fileName = fileStatus.getPath().getName();
-      if (fileName.startsWith(".") || fileName.startsWith("_")) {
+      if (fileName.startsWith(".") || fileName.startsWith("_") || fileName.endsWith("metadata.json")) {

Review Comment:
   So metadata files are handled, but are snapshot files (that are avro formatted) going to cause similar issues?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org