You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by gmokki <gi...@git.apache.org> on 2016/02/15 09:44:48 UTC
[GitHub] tomcat pull request: Generalize the precompressed content serving ...
GitHub user gmokki opened a pull request:
https://github.com/apache/tomcat/pull/28
Generalize the precompressed content serving from DefaultServlet
Replaces all gzip specific handling with more generic precompressed content handling.
More specifically, if the new precompressed parameter of DefaultServlet is set to true also brotli compressed (.br) files will be served in addition to gzipped files.
The old gzip parameter functionality is preserved for backwards compatibility, but removed from documentation.
The defining of new precompression file formats as parameter to the DefaultServlet can be added at later time.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NitorCreations/tomcat generalize-precompressed-content-serving
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tomcat/pull/28.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #28
----
commit c82eeabd5f4215ea3c60599a241b2bf0dcdfeed4
Author: Mikko Tiihonen <mi...@nitorcreations.com>
Date: 2016-02-15T08:18:52Z
Generalize the precompressed content serving from DefaultServlet to support by default also brotli compressed files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat pull request: Generalize the precompressed content serving ...
Posted by markt-asf <gi...@git.apache.org>.
Github user markt-asf commented on the pull request:
https://github.com/apache/tomcat/pull/28#issuecomment-188460191
Generally I like this patch. I do have a couple of comments:
- I think it makes sense to make the change to a generic approach immediately. One way of doing this would be for the precompressed init param to take a comma separated list like ".gz,gzip,.br,br". It would need suitable sanity checking.
- The preference for different encodings is set by the client, not the server. See RFC7231, section 5.3.4. Look at o.a.catalina.Request.parseLocales() for a way of handling q values.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat pull request: Generalize the precompressed content serving ...
Posted by gmokki <gi...@git.apache.org>.
Github user gmokki commented on the pull request:
https://github.com/apache/tomcat/pull/28#issuecomment-189250517
Thank you for the review comments.
Modified pull request to accept and pare "gzip=.gz,br=.br" syntax in the precompressed init parameter.
Honors the full client preference settings from client as per RFC7231, including * and identity types.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] tomcat pull request: Generalize the precompressed content serving ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tomcat/pull/28
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org