You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "hangc0276 (via GitHub)" <gi...@apache.org> on 2023/08/21 01:06:49 UTC
[GitHub] [pulsar] hangc0276 opened a new pull request, #20909: [fix] [doc] Update BookKeeper metadataServiceUri doc
hangc0276 opened a new pull request, #20909:
URL: https://github.com/apache/pulsar/pull/20909
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
-->
<!-- Either this PR fixes an issue, -->
Fixes #xyz
<!-- or this PR is one task of an issue -->
Main Issue: #xyz
<!-- If the PR belongs to a PIP, please add the PIP link here -->
PIP: #xyz
<!-- Details of when a PIP is required and how the PIP process work, please see: https://github.com/apache/pulsar/blob/master/pip/README.md -->
### Motivation
If we want to use `PulsarMetadataClientDriver` in BookKeeper server, the document in conf/bookkeeper.conf is confused and it's hard for users to configure the right `metadataServiceUri` format.
<!-- Explain here the context, and why you're making that change. What is the problem you're trying to solve. -->
### Modifications
Add a document in `conf/bookkeeper.conf` to guide users to configure the right `metadataServiceUri` format.
<!-- Describe the modifications you've done. -->
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #20909: [fix] [doc] Update BookKeeper metadataServiceUri doc
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao commented on code in PR #20909:
URL: https://github.com/apache/pulsar/pull/20909#discussion_r1280470203
##########
conf/bookkeeper.conf:
##########
@@ -644,8 +644,12 @@ diskCheckInterval=10000
# Metadata service uri that bookkeeper uses for loading the corresponding metadata driver and resolving its metadata service location
# Examples:
-# - metadataServiceUri=zk://my-zk-1:2181/ledgers
-# - metadataServiceUri=etcd:http://my-etcd:2379
+# - metadataServiceUri=zk+hierarchical://my-zk-1:2181/ledgers
+# - metadataServiceUri=etcd+hierarchical:http://my-etcd:2379
+# - metadataServiceUri=metadata-store:zk:my-zk-1:2281
+# If you use metadata-store configuration, you need to configure following items in JVM option:
Review Comment:
Maybe we should explain why we must set the `metadata-store` prefix. WDYT? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #20909: [fix] [doc] Update BookKeeper metadataServiceUri doc
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #20909:
URL: https://github.com/apache/pulsar/pull/20909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #20909: [fix] [doc] Update BookKeeper metadataServiceUri doc
Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- closed pull request #20909: [fix] [doc] Update BookKeeper metadataServiceUri doc
URL: https://github.com/apache/pulsar/pull/20909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #20909: [fix] [doc] Update BookKeeper metadataServiceUri doc
Posted by "mattisonchao (via GitHub)" <gi...@apache.org>.
mattisonchao commented on code in PR #20909:
URL: https://github.com/apache/pulsar/pull/20909#discussion_r1280456755
##########
conf/bookkeeper.conf:
##########
@@ -644,8 +644,12 @@ diskCheckInterval=10000
# Metadata service uri that bookkeeper uses for loading the corresponding metadata driver and resolving its metadata service location
# Examples:
-# - metadataServiceUri=zk://my-zk-1:2181/ledgers
-# - metadataServiceUri=etcd:http://my-etcd:2379
+# - metadataServiceUri=zk+hierarchical://my-zk-1:2181/ledgers
+# - metadataServiceUri=etcd+hierarchical:http://my-etcd:2379
+# - metadataServiceUri=metadata-store:zk:my-zk-1:2281
+# If you use metadata-store configuration, you need to configure following items in JVM option:
Review Comment:
```suggestion
# If you want to use the Apache Pulsar metadata-store driver, you need to configure the following items in the JVM option:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #20909: [fix] [doc] Update BookKeeper metadataServiceUri doc
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20909:
URL: https://github.com/apache/pulsar/pull/20909#issuecomment-1685515039
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20909?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#20909](https://app.codecov.io/gh/apache/pulsar/pull/20909?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1597362) into [master](https://app.codecov.io/gh/apache/pulsar/commit/ca01447fb4df808f8e2da2dc75d44fad0b780032?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ca01447) will **decrease** coverage by `36.28%`.
> Report is 30 commits behind head on master.
> The diff coverage is `n/a`.
[](https://app.codecov.io/gh/apache/pulsar/pull/20909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #20909 +/- ##
=============================================
- Coverage 73.14% 36.86% -36.28%
+ Complexity 32221 12681 -19540
=============================================
Files 1874 1698 -176
Lines 139379 134965 -4414
Branches 15328 15045 -283
=============================================
- Hits 101942 49749 -52193
- Misses 29352 78701 +49349
+ Partials 8085 6515 -1570
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/20909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/20909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.26% <ø> (+0.06%)` | :arrow_up: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/20909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `25.14% <ø> (-0.06%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/20909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.52% <ø> (-39.88%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1439 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20909/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org