You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2019/05/16 20:21:29 UTC

Review Request 70659: RANGER-2438: Legacy PublicAPI REST API to get all policies fails

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70659/
-----------------------------------------------------------

Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.


Bugs: RANGER-2348
    https://issues.apache.org/jira/browse/RANGER-2348


Repository: ranger


Description
-------

A 'Get' on the REST endpoint /service/public/api/policy fails when any access-type string is not specified in its internal mapping table. In such case, such access-type is now mapped to value corresponding to 'unknown' access-type.

Also included in the patch is a check when deleting service or service-definition to avoid NPE.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 200347474 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 3ff763c71 


Diff: https://reviews.apache.org/r/70659/diff/1/


Testing
-------

Tested the API using curl script, and verified that the API succeeds and provides list of policies.


Thanks,

Abhay Kulkarni


Re: Review Request 70659: RANGER-2438: Legacy PublicAPI REST API to get all policies fails

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70659/#review215305
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On May 16, 2019, 8:21 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70659/
> -----------------------------------------------------------
> 
> (Updated May 16, 2019, 8:21 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2348
>     https://issues.apache.org/jira/browse/RANGER-2348
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> A 'Get' on the REST endpoint /service/public/api/policy fails when any access-type string is not specified in its internal mapping table. In such case, such access-type is now mapped to value corresponding to 'unknown' access-type.
> 
> Also included in the patch is a check when deleting service or service-definition to avoid NPE.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 200347474 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 3ff763c71 
> 
> 
> Diff: https://reviews.apache.org/r/70659/diff/1/
> 
> 
> Testing
> -------
> 
> Tested the API using curl script, and verified that the API succeeds and provides list of policies.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Re: Review Request 70659: RANGER-2438: Legacy PublicAPI REST API to get all policies fails

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70659/
-----------------------------------------------------------

(Updated May 16, 2019, 8:41 p.m.)


Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.


Bugs: RANGER-2438
    https://issues.apache.org/jira/browse/RANGER-2438


Repository: ranger


Description
-------

A 'Get' on the REST endpoint /service/public/api/policy fails when any access-type string is not specified in its internal mapping table. In such case, such access-type is now mapped to value corresponding to 'unknown' access-type.

Also included in the patch is a check when deleting service or service-definition to avoid NPE.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/common/ServiceUtil.java 200347474 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 3ff763c71 


Diff: https://reviews.apache.org/r/70659/diff/1/


Testing
-------

Tested the API using curl script, and verified that the API succeeds and provides list of policies.


Thanks,

Abhay Kulkarni