You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/21 00:36:32 UTC
[GitHub] [incubator-superset] nytai opened a new pull request #10369: fix: allow creating option in table select in dataset add modal
nytai opened a new pull request #10369:
URL: https://github.com/apache/incubator-superset/pull/10369
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
There is currently an issue with adding google sheets as datasets. The dataset add modal expects there to be a schema selected before table select is enabled. Since google sheets don't have schemas there is no way to add a google sheet as a dataset. The fix is:
- Allow creating option in dataset add modal. Google sheets urls can now be pasted in the select field.
- schema is now optional. Simply leave it blank to add a google sheet.
Trade Offs: there will now be a higher possibility for errors as users will be able to submit the form without shema and the table option now allows input so users can paste non-existent tables into the select field.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
<img width="1684" alt="Screen Shot 2020-07-20 at 5 34 40 PM" src="https://user-images.githubusercontent.com/10255196/87999377-6e7d1480-caaf-11ea-862c-046a67bc1f3d.png">
<img width="908" alt="Screen Shot 2020-07-20 at 5 35 00 PM" src="https://user-images.githubusercontent.com/10255196/87999380-6f15ab00-caaf-11ea-9817-60843a7e9b89.png">
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
- can add a google sheet as a dataset.
- can add a regular table as a dataset
- unit tests pass.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10369: fix: allow creating option in table select in dataset add modal
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10369:
URL: https://github.com/apache/incubator-superset/pull/10369#issuecomment-661650051
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10369?src=pr&el=h1) Report
> Merging [#10369](https://codecov.io/gh/apache/incubator-superset/pull/10369?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1a41ea49880520d296a7cb58f2d8ebccfbd5681a&el=desc) will **increase** coverage by `0.74%`.
> The diff coverage is `62.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10369?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10369 +/- ##
==========================================
+ Coverage 69.70% 70.45% +0.74%
==========================================
Files 196 603 +407
Lines 18950 32431 +13481
Branches 0 3294 +3294
==========================================
+ Hits 13210 22848 +9638
- Misses 5740 9477 +3737
- Partials 0 106 +106
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.38% <66.66%> (?)` | |
| #javascript | `59.33% <62.50%> (?)` | |
| #python | `69.78% <ø> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10369?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/views/datasetList/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10369/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.14% <0.00%> (ø)` | |
| [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10369/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `85.81% <83.33%> (ø)` | |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/10369/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `76.96% <0.00%> (-12.98%)` | :arrow_down: |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/10369/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `93.75% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/10369/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `95.12% <0.00%> (-4.88%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10369/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.50% <0.00%> (-0.92%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/10369/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.04% <0.00%> (-0.34%)` | :arrow_down: |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/10369/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/10369/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `84.65% <0.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/10369/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [421 more](https://codecov.io/gh/apache/incubator-superset/pull/10369/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10369?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10369?src=pr&el=footer). Last update [1a41ea4...ae7f6c1](https://codecov.io/gh/apache/incubator-superset/pull/10369?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai merged pull request #10369: fix: allow creating option in table select in dataset add modal
Posted by GitBox <gi...@apache.org>.
nytai merged pull request #10369:
URL: https://github.com/apache/incubator-superset/pull/10369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org