You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/03/08 02:55:06 UTC

Review Request: FLUME-1926. Optionally timeout Avro Sink Rpc Clients to avoid stickiness

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9813/
-----------------------------------------------------------

Review request for Flume.


Description
-------

Reset connection after a fixed number of seconds in Avro Sink so that a load balancer can add hosts without having to restart Flume


This addresses bug FLUME-1926.
    https://issues.apache.org/jira/browse/FLUME-1926


Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/sink/AbstractRpcSink.java f5699e4 
  flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java 3b1c8db 
  flume-ng-doc/sphinx/FlumeUserGuide.rst f9088f9 

Diff: https://reviews.apache.org/r/9813/diff/


Testing
-------

Added unit tests testing the enabled and disabled conditions.


Thanks,

Hari Shreedharan


Re: Review Request: FLUME-1926. Optionally timeout Avro Sink Rpc Clients to avoid stickiness

Posted by Juhani Connolly <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9813/#review17855
-----------------------------------------------------------

Ship it!


Ship It!

- Juhani Connolly


On March 8, 2013, 1:56 a.m., Hari Shreedharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9813/
> -----------------------------------------------------------
> 
> (Updated March 8, 2013, 1:56 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> Reset connection after a fixed number of seconds in Avro Sink so that a load balancer can add hosts without having to restart Flume
> 
> 
> This addresses bug FLUME-1926.
>     https://issues.apache.org/jira/browse/FLUME-1926
> 
> 
> Diffs
> -----
> 
>   flume-ng-core/src/main/java/org/apache/flume/sink/AbstractRpcSink.java f5699e4 
>   flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java 3b1c8db 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst f9088f9 
> 
> Diff: https://reviews.apache.org/r/9813/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests testing the enabled and disabled conditions.
> 
> 
> Thanks,
> 
> Hari Shreedharan
> 
>


Re: Review Request: FLUME-1926. Optionally timeout Avro Sink Rpc Clients to avoid stickiness

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9813/
-----------------------------------------------------------

(Updated March 8, 2013, 1:56 a.m.)


Review request for Flume.


Description
-------

Reset connection after a fixed number of seconds in Avro Sink so that a load balancer can add hosts without having to restart Flume


This addresses bug FLUME-1926.
    https://issues.apache.org/jira/browse/FLUME-1926


Diffs (updated)
-----

  flume-ng-core/src/main/java/org/apache/flume/sink/AbstractRpcSink.java f5699e4 
  flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java 3b1c8db 
  flume-ng-doc/sphinx/FlumeUserGuide.rst f9088f9 

Diff: https://reviews.apache.org/r/9813/diff/


Testing
-------

Added unit tests testing the enabled and disabled conditions.


Thanks,

Hari Shreedharan